From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6553C46ADC for ; Thu, 3 Aug 2023 16:44:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F13568C1B7; Thu, 3 Aug 2023 19:44:25 +0300 (EEST) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2908B68BE41 for ; Thu, 3 Aug 2023 19:44:20 +0300 (EEST) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-522bc9556f5so1549211a12.0 for ; Thu, 03 Aug 2023 09:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691081059; x=1691685859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8n5rv4TmzedLjCSDXui7dhlCrLZX4WWwazWbYPP+ANw=; b=dzXg/E9tj+lrMGnm3pSQG8Nbqk6bAZybfL0rc6+tO+4A3iOhfO4eK31PGa5v103Pw7 ZFvpFkj1rWPCSTny5fk15sNT9W8JOdBLJ9UlTMNDDu+h3JNUtSnpwsnZsw7Jv1SjbNw1 6uHWHZBJMkIfFaqbXsU9ywiOt4vz2zWcUcyjAopuzvMDLfmG8YHWwNILOID8oMwQx6Kv 6uZzcDjxTQcgdX4Sm/PYtgae0IQjDKkgWSFZLvGrLQUA7gm3EFjlcOT8Yw9/YDTCigh3 SY+bul2QND05fx9GjKP+qnpejSYNzHnbIJWTQEWgZsR4C3sA0QZ3umbNKoefzeeXItEV M//g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691081059; x=1691685859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8n5rv4TmzedLjCSDXui7dhlCrLZX4WWwazWbYPP+ANw=; b=BKcjGqbQcDqtlfOvK3Bpe5SPbS8M/yuFGCa4IXuowuSK4dfPMWugp4JQw9Mfsxh1mK G7tPipr9urLzKvkFLJSK8qLKLbtwxKSlcIQic83j5rHXu5Gb5EpNUTA13dyBfvWl/jKf 8XAsr9zOYrXjIkM4ispN99Mwu525uwe3kYVC+w/HrNUo9t3vtJSz2nMrB/pWgfu8R+9p AS9w7w87v92voJlMIe3P6f6G8JqcYjxiQlV/WMJqD9mdzSz3KGP7q32gjvcU9jWNENLB okc8t3hFpdEUKUJqy2cAZOPZ/DuVSUl63OaNBcG0xiAK+iku0GRSc4L/KWgpe8AyNR/W JDwg== X-Gm-Message-State: ABy/qLYx+Jc+S9fsQNLj/0jewSkF2jR7pQnwFyLRDN8qm5B0suFY1qeq fbha5YH7zBEnsmbuTQNY+GECvgmwQPQ= X-Google-Smtp-Source: APBJJlFeYAJIul4bv9dcyyI1oNcqXJsj68fjPSFx+yck0rGYRIjW96tvEEwEWAa2Ek0xITd5dcvuGQ== X-Received: by 2002:aa7:d293:0:b0:522:29ee:2ab with SMTP id w19-20020aa7d293000000b0052229ee02abmr8870086edq.14.1691081059435; Thu, 03 Aug 2023 09:44:19 -0700 (PDT) Received: from [192.168.178.30] (dynamic-2a01-0c23-6155-1b00-4cd8-57c3-a09b-883d.c23.pool.telefonica.de. [2a01:c23:6155:1b00:4cd8:57c3:a09b:883d]) by smtp.gmail.com with ESMTPSA id d2-20020a056402516200b0052275deb475sm27569ede.23.2023.08.03.09.44.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Aug 2023 09:44:18 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Thu, 03 Aug 2023 18:44:17 +0200 X-Mailer: MailMate (1.14r5964) Message-ID: <6561CC23-7B71-4647-870F-C91D46144AE5@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/4] avfilter: Deduplicate default video inputs/outputs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3 Aug 2023, at 16:33, Andreas Rheinhardt wrote: > Lots of video filters use a very simple input or output: > An array with a single AVFilterPad whose name is "default" > and whose type is AVMEDIA_TYPE_VIDEO; everything else is unset. > > Given that we never use pointer equality for inputs or outputs*, > we can simply use a single AVFilterPad instead of dozens; this > even saves .data.rel.ro (8312B here) as well as relocations. > > *: In fact, several filters (like the filters in vf_lut.c) > already use the same outputs; furthermore, ff_filter_alloc() > duplicates the input and output pads so that we do not even > work with the pads directly. > > Signed-off-by: Andreas Rheinhardt > --- [...] > +#include "internal.h" > + > +/* An AVFilterPad array whose only entry has name "default" > + * and is of type video. */ > +extern const AVFilterPad ff_video_default_filterpad[1]; This should probably be a Doxygen comment. > > AVFrame *ff_default_get_video_buffer(AVFilterLink *link, int w, int h); > AVFrame *ff_default_get_video_buffer2(AVFilterLink *link, int w, int h, int align); > -- > 2.34.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".