Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/3] doc/examples/transcode: set packet timebase for decoding
Date: Wed, 31 May 2023 16:02:13 -0300
Message-ID: <653b2477-ab7e-269e-4878-4a7a57f7caec@gmail.com> (raw)
In-Reply-To: <20230531153205.24424-1-anton@khirnov.net>

On 5/31/2023 12:32 PM, Anton Khirnov wrote:
> It is recommended for callers to set it, though not required.

Add this comment to the file. It's meant to be an example for library 
users to refer to for their implementations, after all.

> ---
>   doc/examples/transcode.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c
> index 805a028ed7..7110816fe6 100644
> --- a/doc/examples/transcode.c
> +++ b/doc/examples/transcode.c
> @@ -97,6 +97,9 @@ static int open_input_file(const char *filename)
>                      "for stream #%u\n", i);
>               return ret;
>           }
> +
> +        codec_ctx->pkt_timebase = stream->time_base;
> +
>           /* Reencode video & audio and remux subtitles etc. */
>           if (codec_ctx->codec_type == AVMEDIA_TYPE_VIDEO
>                   || codec_ctx->codec_type == AVMEDIA_TYPE_AUDIO) {
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-05-31 19:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 15:32 Anton Khirnov
2023-05-31 15:32 ` [FFmpeg-devel] [PATCH 2/3] doc/examples/transcode: stop using decoder's AVCodecContext.time_base Anton Khirnov
2023-05-31 16:04   ` Paul B Mahol
2023-05-31 15:32 ` [FFmpeg-devel] [PATCH 3/3] doc/examples/transcode: convert timestamps between filtering and encoding Anton Khirnov
2023-05-31 16:04   ` Paul B Mahol
2023-05-31 16:03 ` [FFmpeg-devel] [PATCH 1/3] doc/examples/transcode: set packet timebase for decoding Paul B Mahol
2023-05-31 19:02 ` James Almer [this message]
2023-06-04 14:29   ` Stefano Sabatini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=653b2477-ab7e-269e-4878-4a7a57f7caec@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git