Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule

[Lynne <dev@lynne.ee>]

On 27/02/2025 02:10, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   doc/developer.texi | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/doc/developer.texi b/doc/developer.texi
> index a1bfe180c9b..6a753f99da6 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -179,18 +179,17 @@ int fields = ilace ? 2 : 1;
>   @end example
>   
>   @item
> -No braces around single-line blocks:
> +No braces around single-line blocks, unless they are followed by an else (to keep future patches cleaner)
>   
>   @example c, good
>   // Good
> -if (bits_pixel == 24)
> +if (bits_pixel == 24) @{
>       avctx->pix_fmt = AV_PIX_FMT_BGR24;
> -else if (bits_pixel == 8)
> +@} else if (bits_pixel == 8) @{
>       avctx->pix_fmt = AV_PIX_FMT_GRAY8;
> -else @{
> -    av_log(avctx, AV_LOG_ERROR, "Invalid pixel format.\n");
> +@} else
>       return AVERROR_INVALIDDATA;
> -@}
> +
>   @end example
>   
>   @item

Strongly objecting to this patch. It's all over our codebase, and I like 
it. Literally everywhere you look.
If future patches need to add more under the branch, then it only needs 
to be done once.

Such fundamental changes need more than a single patch hastily accepted, 
and should involve the community as a whole, I believe.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".