From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.
Date: Wed, 2 Feb 2022 01:26:55 +0100
Message-ID: <65259fb0-1c02-2d1d-ca8c-ed55801f5181@rothenpieler.org> (raw)
In-Reply-To: <20220201215830.65635-2-markg85@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 660 bytes --]
On 01.02.2022 22:58, Mark Gaiser wrote:
> +static int translate_ipfs_to_http(URLContext *h, const char *uri, int flags, AVDictionary **options)
> +{
> + const char *ipfs_cid;
> + const char *protocol_path_suffix = "ipfs/";
> + char *fulluri;
> + int ret;
> + Context *c = h->priv_data;
> + int is_ipfs = (av_strstart(uri, "ipfs://", &ipfs_cid) || av_strstart(uri, "ipfs:", &ipfs_cid));
> + int is_ipns = (av_strstart(uri, "ipns://", &ipfs_cid) || av_strstart(uri, "ipns:", &ipfs_cid));
What's the point of this logic?
The first half of each check seems pointless, since the second half is
true for everything the first one would cover.
[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4494 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-02 0:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 21:58 [FFmpeg-devel] [PATCH v2 0/1] " Mark Gaiser
2022-02-01 21:58 ` [FFmpeg-devel] [PATCH v2 1/1] avformat: " Mark Gaiser
2022-02-02 0:26 ` Timo Rothenpieler [this message]
2022-02-02 0:33 ` Mark Gaiser
2022-02-02 0:34 ` Mark Gaiser
2022-02-02 0:39 ` Timo Rothenpieler
2022-02-02 0:44 ` Andreas Rheinhardt
2022-02-02 0:49 ` Timo Rothenpieler
2022-02-02 0:50 ` Mark Gaiser
2022-02-02 0:54 ` Timo Rothenpieler
2022-02-02 1:14 ` Mark Gaiser
2022-02-02 2:29 ` Lynne
2022-02-02 2:51 ` Mark Gaiser
2022-02-02 9:55 ` Lynne
2022-02-02 13:21 ` Tomas Härdin
2022-02-02 13:56 ` Mark Gaiser
2022-02-02 14:24 ` Timo Rothenpieler
2022-02-02 14:39 ` Mark Gaiser
2022-02-04 10:29 ` Tomas Härdin
2022-02-04 14:21 ` Mark Gaiser
2022-02-02 13:29 ` Michael Niedermayer
2022-02-02 14:23 ` Mark Gaiser
2022-02-03 14:54 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65259fb0-1c02-2d1d-ca8c-ed55801f5181@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git