[FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation

[FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation

[Mark Thompson]

---
Actually match the specification.  (Though I'm guessing this field isn't actually used if things pass anyway?)

 libavcodec/av1dec.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index 69da08b686..79a30a114d 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1dec.c
@@ -373,8 +373,13 @@ static void order_hint_info(AV1DecContext *s)
         int ref_order_hint = s->ref[ref_slot].order_hint;

         frame->order_hints[ref_name] = ref_order_hint;
-        frame->ref_frame_sign_bias[ref_name] =
-            get_relative_dist(seq, ref_order_hint, frame->order_hint);
+        if (!seq->enable_order_hint) {
+            frame->ref_frame_sign_bias[ref_name] = 0;
+        } else {
+            frame->ref_frame_sign_bias[ref_name] =
+                get_relative_dist(seq, ref_order_hint,
+                                  frame->order_hint) > 0;
+        }
     }
 }

-- 
2.43.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation

[Lynne]

Apr 22, 2024, 22:31 by sw@jkqxz.net:

> ---
> Actually match the specification.  (Though I'm guessing this field isn't actually used if things pass anyway?)
>
>  libavcodec/av1dec.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index 69da08b686..79a30a114d 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -373,8 +373,13 @@ static void order_hint_info(AV1DecContext *s)
>  int ref_order_hint = s->ref[ref_slot].order_hint;
>
>  frame->order_hints[ref_name] = ref_order_hint;
> -        frame->ref_frame_sign_bias[ref_name] =
> -            get_relative_dist(seq, ref_order_hint, frame->order_hint);
> +        if (!seq->enable_order_hint) {
> +            frame->ref_frame_sign_bias[ref_name] = 0;
> +        } else {
> +            frame->ref_frame_sign_bias[ref_name] =
> +                get_relative_dist(seq, ref_order_hint,
> +                                  frame->order_hint) > 0;
> +        }
>  }
>  }
>

LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation

[Mark Thompson]

On 22/04/2024 21:36, Lynne wrote:
> Apr 22, 2024, 22:31 by sw@jkqxz.net:
> 
>> ---
>> Actually match the specification.  (Though I'm guessing this field isn't actually used if things pass anyway?)
>>
>>  libavcodec/av1dec.c | 9 +++++++--
>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
>> index 69da08b686..79a30a114d 100644
>> --- a/libavcodec/av1dec.c
>> +++ b/libavcodec/av1dec.c
>> @@ -373,8 +373,13 @@ static void order_hint_info(AV1DecContext *s)
>>  int ref_order_hint = s->ref[ref_slot].order_hint;
>>
>>  frame->order_hints[ref_name] = ref_order_hint;
>> -        frame->ref_frame_sign_bias[ref_name] =
>> -            get_relative_dist(seq, ref_order_hint, frame->order_hint);
>> +        if (!seq->enable_order_hint) {
>> +            frame->ref_frame_sign_bias[ref_name] = 0;
>> +        } else {
>> +            frame->ref_frame_sign_bias[ref_name] =
>> +                get_relative_dist(seq, ref_order_hint,
>> +                                  frame->order_hint) > 0;
>> +        }
>>  }
>>  }
>>
> 
> LGTM

Applied, thank you.

- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".