From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0F5B44A19D for ; Mon, 22 Apr 2024 20:45:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F16BC68D367; Mon, 22 Apr 2024 23:45:08 +0300 (EEST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9664868D32A for ; Mon, 22 Apr 2024 23:45:02 +0300 (EEST) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-41a523e2888so10558215e9.1 for ; Mon, 22 Apr 2024 13:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1713818702; x=1714423502; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=femnKwKO4nPwnc05syARkIIEzU0I9As3+DLq3uN4eTY=; b=mV8qkNbuHRW1aD0HKbV851dDjIZQF7I98vcXp/qO6TyfBD2AUUiCmCCCTkTBUxnqGG EvYrF7H4P56p/lpugSsq9I8Bh9rnMRcpTciVD6YqtodyzRIRs2aArBCjy/UVACAGNyff 03j/1/5Sgz+vpIu8cu+FV/9NFhPNTHfnj13ogDF7UYqOigyI51Wg/zrDCBmG/noQ+Fpk VaCh//fbj1/UuUlmZl1ID+/nw/pjGsPEIaAxxqfeoftzrE/DxxpkCTk+3XfWaEp1L9hM 4vyhF0Q725efErRoQFpSSjmKhoS3LMRofWmU7ug3ymh6tpbdTW/Cxw4JO+i0xEAksSNA qgDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713818702; x=1714423502; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=femnKwKO4nPwnc05syARkIIEzU0I9As3+DLq3uN4eTY=; b=tMxHB4aLS8SiJ52wV4lqkfSLQxqnDNInamVLr+Qp6LnlAi1HQoipiERhtWQ01Nayy4 ymtvLdMjZIaugRj8xLSpHi+A4IPcbchdOpEsXcuCtnjQInHH5MJgL0ECEEWSXxbg/2Xt qD5JWJ1JRT/HKSoSwUsnR29BwX15eNjWJS9DYtUFi8466zMimUsDRlWTrDF9aQvSar89 P1We0k5r8n7JCoCfIKg+BcImsQes2t4f8BUTORyKhGq6dJxd40whrKT5yTCzzz2VY2l1 iVlfevRAKW/7m7jJeltnETyGeE6jifeggnv+HCvCF06m1YtVrO6p37Z1jaUHBTWm5viz JC3Q== X-Gm-Message-State: AOJu0YxhCQn4fWGk81f6jQyyjWIqIm2K2Q9dH+gMllsnt+LjKeQmk9s0 +UrRhrw8TTalimBtgzGpq8oYdHhxhHekyx3491m6tWF+GUSG4TTPsy94plI6dfK+232KFs3VJW5 n X-Google-Smtp-Source: AGHT+IHEtw0z4QkreBBQi2Zpkf3SoyLMRgrt50/wLmizE/WvaKMw5eWdtZEPhfTOwY+PlDvxzxtk5g== X-Received: by 2002:a05:600c:3baa:b0:416:88f9:f5ea with SMTP id n42-20020a05600c3baa00b0041688f9f5eamr8778691wms.34.1713818701789; Mon, 22 Apr 2024 13:45:01 -0700 (PDT) Received: from [192.168.0.15] (cpc92302-cmbg19-2-0-cust1183.5-4.cable.virginm.net. [82.1.212.160]) by smtp.gmail.com with ESMTPSA id t18-20020a05600c199200b00417ee784fcasm17818044wmq.45.2024.04.22.13.45.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 13:45:01 -0700 (PDT) Message-ID: <650dd790-e382-47d6-8767-dbce712d8186@jkqxz.net> Date: Mon, 22 Apr 2024 21:45:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <951824f2-abe7-4ed2-a2cf-12ecf67d27dd@jkqxz.net> From: Mark Thompson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 22/04/2024 21:36, Lynne wrote: > Apr 22, 2024, 22:31 by sw@jkqxz.net: > >> --- >> Actually match the specification. (Though I'm guessing this field isn't actually used if things pass anyway?) >> >> libavcodec/av1dec.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c >> index 69da08b686..79a30a114d 100644 >> --- a/libavcodec/av1dec.c >> +++ b/libavcodec/av1dec.c >> @@ -373,8 +373,13 @@ static void order_hint_info(AV1DecContext *s) >> int ref_order_hint = s->ref[ref_slot].order_hint; >> >> frame->order_hints[ref_name] = ref_order_hint; >> - frame->ref_frame_sign_bias[ref_name] = >> - get_relative_dist(seq, ref_order_hint, frame->order_hint); >> + if (!seq->enable_order_hint) { >> + frame->ref_frame_sign_bias[ref_name] = 0; >> + } else { >> + frame->ref_frame_sign_bias[ref_name] = >> + get_relative_dist(seq, ref_order_hint, >> + frame->order_hint) > 0; >> + } >> } >> } >> > > LGTM Applied, thank you. - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".