From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] Revert "avdevice/pulse_audio_dec: only set adjust latency flag if fragment_size is not set"
Date: Thu, 16 Jun 2022 21:37:48 +0200 (CEST)
Message-ID: <64e64526-2c38-191-ed3b-c392a26151c@passwd.hu> (raw)
In-Reply-To: <20220611181604.5297-1-cus@passwd.hu>
On Sat, 11 Jun 2022, Marton Balint wrote:
> This reverts commit 7f059a250bb7bcbf7bba537c1a059a5934413035.
>
> Apparently adjusting latency makes a difference even if fragment size is specifed.
>
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
> libavdevice/pulse_audio_dec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavdevice/pulse_audio_dec.c b/libavdevice/pulse_audio_dec.c
> index a33d1afd1f..ed094fd250 100644
> --- a/libavdevice/pulse_audio_dec.c
> +++ b/libavdevice/pulse_audio_dec.c
> @@ -220,7 +220,7 @@ static av_cold int pulse_read_header(AVFormatContext *s)
>
> ret = pa_stream_connect_record(pd->stream, device, &attr,
> PA_STREAM_INTERPOLATE_TIMING
> - | (pd->fragment_size == -1 ? PA_STREAM_ADJUST_LATENCY : 0)
> + |PA_STREAM_ADJUST_LATENCY
> |PA_STREAM_AUTO_TIMING_UPDATE);
Applied the series.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-06-16 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 18:16 Marton Balint
2022-06-11 18:16 ` [FFmpeg-devel] [PATCH 2/3] avdevice/pulse_audio_dec: reduce default fragment size Marton Balint
2022-06-11 18:16 ` [FFmpeg-devel] [PATCH 3/3] avdevice/pulse_audio_dec: deprecate frame_size option Marton Balint
2022-06-16 19:37 ` Marton Balint [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64e64526-2c38-191-ed3b-c392a26151c@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git