From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 839D04DC54 for ; Sat, 1 Mar 2025 23:07:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2947A68E237; Sun, 2 Mar 2025 01:07:53 +0200 (EET) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7890468E230 for ; Sun, 2 Mar 2025 01:07:47 +0200 (EET) Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-54298ec925bso4856533e87.3 for ; Sat, 01 Mar 2025 15:07:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1740870467; x=1741475267; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=vUQsrRvrks4qEC3Rh2elQZ3p7/wOL4Ayd9NgMCdREdQ=; b=HE5GSvUH8Q4skMk0s982Ovsc9vWlojYS7PbZHJ3JzrklCKFc61N1ypY9p8QXUEAkF+ vLUzeW7i/1XoOvaP5S1bkXGUe/iQSnqNSu1Zjwqxfm49mGAtGnRSBkjNIWV+NW6SkUOK CyI78rC8mYTNfdkwU+XUXErTVQS/oEmE6HvuU12ehsb4hqiXfP1I0o/Mbhtavr1WMqUs xKGUy38BUjrRrKMBgJZu81OIjzylo5xbIJ8/s6OKoCI1EbNIDUQKJT9Ze7JgvixwweOi e2SC4iBOuea3S/vSYuM2zqubx/KYaHsb2AIsCnCo2IlrEsPZRerW4yw8gH4PV6c0iyjB FYYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740870467; x=1741475267; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vUQsrRvrks4qEC3Rh2elQZ3p7/wOL4Ayd9NgMCdREdQ=; b=fgIfFzlezqmsxqcZ9dd7WrBNyLSJ3LhXqNN8fhXSCPwHtkCh+KkGnasb0MQnqTVMEM v8NzT79lIKF2UfTE/ZV6wytcUHGCuBajH4wvTPrplx3xoVvVBXxuwgGPv8rofP7Kf3L+ wT1rju+TIXDmHHaI5Z7DDzb/tqlsLXFDT8fREXuecwLB/k+NElE87IgaudXkujazw9yY bzURBPP5Q3ndvXeMw0ihtv4ewwtgW2glCJ/09wHAhidJJ59s0KgpAQQm7oRb83dVspPX rlrSaWnaE9muNWY+ajypwmuSTOTSYmNcn2u2dM2+TQofevda/R7t2CdA81YcECISbvtp +1pw== X-Gm-Message-State: AOJu0YwOkLTVzoKQklpAIFpHMLv4s9VcGtX3KrP3Fy7y0X0DTy4m++1h ZLDjIu13fwVPummHlckw+GhT2P4tig3zwq1E6PUTWshMIIskfFLdW8JMnx5Ykxhn01PZ1EVJlQR zEg== X-Gm-Gg: ASbGncs3FVBvwsLJoK6sZYAOGDv2xQ9icxE6530hZmgX3AFDfGCu280IzQCrW9u2Z8L Qgc8h3aDDfmRG+97+6LXTC59u+PYozG1pWRg2cG5gJIHwf7Jb3ADG0k0r8pLQ6S6pgQ3qRIHCrL BWs2EH9QgF8WiVPMrudBCx0ISjhA67OaJpJAR6q5907+lDNsNz09R2gB1LvilSKSE759s42tYZk g4n+DkWgeDkgBabtyoRxjrpr05r4rmIl8pCgufB7PjymH9zThOQTAvZzo2LDkCgbramILvhGndi n8V+9rjUp45T9TpWMadDLPgIzCdrfsyoimC7kKbzxNIT9TssIWKKV57mgt0i4h8XPD6qV9BuP0Q Vt7wXEK2ta2mTgCUHWfTFydoZlc7WzBXK93C7txmk X-Google-Smtp-Source: AGHT+IGgt4U1WoeShRpxNY9SMr0fNuYw2doHmiZrivLWtgqL70uTMXiwW7t6NgP2/FmQC3GaPWHPug== X-Received: by 2002:a05:6512:398e:b0:545:519:2d9e with SMTP id 2adb3069b0e04-5494c35462cmr2978759e87.47.1740870466585; Sat, 01 Mar 2025 15:07:46 -0800 (PST) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5495b826c13sm233023e87.239.2025.03.01.15.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Mar 2025 15:07:46 -0800 (PST) Date: Sun, 2 Mar 2025 01:07:45 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Krzysztof Pyrkosz via ffmpeg-devel In-Reply-To: <20250228212148.11560-4-ffmpeg@szaka.eu> Message-ID: <64b7d893-ff32-b52-763f-6ab24b9284e@martin.st> References: <20250228212148.11560-2-ffmpeg@szaka.eu> <20250228212148.11560-4-ffmpeg@szaka.eu> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/aarch64/ac3dsp_neon.S: Optimize ac3_sum_square_butterfly_int32_neon X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Krzysztof Pyrkosz Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 28 Feb 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: > Before and after: > > A78 > ac3_sum_square_bufferfly_int32_neon: 484.8 ( 2.00x) > ac3_sum_square_bufferfly_int32_neon: 468.2 ( 2.08x) > > A72 > ac3_sum_square_bufferfly_int32_neon: 793.6 ( 1.26x) > ac3_sum_square_bufferfly_int32_neon: 527.3 ( 1.92x) > --- > Instead of calculating a^2, b^2, (a+b)^2 and (a-b)^2, calculate only > a^2, b^2 and 2*a*b in each iteration and derive the latter parts from > these three at the end. This patch looks good to me, thanks! // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".