From: "Martin Storsjö" <martin@martin.st>
To: Krzysztof Pyrkosz via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Cc: Krzysztof Pyrkosz <ffmpeg@szaka.eu>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/aarch64/ac3dsp_neon.S: Optimize ac3_sum_square_butterfly_int32_neon
Date: Sun, 2 Mar 2025 01:07:45 +0200 (EET)
Message-ID: <64b7d893-ff32-b52-763f-6ab24b9284e@martin.st> (raw)
In-Reply-To: <20250228212148.11560-4-ffmpeg@szaka.eu>
On Fri, 28 Feb 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote:
> Before and after:
>
> A78
> ac3_sum_square_bufferfly_int32_neon: 484.8 ( 2.00x)
> ac3_sum_square_bufferfly_int32_neon: 468.2 ( 2.08x)
>
> A72
> ac3_sum_square_bufferfly_int32_neon: 793.6 ( 1.26x)
> ac3_sum_square_bufferfly_int32_neon: 527.3 ( 1.92x)
> ---
> Instead of calculating a^2, b^2, (a+b)^2 and (a-b)^2, calculate only
> a^2, b^2 and 2*a*b in each iteration and derive the latter parts from
> these three at the end.
This patch looks good to me, thanks!
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-01 23:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 21:21 [FFmpeg-devel] [PATCH 1/2] avcodec/aarch64/ac3dsp_neon.S: Optimize ac3_extract_exponents Krzysztof Pyrkosz via ffmpeg-devel
2025-02-28 21:21 ` [FFmpeg-devel] [PATCH 2/2] avcodec/aarch64/ac3dsp_neon.S: Optimize ac3_sum_square_butterfly_int32_neon Krzysztof Pyrkosz via ffmpeg-devel
2025-03-01 23:07 ` Martin Storsjö [this message]
2025-03-01 22:59 ` [FFmpeg-devel] [PATCH 1/2] avcodec/aarch64/ac3dsp_neon.S: Optimize ac3_extract_exponents Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64b7d893-ff32-b52-763f-6ab24b9284e@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=ffmpeg@szaka.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git