From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 618B146AB2 for ; Tue, 16 Sep 2025 14:30:59 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'Iu6Etd4DEQ5q9q5BejYg52hG0CD6fQctVWkPCfEp6mg=', expected b'HOpCXxqbF28N3NW1sbiBCOjcE20RSv6mxQYyxJoVgOs=')) header.d=juvoly.nl header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1758033049; h=message-id : date : mime-version : to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=hnUWMrj+3dmhAnQMEl2bZMoRgKHCeomEeZ08J+l4o+Y=; b=aj+P6Ys4pG7yAPVbOc5k1xPN/rqwjJSpycaYJZtij5ScoxIj3c13PlpS31fJcP4wsOSSy G2SpJIpZOxLJbql50zHIsE4itzUS5DVSu7WdF1Fs4A7CPvKOxVRsnBf3jbTg0c5NY6/eQ6n Lc7/oIxegodjbyL8x84cBNgeO1ZM8adzJAdub7xrWja1KoZKUFRdc6ehAnyu9JYJEGEXBGq iE4AHrfGg1xNO98yC3RnnAMfR2YW6WsiPYyiexHtXHGK3ZU97UzA1Ry1iuu0szr+vtV5oFM 4WDRAEHYKB2D7+9q1Gg4S3p1nmXfRkv1Ws6kR22GlupuyLSR+tWYFof7AsNA== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7473368E994; Tue, 16 Sep 2025 17:30:49 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1758033048; b=aPXqSIzDPcc5a00AYDTR8Q1r1XoqQysmpss6VGxIHlvqWOI9R1rNnW36BLy7/H72E+kA6 KFkT1FUvnN4vPTpu4wx2goGe9RSq8KNW3EdY5zdeqdgvEPQhcgtjB2WIW29pP5zSQSGb8D3 JfiDOldtBtfrrNubvstqOuAkL4tiofZsuhNYQ1lDiyTIWWwbOPaWmVGUm39RFHXEcjvphkh UZTFzJ2cIoxJMXUtSbbp1f6hzoNbnKK1NxFEGYjlZoUC49SWOcMh2OYWpf7thThl9NJUhLR btnmftt4gtDYJFfkm0FqePz7jvqmGUXnrJp5TzYMWlAycQujan2PoCnhjzWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1758033048; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=Iu6Etd4DEQ5q9q5BejYg52hG0CD6fQctVWkPCfEp6mg=; b=ZLtlqvukLx2ZEZv9OvG9t9FJWGm22vD1n2l0iuP9ehiWWXjiJ0w03W/5ZaO9guDt7t2/d VqIYH7/gTxtxlNhKQrpadcMHd8Lk7mBvY/WZhE3TSxBKyT6DNc2CbJjWOVJ5/x3t2dx4KCM JhuSeQ2Qq2BPo0T+v0ugdvuotzH7tKLl9Vm8UHJn6Hlnq3xOWW69fqHYXCHtCLpSBzWlMQ1 fPRNIaZOshG5otdOo1ERCqaSU3HGMqRFYSwSfszBglpR5xq++rYR/Qhjy4DxIwPXFo1wAxh dMu+TCDyD7TbBac+k2wzWJ3wQ1kW6a35+FBSeoQ/nFS3Bxp5gExI+b/p6eiA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=juvoly.nl; arc=none; dmarc=pass header.from=juvoly.nl policy.dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=juvoly.nl; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=juvoly.nl policy.dmarc=none Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id C9FDD6801FE for ; Tue, 16 Sep 2025 17:30:33 +0300 (EEST) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-62f24b7be4fso2228524a12.0 for ; Tue, 16 Sep 2025 07:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juvoly.nl; s=google; t=1758033033; x=1758637833; darn=ffmpeg.org; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=HOpCXxqbF28N3NW1sbiBCOjcE20RSv6mxQYyxJoVgOs=; b=Yb8OfIE455spagqQOCbdbqV9c9dAwdX7hTBmHjEMlgQfj7MT/tQI8CPDbz4jvLvL4U B5tki6A+aR0sxrVuLuAjL0JqcwWHS0sbEoOUcliZoQqz7Se5NxvMz78SiH33dIFtuhE3 Ktgc43YzRz1sOHHmuNhGzGU9tHnkfAO97NdBccEQw9LOGjTudYlL3/5TNM0n6dhundPc nlTWeCJI4BhfRsfYWZQV8EySR2UJnWGS4OXfQ6yrR/s1BONRJuSATyARbi4gWrudPwKC KS+K9SzvK0yF2IpKrkfww1GMhioAyuy6wc/bhFgBkWdKSNqXVcPGfeQ9Si7AStOCyk1K IEoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758033033; x=1758637833; h=content-transfer-encoding:content-language:to:subject:from :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HOpCXxqbF28N3NW1sbiBCOjcE20RSv6mxQYyxJoVgOs=; b=EPvFeUUWTvjUAov1KdTgxfJWAvWT/XKK88xgIqv+3Gsm0WiM1FNXOYVQG78CWQniqT JRPsDy82gBd52fKT6BCsajHFY/CIiOPXC7Qnfxzolpsu1Uisum+6uGXtwor/P1Klti1u +6m11y5wcqYSf8Kr/LG/zCqCTVL2pAGl1jET6fAsh5R2no/CRcMdf4g7idh/Ykcv2O0T +TKNeoG1nyWeqh6F4wXT6QdrlmFnRBIi4abD1A4OpWtmTlgOD0mdcFfF8B8kF5QGu1Ho 0qQt9sPDnNwMU7BnrNo3DdZzT70X3/jzeZ+oPd9Niq45T0GhiaPwLlzEZnBeblq1X3zX kw2g== X-Gm-Message-State: AOJu0Yzhhx3jnVEpeZN09s7Uignosl1H9tZrgJ0Hg8Rc3ltS+tkYTXyg 6SMRwO4//xPxqaoPmFVa6PqLwHGSkwDOb5NGk/3avdVaTK2fu5uK1q757fnwiV2aDuxEeROLcKU VWn2s X-Gm-Gg: ASbGncvqZNRBz3cA6haGVAA+2ipxaJScVCu/YAteZSjiuiiqHWoAqttvLYVgXF/A2dq PvcVnUE+UopiL2Msaak6xMRSZcnFRCtspDugMB9IQ8am3O8j4tMkP3/nRqLbEHbdKpYH9/ib2n+ B0Eyi6pLn9sGeJWhrnLulS6oxm3qY+BivCUZk9woVxKgQOSeeFUKB4Xdg5WJwxwxHZfNhBU0P/u KQw9maax4S7RJCjj2Af6FqCh3GC3UDlBa/YcguQAegspMaeWQmAxqV76IHKMnipjBJNIOfbiDA5 Xwnf8/cGkpRVakuPITEMSheino+KtmNqFf492GqDVjSQfXx/zO6E481hrLQEPoI8p5Hv1NRgUZr yy8xD2RkeAnltnTX14UK3ZNBR X-Google-Smtp-Source: AGHT+IFaTEsdfYM2XkZ1B/wbBfmgVmEx23xa1GXWDbu8X2xvNw5YfwC8+VX1ZYX9zyUQf+ud1NLZNQ== X-Received: by 2002:a05:6402:27cb:b0:62f:259f:af29 with SMTP id 4fb4d7f45d1cf-62f259fb1b1mr10139454a12.27.1758033032947; Tue, 16 Sep 2025 07:30:32 -0700 (PDT) Received: from [145.107.187.181] ([145.107.187.181]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62edbc829b3sm9799276a12.28.2025.09.16.07.30.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Sep 2025 07:30:32 -0700 (PDT) Message-ID: <64a382b8-c394-4778-a524-437e79db295e@juvoly.nl> Date: Tue, 16 Sep 2025 16:30:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org Content-Language: en-US Message-ID-Hash: GUFBI2EMUPE3SD6HCM6F34P6YHVYYV3C X-Message-ID-Hash: GUFBI2EMUPE3SD6HCM6F34P6YHVYYV3C X-MailFrom: SRS0=7Ks1=33=juvoly.nl=tijn@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avformat/mov.c: prevent unbounded read from pipe when 'mdat' precedes 'moov' List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Tijn Porcelijn via ffmpeg-devel Cc: Tijn Porcelijn Content-Type: text/plain; charset="us-ascii"; format="flowed" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: When mp4/mov media packaged without faststart/empty_moov is ingested through pipe, the process stalls indefinitely or until buffers deplete memory. This aborts the ingest immediately unless we read from seekable input or the mdat is very small. Signed-off-by: Tijn Porcelijn --- libavformat/mov.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 216c6a5442..34991fec81 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1371,6 +1371,11 @@ static int mov_read_mdat(MOVContext *c, AVIOContext *pb, MOVAtom atom) { if (atom.size == 0) /* wrong one (MP4) */ return 0; + if (!(c->found_moov) && !pb->seekable && atom.size > (pb->buf_end - pb->buf_ptr)) + { + av_log(c->fc, AV_LOG_ERROR, "'mdat' must not precede 'moov' when streaming\n"); + return -1; + } c->found_mdat=1; return 0; /* now go for moov */ } -- 2.34.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org