Re: [FFmpeg-devel] [PATCH 2/2] lavf/oggdec: fix demux with unrecognized header packets

From: James Almer <jamrial@gmail.com>
To: rcombs <rcombs@rcombs.me>, ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavf/oggdec: fix demux with unrecognized header packets
Date: Tue, 28 Mar 2023 17:44:38 -0300
Message-ID: <649323bc-28c1-c934-1f3b-d41761c24f88@gmail.com> (raw)
In-Reply-To: <20230328203226.34753-2-rcombs@rcombs.me>

On 3/28/2023 5:32 PM, rcombs wrote:
> Fixes ticket #10289.
> 
> Co-authored-by: James Almer <jamrial@gmail.com>
> ---
>   libavformat/oggparsevorbis.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c
> index 061840c2ed..4f48ebabc0 100644
> --- a/libavformat/oggparsevorbis.c
> +++ b/libavformat/oggparsevorbis.c
> @@ -311,7 +311,12 @@ static int vorbis_header(AVFormatContext *s, int idx)
>       if (!(pkt_type & 1))
>           return priv->vp ? 0 : AVERROR_INVALIDDATA;
>   
> -    if (os->psize < 1 || pkt_type > 5)
> +    if (pkt_type > 5) {
> +        av_log(s, AV_LOG_VERBOSE, "Ignoring packet with unknown type %i\n", pkt_type);

nit: we normally use %d for ints.

> +        return 1;
> +    }
> +
> +    if (os->psize < 1)
>           return AVERROR_INVALIDDATA;
>   
>       if (priv->packet[pkt_type >> 1])

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".