From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 536BC428D4 for ; Sun, 9 Jan 2022 18:32:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7F00E68AB67; Sun, 9 Jan 2022 20:32:18 +0200 (EET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C707E68A68F for ; Sun, 9 Jan 2022 20:32:12 +0200 (EET) Received: by mail-wr1-f68.google.com with SMTP id o3so22596944wrh.10 for ; Sun, 09 Jan 2022 10:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=OvFjVTxiPTyKEDt9rC0KdtgRihcvm//952dw9AV5YrQ=; b=ODd4z1aWIIXfAycBpk5IiQpZQooqQy+gieLY/FOoctZLH7/pLDCZj+rhmQFhALlOO7 aAl4603addRekYa+e2eM9/JxS2z8ELEgu45YrMXQcqDWYWIpU0NLg1EolzeHgyej5SJI iFIJeREbLrWsajss+BlYXku2NiJ17Glf+Q6usmC4QZG//ToXoW6vWT0yJUwtX8C02bUC uIDVJqdcB6x/Gk6VofbVap0dSKJgySqZ7vwwGSAFXVMdsN70mdKNZ22mbNX6eNsuje99 xS+9qwGnPrVECS8uI+mXEq3UV00OBImSajl5dsyxWbtBNSSSuK3yxmQCzyckyBoVklAc GTiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=OvFjVTxiPTyKEDt9rC0KdtgRihcvm//952dw9AV5YrQ=; b=OqiRjM5/HeuVFY1OLlssERXt8kTK5zF+E/Zn9bjQsvIVXmQK+hKxh8uwac0nmNHNxS Zb1h+NiVDkFWwqpP1ea9CTazEjDCILJPe+y7MHZ7KzoZhmlepEnUrWJn8fayefvR86+k EOMrVJFmfAHYUnJZTpcMwmc2AQN+MVZ9mKNzJ1RZPe416/eSxEfsf+2saSJylI8nSCty cOeXMVs2yAWY+bpPsPGqFvH0rdcbpjXbmpzPE7qPIc8HWE7tV/l8TwEs6iCNVVf5ss3Y bLouRSXbnqUUjRU/RE+t3sbEBR/tW97XUIZvdxAzFmpPI4v/uCAbXATeRB8Ytb/AYtKq SgBQ== X-Gm-Message-State: AOAM531kRXZyn4fwNOgleh8SaBZdeELA3nFhZrrPedd0pqvX/W5c7AU4 BqDH7s37LPjymSRExDxPNTS4jmq6uVIUHa6X X-Google-Smtp-Source: ABdhPJw6O5bL5hZnaNVUePxdExHPDgazoamnZy/B2zCP8rl1vYMDvl9lGIsacjhoaADlJ/TkyEt7qA== X-Received: by 2002:adf:d1c2:: with SMTP id b2mr65745206wrd.339.1641753131977; Sun, 09 Jan 2022 10:32:11 -0800 (PST) Received: from [192.168.0.11] (cpc91222-cmbg18-2-0-cust46.5-4.cable.virginm.net. [81.106.30.47]) by smtp.gmail.com with ESMTPSA id t15sm4758797wrz.82.2022.01.09.10.32.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Jan 2022 10:32:11 -0800 (PST) Message-ID: <6427bb4e-b4a0-7cf2-aa7d-829115b166f2@jkqxz.net> Date: Sun, 9 Jan 2022 18:32:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: FFmpeg development discussions and patches References: <1568794798-6615-1-git-send-email-linjie.fu@intel.com> From: Mark Thompson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH, v2] lavf/vf_deinterlace_vaapi: flush queued frame for field in DeinterlacingBob X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 29/12/2021 03:45, Xiang, Haihao wrote: >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of Linjie >> Fu >> Sent: Wednesday, September 18, 2019 16:20 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Fu, Linjie >> Subject: [FFmpeg-devel] [PATCH, v2] lavf/vf_deinterlace_vaapi: flush queued >> frame for field in DeinterlacingBob >> >> For DeinterlacingBob mode with rate=field, the frame number of output >> should equal 2x input total since only intra deinterlace is used. >> >> Currently for "backward_ref = 0, rate = field", extra_delay is >> introduced. Due to the async without flush, frame number of output is >> [expected_number - 2]. >> >> Specifically, if the input only has 1 frame, the output will be empty. >> >> Add deint_vaapi_request_frame for deinterlace_vaapi, send NULL frame >> to flush the queued frame. >> >> For 1 frame input in Bob mode with rate=field, >> before patch: 0 frame; >> after patch: 2 frames; >> >> ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 >> -hwaccel_output_format vaapi -i input.h264 -an -vf >> deinterlace_vaapi=mode=bob:rate=field -f null - > > Sorry for picking up the old thread. > > Hi Mark, > > Is your issue mentioned in http://ffmpeg.org/pipermail/ffmpeg-devel/2019-September/250080.html > fixed by this patch version ? I'd like to apply this patch if it may work for you. Yep, it now gives the expected number of frames and I do not have any segfaults. I tested drivers with { forward = 0, backward = 0 } (iHD), { forward = 1, backward = 0 } (i965) and { forward = 2, backward = 1 } (gallium). Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".