From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A4BA147A70 for ; Sat, 30 Dec 2023 16:00:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5891268CBF5; Sat, 30 Dec 2023 18:00:25 +0200 (EET) Received: from glom.nmugroup.com (glom.nmugroup.com [193.183.80.6]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0560368C48A for ; Sat, 30 Dec 2023 18:00:18 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by glom.nmugroup.com (Postfix) with ESMTP id 0139D54252D7 for ; Sat, 30 Dec 2023 17:00:18 +0100 (CET) Received: from debian.lan (unknown [IPv6:2a00:66c0:a::72c]) (Authenticated sender: git01) by glom.nmugroup.com (Postfix) with ESMTPSA id B387654252BF for ; Sat, 30 Dec 2023 17:00:17 +0100 (CET) Message-ID: <64176ce8ad299467e573e8e049c0979fed33b587.camel@haerdin.se> From: Tomas =?ISO-8859-1?Q?H=E4rdin?= To: FFmpeg development discussions and patches Date: Sat, 30 Dec 2023 17:00:16 +0100 In-Reply-To: <20231228233040.GB6420@pb2> References: <20231228202900.GY6420@pb2> <5b7a1751e643ed9032ca380bd1a4d882592c8c09.camel@haerdin.se> <20231228233040.GB6420@pb2> Content-Type: multipart/mixed; boundary="=-1xEnWoT0talmSdTVn7VT" User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/6] lavc/codec2utils: Use actual libcodec2 version X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --=-1xEnWoT0talmSdTVn7VT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable fre 2023-12-29 klockan 00:30 +0100 skrev Michael Niedermayer: > On Thu, Dec 28, 2023 at 10:21:23PM +0100, Tomas H=C3=A4rdin wrote: > > tor 2023-12-28 klockan 21:29 +0100 skrev Michael Niedermayer: > > > On Thu, Dec 28, 2023 at 07:43:09PM +0100, Tomas H=C3=A4rdin wrote: > > > > libcodec2 has reached 1.X so it's about time the bindings > > > > receive > > > > some > > > > attention. This patchset also includes some much-needed tests. > > > > Where do > > > > I submit files for inclusion in FATE again? They are very small > > > > as > > > > is > > > > to be expected from a codec that runs at 700-3200 bit/s > > > >=20 > > > > /Tomas > > >=20 > > > > =C2=A0codec2utils.h |=C2=A0=C2=A0=C2=A0 6 +++--- > > > > =C2=A01 file changed, 3 insertions(+), 3 deletions(-) > > > > a79a98f8ffc27ca6d79c9d373957fa0bdc985ef2=C2=A0 0001-lavc- > > > > codec2utils- > > > > Use-actual-libcodec2-version.patch > > > > From 7205e741aaadc354b403010c97f9cd803eec612d Mon Sep 17 > > > > 00:00:00 > > > > 2001 > > > > From: =3D?UTF-8?q?Tomas=3D20H=3DC3=3DA4rdin?=3D > > > > Date: Wed, 27 Dec 2023 17:32:21 +0100 > > > > Subject: [PATCH 1/6] lavc/codec2utils: Use actual libcodec2 > > > > version > > >=20 > > > This breaks build here > > >=20 > > > CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0libavformat/codec2.o > > > In file included from libavformat/codec2.c:24:0: > > > ./libavcodec/codec2utils.h:26:10: fatal error: codec2/version.h: > > > No > > > such file or directory > > > =C2=A0#include > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~~~= ~~~~ > >=20 > > What version of libcodec2 are you using? I don't think we can rely > > on > > versions that don't expose version information, which only comes > > about > > because I explicitly told them to please expose it in a header. I > > don't > > think we can even probe version at configure time otherwise. > >=20 > > libcodec2-dev on Debian bookworm works for me >=20 > i think theres no libcodec2* on the box and this header is used > outside > checks for libcodec2* ... Updated patch attached /Tomas --=-1xEnWoT0talmSdTVn7VT Content-Disposition: attachment; filename="0001-lavc-codec2utils-Use-actual-libcodec2-version.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-lavc-codec2utils-Use-actual-libcodec2-version.patch"; charset="UTF-8" RnJvbSAwOThhM2I3ZTc4ZGMwYjFiYmRmY2UwNTFkZTIxNTI2ZjBhODg2YjRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/VG9tYXM9MjBIPUMzPUE0cmRpbj89IDxnaXRA aGFlcmRpbi5zZT4KRGF0ZTogV2VkLCAyNyBEZWMgMjAyMyAxNzozMjoyMSArMDEwMApTdWJqZWN0 OiBbUEFUQ0ggMS83XSBsYXZjL2NvZGVjMnV0aWxzOiBVc2UgYWN0dWFsIGxpYmNvZGVjMiB2ZXJz aW9uCgotLS0KIGxpYmF2Y29kZWMvY29kZWMydXRpbHMuaCB8IDE3ICsrKysrKysrKysrKysrLS0t CiAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9saWJhdmNvZGVjL2NvZGVjMnV0aWxzLmggYi9saWJhdmNvZGVjL2NvZGVjMnV0aWxz LmgKaW5kZXggNjgxMmFlODk1Yy4uZTEzMTRiMDViNiAxMDA2NDQKLS0tIGEvbGliYXZjb2RlYy9j b2RlYzJ1dGlscy5oCisrKyBiL2xpYmF2Y29kZWMvY29kZWMydXRpbHMuaApAQCAtMjMsNiArMjMs MTAgQEAKICNkZWZpbmUgQVZDT0RFQ19DT0RFQzJVVElMU19ICiAKICNpbmNsdWRlIDxzdGRpbnQu aD4KKyNpbmNsdWRlICJjb25maWcuaCIKKyNpZiBDT05GSUdfTElCQ09ERUMyCisjaW5jbHVkZSA8 Y29kZWMyL3ZlcnNpb24uaD4KKyNlbmRpZgogCiAvL0hpZ2hlc3QgbW9kZSB3ZSdyZSB3aWxsaW5n IHRvIHVzZS4KIC8vRG9uJ3Qgd2FudCB0byBsZXQgdXNlcnMgYWNjaWRlbnRhbGx5IHByb2R1Y2Ug ZmlsZXMgdGhhdCBjYW4ndCBiZSBkZWNvZGVkIGluIHRoZSBmdXR1cmUuCkBAIC00OSw5ICs1Mywx NiBAQAogCiAvL1VzZWQgaW4gY29kZWMycmF3IGRlbXV4ZXIgYW5kIGxpYmNvZGVjMiBlbmNvZGVy CiBzdGF0aWMgaW5saW5lIHZvaWQgY29kZWMyX21ha2VfZXh0cmFkYXRhKHVpbnQ4X3QgKnB0ciwg aW50IG1vZGUpIHsKLSAgICAvL3ZlcnNpb24gMC44IGFzIG9mIDIwMTctMTItMjMgKHIzMzg2KQot ICAgIHB0clswXSA9IDA7ICAgICAvL21ham9yCi0gICAgcHRyWzFdID0gODsgICAgIC8vbWlub3IK KyNpZiBDT05GSUdfTElCQ09ERUMyCisgICAgcHRyWzBdID0gQ09ERUMyX1ZFUlNJT05fTUFKT1I7 CisgICAgcHRyWzFdID0gQ09ERUMyX1ZFUlNJT05fTUlOT1I7CisjZWxzZQorICAgIC8vIHRoaXMg Y29kZXBhdGggaXMgb25seSBoaXQgd2hlbiBkZW11eGluZyByYXcgY29kZWMyIHdpdGggbGliY29k ZWMyIGRpc2FibGVkLAorICAgIC8vIGFuZCBvbmx5IHJlbGV2YW50IHdoZW4gcmVtdXhpbmcgZnJv bSByYXcgY29kZWMyIHRvIC5jMiwKKyAgICAvLyBiZWNhdXNlIHZlcnNpb24gaW5mb3JtYXRpb24g aXMgaWdub3JlZCBleGNlcHQgd2hlbiB3cml0aW5nIHRoZSAuYzIgaGVhZGVyCisgICAgcHRyWzBd ID0gMTsgICAgIC8vIHZlcnNpb24gMS4yLjAgaXMgdGhlIGxhdGVzdCB3ZSBrbm93IG9mCisgICAg cHRyWzFdID0gMjsKKyNlbmRpZgogICAgIHB0clsyXSA9IG1vZGU7ICAvL21vZGUKICAgICBwdHJb M10gPSAwOyAgICAgLy9mbGFncwogfQotLSAKMi4zOS4yCgo= --=-1xEnWoT0talmSdTVn7VT Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --=-1xEnWoT0talmSdTVn7VT--