From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9F986473E1 for ; Sat, 7 Oct 2023 04:52:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5567D68CA01; Sat, 7 Oct 2023 07:52:16 +0300 (EEST) Received: from 11.mo550.mail-out.ovh.net (11.mo550.mail-out.ovh.net [188.165.48.29]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 790DF68C901 for ; Sat, 7 Oct 2023 07:52:09 +0300 (EEST) Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.138.131]) by mo550.mail-out.ovh.net (Postfix) with ESMTP id 670982AC5F for ; Sat, 7 Oct 2023 04:52:08 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-xwt9l (unknown [10.109.138.115]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id F04671FDDC for ; Sat, 7 Oct 2023 04:52:07 +0000 (UTC) Received: from mediaarea.net ([37.59.142.101]) by ghost-submission-6684bf9d7b-xwt9l with ESMTPSA id UUWRNffjIGVMogAADWeXJw (envelope-from ) for ; Sat, 07 Oct 2023 04:52:07 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-101G0046ad3010a-dcc2-4966-9d5e-346cf33a5c2b, FC3F19BF5293790492AA26F1019793C489841EEE) smtp.auth=jerome@mediaarea.net X-OVh-ClientIp: 84.143.151.101 Message-ID: <63f89695-1a25-41fa-900d-650e4da6f43f@mediaarea.net> Date: Sat, 7 Oct 2023 06:52:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US, fr, de-DE References: <20231007001444.31861-1-michael@niedermayer.cc> <20231007001444.31861-3-michael@niedermayer.cc> From: Jerome Martinez To: FFmpeg development discussions and patches In-Reply-To: <20231007001444.31861-3-michael@niedermayer.cc> X-Ovh-Tracer-Id: 16426879641245812985 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrgeekgdefjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtkfffgggfufhfhffvjgesrgdtreertddvjeenucfhrhhomheplfgvrhhomhgvucforghrthhinhgviicuoehjvghrohhmvgesmhgvughirggrrhgvrgdrnhgvtheqnecuggftrfgrthhtvghrnhephfefgedtueefudeuteeiteffteevveefleeuhfeuheffjeevgedvkeejudfhjedunecukfhppeduvdejrddtrddtrddupdekgedrudegfedrudehuddruddtuddpfeejrdehledrudegvddruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehjvghrohhmvgesmhgvughirggrrhgvrgdrnhgvtheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrghdpoffvtefjohhsthepmhhoheehtddpmhhouggvpehsmhhtphhouhht X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 3/3] [RFC] avcodec/ffv1: Better rounding for slice positions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 07/10/2023 02:14, Michael Niedermayer wrote: > This fixes green lines in some odd dimensions with some slice configurations > like Ticket 5548 > > This also changes the encoder and whats encoded, and would require an > update to the specification. This change attempts to limit the change > to configurations that have missing lines currently. It changes a lot the count of pixels per slice, and , e.g. with 4:2:2 and 4 slices per direction (16 slices in total), 13 pixel width: before: 3/3/3/4 for luma, 2/2/2/2 for chroma (so 1 chroma too much) after: 4/4/2/3 for luma, 2/2/1/2 for chroma Wouldn't it easier for spec and maths to keep the previous behavior for luma and consider extra chroma as to be not encoded? Something like 3/3/3/4 for luma, 2/2/2/1 for chroma Actually maybe not really a change for spec in that case, more making a part more explicit while considering the patch as a bug fix rather than a spec change. Or did I miss another issue? I'll check more a bit later. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".