From: Jerome Martinez <jerome@mediaarea.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] [RFC] avcodec/ffv1: Better rounding for slice positions
Date: Sat, 7 Oct 2023 06:52:07 +0200
Message-ID: <63f89695-1a25-41fa-900d-650e4da6f43f@mediaarea.net> (raw)
In-Reply-To: <20231007001444.31861-3-michael@niedermayer.cc>
On 07/10/2023 02:14, Michael Niedermayer wrote:
> This fixes green lines in some odd dimensions with some slice configurations
> like Ticket 5548
>
> This also changes the encoder and whats encoded, and would require an
> update to the specification. This change attempts to limit the change
> to configurations that have missing lines currently.
It changes a lot the count of pixels per slice, and , e.g. with 4:2:2 and 4 slices per direction (16 slices in total), 13 pixel width:
before: 3/3/3/4 for luma, 2/2/2/2 for chroma (so 1 chroma too much)
after: 4/4/2/3 for luma, 2/2/1/2 for chroma
Wouldn't it easier for spec and maths to keep the previous behavior for luma and consider extra chroma as to be not encoded?
Something like 3/3/3/4 for luma, 2/2/2/1 for chroma
Actually maybe not really a change for spec in that case, more making a part more explicit while considering the patch as a bug fix rather than a spec change.
Or did I miss another issue? I'll check more a bit later.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-07 4:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 0:14 [FFmpeg-devel] [PATCH 1/3] avcodec/ffv1enc: Slice combination is unsupported Michael Niedermayer
2023-10-07 0:14 ` [FFmpeg-devel] [PATCH 2/3] avcodec/ffv1: Store and reuse sx/sy Michael Niedermayer
2023-10-07 0:14 ` [FFmpeg-devel] [PATCH 3/3] [RFC] avcodec/ffv1: Better rounding for slice positions Michael Niedermayer
2023-10-07 4:52 ` Jerome Martinez [this message]
2023-10-07 17:11 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f89695-1a25-41fa-900d-650e4da6f43f@mediaarea.net \
--to=jerome@mediaarea.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git