From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3A4894418E for ; Tue, 3 Jan 2023 01:08:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8F1F868BCCE; Tue, 3 Jan 2023 03:08:53 +0200 (EET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0FA4368B9F2 for ; Tue, 3 Jan 2023 03:08:45 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672708130; x=1704244130; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=uG5ckZmYDrViWFtO6MTZiFeShIfGruLGL8llzj4TsDg=; b=IbxGyw+mwrVAQ7CgTbLJTgzEbjhMWW8qE1RjgOmX9ZHGpEHvQGQRr4LJ LGpTJ25YJyHj5bejHc+bMxFuRxLMdvMSQ7AHsI5B+Wvyynrll+q2Y/EY+ QF4sCpVpmrG7odzzus5K0+DeWHxE+GAPZODTec2hsr+YutUroTY1DjJpw OuazEr/u4B/QADEnqKCKcRjef1Sk7UbSyYTNsof1044ODYMw6Mj6eG4nZ CnTMMJH4A2ghhjf5EUl1LVWf2MTQbltPVnQh5ANNR5yvGT0D0CfAblpfF r0PS4B+IU5AwfUA36ypSZP8vTZOlhGntHkF6kR2I+kAr4ov/qeV5WhQ+W g==; X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="383858243" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="383858243" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2023 17:08:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10578"; a="778688739" X-IronPort-AV: E=Sophos;i="5.96,295,1665471600"; d="scan'208";a="778688739" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 02 Jan 2023 17:08:42 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 2 Jan 2023 17:08:42 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 2 Jan 2023 17:08:42 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 2 Jan 2023 17:08:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hGU0HTPZ0C5o8m3HEW6yfIN00OwzlrY2BO12kV9+B2fzUgalVJZHKZ7Bpf+asdEinMPzTqpwemXvV20rJClqFwmI0ug0aAwQwtPQ4ilwRLNokMxH6RTUlnP3EbKYn3jujUzurgOXurPkKO1MKri4BGtMjzanip2bgqOdWrR++BwKuTdktUEdwt8cmROcipk3rdQd8Mcdi0eY92e1iIv5qOKwqhSht/dvjU40rlC0IQLXFMNbpk7eDbzY/6iEYogy0HZ8vQd8aCoKRsCtiMkLMv3NyP90CjeIyGO2kX66qjAnham4sodqFj8+wpcEyOqmt2gVR4RGgK3iqoTkXpokyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uG5ckZmYDrViWFtO6MTZiFeShIfGruLGL8llzj4TsDg=; b=DQ0J3itgySU02fTrM3tBgvnql34sy+E9NVwmdIbP8oql7Lp2E2ZGbZLxGttRm3bguuqB6XW0XquJFk9ay2kZCZW2FgANXKI8eUH1/6A0DbejdSXles75rBry/kgshLyGubm1BiK00hpHQ1O70IDDHw1VqaX1twPFsuKSo93CEUnhu9SVqNLgLiMsjf1gKV0j3wBAEHYJMn9yNxhxVV9eNgnMfa+CWkF6dQl1i85/zSzfWLCY2Jh+0cSdM/1sFPFS4FvCJh9B50sl8Q5YdFIW24dS0lDHmO4dfSbVCxGRKv6GURNn3BJqBR3UBv5Xg2D8Jm+M66ecsNc9lVBmasJ3Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DS0PR11MB8183.namprd11.prod.outlook.com (2603:10b6:8:161::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Tue, 3 Jan 2023 01:08:35 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9%5]) with mapi id 15.20.5944.019; Tue, 3 Jan 2023 01:08:35 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc_av1: Add low_delay_brc support to av1_qsv encoder Thread-Index: AQHZGO+myOf7571kwUai5T2r0rLoG66L7eyA Date: Tue, 3 Jan 2023 01:08:35 +0000 Message-ID: <633978127738c5f32914abb6c482cb3ee14f73bb.camel@intel.com> References: <20221226060201.2081722-1-wenbin.chen@intel.com> In-Reply-To: <20221226060201.2081722-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|DS0PR11MB8183:EE_ x-ms-office365-filtering-correlation-id: 05c92e79-f901-4142-841f-08daed270a0c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kGuGshwO/JxvpfFpNuX8/vKqNPmbYtUs6BJstaOiIv+16zXQhbk5ffaquriIH9PIb9R7FGiUUhMe/WkAf8LdKhyWEhEzqlOipxNPTWCAyVFlzsxJM0sGCoqLlhc35Oqox+o1Us7ikOZOPBYamTdG98ed3cz8yeD5eBef/bJvyeMbccE9FdNVwCkodcgqxgv9lMmTHtRiO3nRUIsO4XNtfScYPU1h5xo+LWrgwll0bCf5LZNIRaki0btUY1/uCaCCOks5LrGUTufib4EW90d8HS27AGvGYzwziqHR83gTxyolAkq9xhYxnzpZxwSHZmG1kbHZxER5Wpipvi1dyz/5AbFBxbtBl22V4q//5fKk6XDSN7HfxCu50sM8+it3p6wdMPsQjJ4Zm1IBt8mB2P/lBlFY39SMGsiZwpDPHtRl6tGZUTRzt4y7MxnvbGQ4fo+Uxbz+p6gZXTSaD9I+Wa6wH2pzMky5xd3YW9Kz5L6q9JQct0VPXzJwL9d56nPtasUrw6YrueHkqEbJfgeQCJths89kbF6vKspHevxOSaSCU3qlQHGzNrt1cCl8Y4naWJ8naLVHj3XNJ0Igi2ss2BLbd3om6u9YT+xJ/wSNaMqTNTGDJ6Q/AiBvnd+F/HqkKMm/hgLKv9xkzUMuJPLvQYjm1++amWOTrODLpjelaLpOE3JA+feYunsl6YiTXMIvwyf7DjZGN1TbJ+3iIVpo/gSZzq3KUSNdaGoH/ihtxJjEcpo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(39860400002)(346002)(396003)(136003)(451199015)(2616005)(6512007)(186003)(26005)(38070700005)(82960400001)(86362001)(36756003)(122000001)(38100700002)(2906002)(6916009)(316002)(4001150100001)(76116006)(5660300002)(8936002)(91956017)(64756008)(66556008)(66446008)(8676002)(66476007)(66946007)(41300700001)(6506007)(71200400001)(478600001)(6486002)(22166006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YkR1bkdlZW9OWVJaNFkwUVJ5UVFDaWpkT2srV1ZhQTliNUhFM09FOWF5ek1Q?= =?utf-8?B?KzdkeGVCKzg2ajQwakEzMTdpRjBHM1pLanRDMm82N09IcE80VVB1Wkw4d3Vk?= =?utf-8?B?eGRwUFpkSzVxdkttdC8xRjVmUmdqbzAzejVrc0trTktPQVdHOFJTZnRFUUJN?= =?utf-8?B?SksrUG1XSW1tTUFmQ0NxM3R1SDBGM2txS1ZqS0FWeGtDNCs0Q3BTTGZ5em40?= =?utf-8?B?NFJjS3pvWHZaVXl5WUd1ZVNRK1p2WkV2Y09lY3J6aGJ0Q1g4YUVUV0pXY0Zr?= =?utf-8?B?SkNTL1lWVHdCZVRSQlV3WHJTSHR4UnJpR0JrQTF6b0VoVGJ3cXluckF2VENY?= =?utf-8?B?K28vMm5BZ1FXWEk5bTJqK0UxWG52ckpwNXVhR0RvVW04V1Vmb0VpVkpGTFYw?= =?utf-8?B?S1o4R01tZm1RbTBCNXg0RERiOWRRNGdWQ0NuNHBYVWVlQmpMclowdDlZTnhJ?= =?utf-8?B?RkwvSTFwcVFqM2REcXgxbmFXQkNJNTZEbEpGRzBSTTI3dCs5Z21YdWxEZlhU?= =?utf-8?B?U2JUamVPMVhyRVlrZWxwN0htUDJWTHJaaERNRGhrQW9GSllkTk1FTnlyR2dE?= =?utf-8?B?RDQ3YWdkb0N1VGRYTmxJVDdsQ2hORStLTjFtQVNuY29SZWJ5RUVMa3JlU21n?= =?utf-8?B?bGRjNFR0NUZZcS9GS2FycEtwQ2NUa0wrZFZ4OWl6SkJQRHhzTHdsWGRBemlZ?= =?utf-8?B?TmJjaUR6MnRKdTMvMXZjMmI5dUw5ekN2ZnZtQ3cwY3QyNlo1a2p1RjViTkZQ?= =?utf-8?B?NUJpOVQ0WDc0bUVDU3ZEd0t2QlpDMVhuMDE3akx5a1hkZ3RSNkRGY0N2TWZB?= =?utf-8?B?eEJxdHVQdVM0VmdsalVvR3JFMGNZWERpOHl2MlVNRmgyQXlsZzh0OWpUdW5X?= =?utf-8?B?QkNIVEZnK2NhL29VU0ZxU1BVd2JaMUhzQUR6bk5veDBDT24vUVJxV1J1VXRh?= =?utf-8?B?TkdUWTIzOXErSC9rbEJnY2VncFpDL2p4SllONWNmS3FsQkZQV01IZXJjM2E5?= =?utf-8?B?ajFRcmNQS2JQa3JxdGo0YlU5M3FoM0czZTVRVzBoUTFuWnlnbnZHYmtkejZN?= =?utf-8?B?azVhOTk5c21HbzNmUDh6eVU2SmQwTHFSVnB0bUZ4Q2VQbUQvSS9wWVJQVTFo?= =?utf-8?B?SnBsdHdtVW42cythdHJDSUFvKzIwQVphM0xDT3k2QUNUeTh0cVBmem9pdGs0?= =?utf-8?B?N0Jmdy84ZUdnRmxVZXVBcFVpUFloaGJlbEdaV2h4eSsyM0JHbUZhRDhRa1hz?= =?utf-8?B?b0gzTTJIdVcrTnRLdElMZHk2aWJSb3RscjV5ZmhBVXpnRkx0cCtHUGRiS3BJ?= =?utf-8?B?NXpneDc0UVNOOVlrSlR0VEt4T2o0R0ZJakpWMSt2VjBsdk1QNlltWDRjSFA2?= =?utf-8?B?MVBXRHdpSDcxSnprZEZGbmdDN2hVbXI0QTNFa3doZjY2aTNqbXE1QWF0NUlL?= =?utf-8?B?SDRGNVl6U1hCTXY2YVRJN3Z3bGR3TjFFNkN3c1pHejM3RWNqYjhUL08wdjhk?= =?utf-8?B?RS9uSGVhdDV4YXNKdm13Y3ZFUVhVS3k2ZStJekJPc3lta3NNL0JUQTVjQ2s0?= =?utf-8?B?alZqU2RTdy82OFVFVktmd29UZCszdndFZXdFRHh1d2t4V1ljYUlUTW1zTE1F?= =?utf-8?B?TTN3aTdsc2hKKzdSeWRPWDl6c3VCMU1UTDRlSHlJaFh4OWt6SE5oVzNWeTgv?= =?utf-8?B?MXZNaWdmUXdKZmsxekxLVUNCdDloQjBWMGlJU2tTaEFzUWQrVWcyWjJBMlAv?= =?utf-8?B?T1JxNVFhTkRqUktwSGR4Tk54TVJ6TzcvSkZTRjVIVVo4Q0U0b3dmSEVZTmU4?= =?utf-8?B?aURDalQ4V3locytEM2gyRDRVMzhobEtWd2VXbVhwUmIrVVA0VUxLR3JQV2d0?= =?utf-8?B?ZFo4R09NdHRIa0tzdXoveHFGVkdqaW8vUXJ6UThxRUxOYjFMUzRRRTZNTnJj?= =?utf-8?B?RER3dWNKTEFjWTIrQ2lodVVTR3hkaE00N3FISk0ya1huT0Y2NEtXc2NyNnlT?= =?utf-8?B?R3Y1MjZaMTFUSUpEaGxEYlhLTzJ3YUdTdVlUamFWMHJYKzBzR0w5UFlNbEIr?= =?utf-8?B?MjNBTEVheTMwN2txWk02cVVHdnVYTkt0N1U2QjhhZExMbXZtYlRzbDhGaFB4?= =?utf-8?B?cUc0MlVqNFMzUGowZ3ZPa3lWYkJqOXMvN2t6aGhldTAwSDMydDFxRzUyVDNQ?= =?utf-8?B?c1E9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05c92e79-f901-4142-841f-08daed270a0c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2023 01:08:35.4133 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6+q6At0lhI8qopNjPb6DK04ZPzVWosZl5cw7qAD3X6H9ixrlDyvqlUt0DP8uaOUj3WKt448+Z5qUlyFRLmxnsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8183 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc_av1: Add low_delay_brc support to av1_qsv encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Ma, 2022-12-26 at 14:02 +0800, wenbin.chen-at-intel.com@ffmpeg.org wrote: > From: Wenbin Chen > > Signed-off-by: Wenbin Chen > --- > doc/encoders.texi | 5 +++++ > libavcodec/qsvenc.c | 4 ++++ > libavcodec/qsvenc_av1.c | 1 + > 3 files changed, 10 insertions(+) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index b8051cda3f..543b5e26a9 100644 > --- a/doc/encoders.texi > +++ b/doc/encoders.texi > @@ -3850,6 +3850,11 @@ Extended bitrate control. > > @item @var{look_ahead_depth} > Depth of look ahead in number frames, available when extbrc option is > enabled. > + > +@item @var{low_delay_brc} > +Setting this flag turns on or off LowDelayBRC feautre in qsv plugin, which > provides > +more accurate bitrate control to minimize the variance of bitstream size > frame > +by frame. Value: -1-default 0-off 1-on > @end table > > @section snow > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index 514a1e8148..f5c6a164bb 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -537,6 +537,7 @@ static void dump_video_av1_param(AVCodecContext *avctx, > QSVEncContext *q, > > av_log(avctx, AV_LOG_VERBOSE, "WriteIVFHeaders: %s \n", > print_threestate(av1_bs_param->WriteIVFHeaders)); > + av_log(avctx, AV_LOG_VERBOSE, "LowDelayBRC: %s\n", print_threestate(co3- > >LowDelayBRC)); > } > #endif > > @@ -1090,6 +1091,9 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->extco3.MaxFrameSizeP = q->max_frame_size_p; > > q->extco3.ScenarioInfo = q->scenario; > + } else if (avctx->codec_id == AV_CODEC_ID_AV1) { > + if (q->low_delay_brc >= 0) > + q->extco3.LowDelayBRC = q->low_delay_brc ? > MFX_CODINGOPTION_ON : MFX_CODINGOPTION_OFF; > } > > if (avctx->codec_id == AV_CODEC_ID_HEVC) { > diff --git a/libavcodec/qsvenc_av1.c b/libavcodec/qsvenc_av1.c > index bb9ad16927..1e7801fefe 100644 > --- a/libavcodec/qsvenc_av1.c > +++ b/libavcodec/qsvenc_av1.c > @@ -110,6 +110,7 @@ static const AVOption options[] = { > QSV_OPTION_ADAPTIVE_I > QSV_OPTION_ADAPTIVE_B > QSV_OPTION_EXTBRC > + QSV_OPTION_LOW_DELAY_BRC > { "profile", NULL, OFFSET(qsv.profile), AV_OPT_TYPE_INT, { .i64 = > MFX_PROFILE_UNKNOWN }, 0, INT_MAX, VE, "profile" }, > { "unknown" , NULL, 0, AV_OPT_TYPE_CONST, { .i64 = > MFX_PROFILE_UNKNOWN }, INT_MIN, INT_MAX, VE, "profile" }, > { "main" , NULL, 0, AV_OPT_TYPE_CONST, { .i64 = > MFX_PROFILE_AV1_MAIN }, INT_MIN, INT_MAX, VE, "profile" }, Patchset LGTM, will apply, -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".