Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: use correct NULL value for Vulkan type
@ 2024-06-24 18:48 Timo Rothenpieler
  2024-06-24 22:17 ` Lynne via ffmpeg-devel
  0 siblings, 1 reply; 2+ messages in thread
From: Timo Rothenpieler @ 2024-06-24 18:48 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Timo Rothenpieler

---
 fftools/ffplay_renderer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fftools/ffplay_renderer.c b/fftools/ffplay_renderer.c
index 80b700b3c5..f272cb46f1 100644
--- a/fftools/ffplay_renderer.c
+++ b/fftools/ffplay_renderer.c
@@ -766,7 +766,7 @@ static void destroy(VkRenderer *renderer)
         vkDestroySurfaceKHR = (PFN_vkDestroySurfaceKHR)
                 ctx->get_proc_addr(ctx->inst, "vkDestroySurfaceKHR");
         vkDestroySurfaceKHR(ctx->inst, ctx->vk_surface, NULL);
-        ctx->vk_surface = NULL;
+        ctx->vk_surface = VK_NULL_HANDLE;
     }
 
     av_buffer_unref(&ctx->hw_device_ref);
-- 
2.44.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: use correct NULL value for Vulkan type
  2024-06-24 18:48 [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: use correct NULL value for Vulkan type Timo Rothenpieler
@ 2024-06-24 22:17 ` Lynne via ffmpeg-devel
  0 siblings, 0 replies; 2+ messages in thread
From: Lynne via ffmpeg-devel @ 2024-06-24 22:17 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Lynne


[-- Attachment #1.1.1.1: Type: text/plain, Size: 763 bytes --]

On 24/06/2024 20:48, Timo Rothenpieler wrote:
> ---
>   fftools/ffplay_renderer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fftools/ffplay_renderer.c b/fftools/ffplay_renderer.c
> index 80b700b3c5..f272cb46f1 100644
> --- a/fftools/ffplay_renderer.c
> +++ b/fftools/ffplay_renderer.c
> @@ -766,7 +766,7 @@ static void destroy(VkRenderer *renderer)
>           vkDestroySurfaceKHR = (PFN_vkDestroySurfaceKHR)
>                   ctx->get_proc_addr(ctx->inst, "vkDestroySurfaceKHR");
>           vkDestroySurfaceKHR(ctx->inst, ctx->vk_surface, NULL);
> -        ctx->vk_surface = NULL;
> +        ctx->vk_surface = VK_NULL_HANDLE;
>       }
>   
>       av_buffer_unref(&ctx->hw_device_ref);

Sure, LGTM
Thanks

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-24 22:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-24 18:48 [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: use correct NULL value for Vulkan type Timo Rothenpieler
2024-06-24 22:17 ` Lynne via ffmpeg-devel

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git