From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: use correct NULL value for Vulkan type
Date: Tue, 25 Jun 2024 00:17:08 +0200
Message-ID: <6338b66d-70d8-42d5-8c15-199591d878ca@lynne.ee> (raw)
In-Reply-To: <20240624184855.1456-1-timo@rothenpieler.org>
[-- Attachment #1.1.1.1: Type: text/plain, Size: 763 bytes --]
On 24/06/2024 20:48, Timo Rothenpieler wrote:
> ---
> fftools/ffplay_renderer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffplay_renderer.c b/fftools/ffplay_renderer.c
> index 80b700b3c5..f272cb46f1 100644
> --- a/fftools/ffplay_renderer.c
> +++ b/fftools/ffplay_renderer.c
> @@ -766,7 +766,7 @@ static void destroy(VkRenderer *renderer)
> vkDestroySurfaceKHR = (PFN_vkDestroySurfaceKHR)
> ctx->get_proc_addr(ctx->inst, "vkDestroySurfaceKHR");
> vkDestroySurfaceKHR(ctx->inst, ctx->vk_surface, NULL);
> - ctx->vk_surface = NULL;
> + ctx->vk_surface = VK_NULL_HANDLE;
> }
>
> av_buffer_unref(&ctx->hw_device_ref);
Sure, LGTM
Thanks
[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-24 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 18:48 Timo Rothenpieler
2024-06-24 22:17 ` Lynne via ffmpeg-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6338b66d-70d8-42d5-8c15-199591d878ca@lynne.ee \
--to=ffmpeg-devel@ffmpeg.org \
--cc=dev@lynne.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git