From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 19D3D4273A for ; Tue, 29 Mar 2022 21:33:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E57D168B002; Wed, 30 Mar 2022 00:33:16 +0300 (EEST) Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7EA4C680593 for ; Wed, 30 Mar 2022 00:33:10 +0300 (EEST) Received: by mail-oi1-f172.google.com with SMTP id z8so20329695oix.3 for ; Tue, 29 Mar 2022 14:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=9BwiG14S71PtQfUt1PdVIcNFI0PALV/ZB4/o5LTwUOY=; b=nFXC/9Vq6xe/hT3lvts6Gk+PGnyGSQY+ymNa312Lb+W6+ZIdW36HZ+Y0Cqf2sZ9iWV ddHAQ62VMy6x2sRclXBrMd+bKbnnVtpVRPZ7Sw4vWeau5jZhQ744abFPUWKuu1AIQKip PNpL/gbMIKYKycSWo6+oPtJ9PsYnbeH9tRRjEGjbDGGHMzLC3F7xbYp4kYp+mLE8EKIX AIGsGkS6c85zWAnrnjlJrIw0lDxX7z1nC6hRkTr4CROGzfO9kYNA90noe2cLZYcTJtm7 Si0tARN6Z8GglV2wjSM6owQjgElkdDW9U/zlXaZQ/LL/wxNHOeBmLKdG3JVUDcYP+xko wA7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9BwiG14S71PtQfUt1PdVIcNFI0PALV/ZB4/o5LTwUOY=; b=5A9CLBV/+K8t+QxqsUVUhog1izixY14aeOFMymIXUDDMMRZHtht6n+8/hwMjkTAfHQ bE7uKoMlZCgUhBpfyXaMF2LMQ2CakFwQlscWXNa7IjPLNaUFIWIe7ge0XkgkqQRayVpg WL8MoH7oh2pJDkEcJZSjLL/5qyiZlIFQ1h4G3K0HdRo2eQszHaWpmOigB/wSMxYKg9E2 S3ZqoseTV6MiouI6VGVn9psmi/U0kJk7KmJFcrGNm1KsJIawSDL1nWyAsosiAlf7+t0G b5/wzWH0tn/Oa0syVeGOv9/2YnruRWepLO9lY4J3Cg60RC2c5JRDdEGnPEijq/6KzmNT +P9Q== X-Gm-Message-State: AOAM530/6MaWvocOwvfxUNl5i72MAUR46jRMupbuicM0p727RxCQsyOO FL6kWzaT5SsKeyE/sDYwZMQUuxujVTsXMQ== X-Google-Smtp-Source: ABdhPJy7BwTVUhZHVQPnQWFqyHADYwokdWAynLsKYr19FhFPGphXPuLGFgcFYUiqk0Vnoe0aCeBjXw== X-Received: by 2002:a05:6808:3021:b0:2f7:4c5b:2783 with SMTP id ay33-20020a056808302100b002f74c5b2783mr553849oib.53.1648589588519; Tue, 29 Mar 2022 14:33:08 -0700 (PDT) Received: from [192.168.0.12] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id i28-20020a9d4a9c000000b005ce06a77de2sm50551otf.48.2022.03.29.14.33.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Mar 2022 14:33:07 -0700 (PDT) Message-ID: <62c40964-d827-d044-cec3-233bfc04aaf1@gmail.com> Date: Tue, 29 Mar 2022 18:33:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220329212459.23440-1-michael@niedermayer.cc> From: James Almer In-Reply-To: <20220329212459.23440-1-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/pcm_rechunk_bsf: unref packet before putting a new one in X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/29/2022 6:24 PM, Michael Niedermayer wrote: > Fixes: memleak > Fixes: 45982/clusterfuzz-testcase-minimized-ffmpeg_BSF_PCM_RECHUNK_fuzzer-5562089618407424 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/pcm_rechunk_bsf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/pcm_rechunk_bsf.c b/libavcodec/pcm_rechunk_bsf.c > index 108d9e90b9..3f43934fe9 100644 > --- a/libavcodec/pcm_rechunk_bsf.c > +++ b/libavcodec/pcm_rechunk_bsf.c > @@ -153,6 +153,7 @@ static int rechunk_filter(AVBSFContext *ctx, AVPacket *pkt) > } > } > > + av_packet_unref(s->in_pkt); This looks to me like it revealed a bug in the code above, which is meant to ensure s->in_pkt will be blank at this point. It should be fixed there instead. > ret = ff_bsf_get_packet_ref(ctx, s->in_pkt); > if (ret == AVERROR_EOF && s->out_pkt->size) { > if (s->pad) { _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".