From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2E6DB49605 for ; Fri, 15 Mar 2024 12:18:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 449DC68D130; Fri, 15 Mar 2024 14:18:03 +0200 (EET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9D5B368C81B for ; Fri, 15 Mar 2024 14:17:57 +0200 (EET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e6ade6a66aso1921938b3a.3 for ; Fri, 15 Mar 2024 05:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710505075; x=1711109875; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=rvf1UYYTtcbNjuuYlMSjwQVinOaQbuymaOhkbvBf2SE=; b=Q5/Vn9s04Dn1xHKFgjx4F9Ylkt6IumXfbTeaaKhUDnk4oh2gksI0n+sPiXkRyW8qyL udY2XKWKj5kbcrPxadzIbxiQJORRAOi1Qun13K0uUrG28xD8d9bFWiXpdaRjQHFB/gR9 bhOF9NdyDMKZdZNCLReC8ZiJLKZTjg0XrDOML9htbiCUc7uEgFtXl4uA7yT3caEKoKaj 9qG8wzc6FCNSP+/dp8vAbGRh8aWXbLy+2pJSGiZi6n1gsU62LiwX899ac/wFEIabj5be 8cvlJJblmwUaHYWDs8M6SGtSWT7I5c5FgNsE1iaxXYuRMR32bnEU5l0nUeBIGH9AY4dW apVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710505075; x=1711109875; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rvf1UYYTtcbNjuuYlMSjwQVinOaQbuymaOhkbvBf2SE=; b=ebkN9p+kWcRoHcIRL7t+BOw+TmwVCT+uVXuX5b4S+SXMdUa9y8zArxbxIjTOfL3NJN rFdtx6qO6RkxRJ1Iwl2LfXHymc6nol4R3Cfavnu9Nax7gB5/PH1GS/JN6gZkTzlZ9gZj TbR3cvMrE4RdcITS5bBGX3uyDBwUShIdVDCldobcacVJVTtGE/rfuoKx1RqijAhWk10G Na/zeXi9BkwgqoooOIUKNVrfuwG83iucGIpseVDTtJkdC8nzdSv7dfDUODFo7kx4BrjF yauD0EjDhu7D9kJMEmdcoRv4oKkeYrnjHjQ0YXZsKYyp35teeCcqsZxtSNkc4cyybjbW eG8Q== X-Gm-Message-State: AOJu0YyGpf6TIyAyRjE3omG7m8gaaZvQcKZn+53hImw+vYwVrrgOz4lI xR7PEePEfp7Flqgu7V6NCKC8LC8ga9eWyXodVKAYmChLPHbVS3sQ5F1gEj7E X-Google-Smtp-Source: AGHT+IHrfJkvPdLdBfMhpwlQwhuzzQSBidvRkk47Nf0Y+9hRQMmq42X6vJnf4KDx636Vx3pWN2TSDQ== X-Received: by 2002:a05:6a20:43ab:b0:1a3:42ea:cbed with SMTP id i43-20020a056a2043ab00b001a342eacbedmr4643455pzl.44.1710505074614; Fri, 15 Mar 2024 05:17:54 -0700 (PDT) Received: from [192.168.0.10] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id l17-20020a629111000000b006e5571be110sm3355056pfe.214.2024.03.15.05.17.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Mar 2024 05:17:54 -0700 (PDT) Message-ID: <62a32596-627e-44d6-b187-b7a12c9e7527@gmail.com> Date: Fri, 15 Mar 2024 09:18:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240315120442.73754-1-ffmpeg@haasn.xyz> <20240315120442.73754-2-ffmpeg@haasn.xyz> Content-Language: en-US From: James Almer In-Reply-To: <20240315120442.73754-2-ffmpeg@haasn.xyz> Subject: Re: [FFmpeg-devel] [PATCH v3 1/9] avutil/film_grain_params: add extra AFGS1 metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/15/2024 8:58 AM, Niklas Haas wrote: > From: Niklas Haas > > In hindsight, it may have been better for this to be part of the common > film grain struct, to avoid duplication of these fields between it and > H274 (and to allow initialization by av_film_grain_params_alloc), but > I can't add new fields before the union without breaking ABI, and having > the union not be the last parameter will make future extensibility > similarly difficult. You could add them now at the end, and in the next major bump we simply reorder the fields so the union is last again. > --- > doc/APIchanges | 4 ++++ > libavutil/film_grain_params.h | 15 +++++++++++++++ > libavutil/version.h | 2 +- > 3 files changed, 20 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index cf58c8c5f0a..5a192b600af 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,10 @@ The last version increases of all libraries were on 2024-03-07 > > API changes, most recent first: > > +2024-03-08 - xxxxxxxxxx - lavu 59.2.100 - film_grain_params.h > + Add AVFilmGrainAOMParams.color_range, color_primaries, color_trc, > + color_space, width, height, subx, suby and bit_depth. > + > 2024-03-08 - xxxxxxxxxx - lavc 61.1.100 - avcodec.h > Add AVCodecContext.[nb_]side_data_prefer_packet. > > diff --git a/libavutil/film_grain_params.h b/libavutil/film_grain_params.h > index f3bd0a4a6a3..17fefeb06c3 100644 > --- a/libavutil/film_grain_params.h > +++ b/libavutil/film_grain_params.h > @@ -120,6 +120,21 @@ typedef struct AVFilmGrainAOMParams { > * Signals to clip to limited color levels after film grain application. > */ > int limit_output_range; > + > + /** > + * Video characteristics metadata, only for AFGS1 streams. > + */ > + enum AVColorRange color_range; > + enum AVColorPrimaries color_primaries; > + enum AVColorTransferCharacteristic color_trc; > + enum AVColorSpace color_space; > + > + /** > + * Intended display resolution and format, only for AFGS1 streams. > + */ > + int width, height; > + int subx, suby; > + int bit_depth; /* or 0 if unknown */ > } AVFilmGrainAOMParams; > > /** > diff --git a/libavutil/version.h b/libavutil/version.h > index 09f8cdc2926..57cad02ec0a 100644 > --- a/libavutil/version.h > +++ b/libavutil/version.h > @@ -79,7 +79,7 @@ > */ > > #define LIBAVUTIL_VERSION_MAJOR 59 > -#define LIBAVUTIL_VERSION_MINOR 1 > +#define LIBAVUTIL_VERSION_MINOR 2 > #define LIBAVUTIL_VERSION_MICRO 100 > > #define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".