From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 221924959A for ; Sat, 13 Apr 2024 13:55:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A7E9668D316; Sat, 13 Apr 2024 16:55:15 +0300 (EEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7124F68D264 for ; Sat, 13 Apr 2024 16:55:08 +0300 (EEST) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6ecf1bb7f38so1619782b3a.0 for ; Sat, 13 Apr 2024 06:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713016505; x=1713621305; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=1qPKyXHghE+5iZ1f5+iLontppFPE5FYUqprdd56jg+c=; b=H80j6CXgfXfLSg+O29necjof1SELMwwGKA7j+iQCbxroXLWGaL4Z6LWYRYjjnS8gib Ez4qp3UzWoh0/oZKSCoAGe4/PBSlVaVrdVSOyYsUllrzuJkgYrGPrmXTxVdLjOZo6mr3 qju33wihVmAUykMN4rUE1cLK5xPTaVrcKtZZZWwC0WWK5vIIkMJTssVg4gEe8kx+JHbz KBDgZ+mQYGZxHy6JXktCim3Mil4tbInUPGCN8Ewpl6zTwCVsEK6J5+SeC39ABu9bMAIm 0wGSYjmjfFzWrW6gK6rKLkIY/yCoo79CbpcpqQS8nRSORTfsc/UBZ8ei6bRrkFfdxTAa Yrag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713016505; x=1713621305; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1qPKyXHghE+5iZ1f5+iLontppFPE5FYUqprdd56jg+c=; b=hUtcl24cqsWlYGiFn0bTu4iUdVa/iyEN3sH1VaxtqESmXMMGvQ4Rr7BqPIFqO6kERx SNEpn/GIOJxad6gG6IXPRc3cHDTjhOR7/1NyWS0Lh5FDb+FJOzMp2UMYq+rHEP/a7IH2 G2OFUO+aGJyfd6lZzX4bxtdiQ3LO/WomtO0xSc05J+ozYFzMypsEQFlBJ8dM1Fj98crw s+qH/RDVc/EbjPAQ46DRqr745+uO4KWP89Aqkqw5bJthE9BfuMHLnsCaImKEoRu72/qH lPer2C0XfZeEJfdHSrS/Vf4zPSdLec3DcdoAZ3sHKMWvbYwFDlJXFgz1RP5tbp9FPYmd sEdg== X-Gm-Message-State: AOJu0Yx29rXQe6hx/RlbuG48KGVLZZOW10tCYGVjQnbxOLQuOrf4QLy/ uxmMSFxlTtiS/L9Suxwk2jzjHLAqY09wWmZjcXbvsEAbjD1yTYdmlsFFZA== X-Google-Smtp-Source: AGHT+IGiyZroUMlkiGbOEK2v5gWSwECjNC+QlfBaOGDUqF0aSgxpnUrxBphhJ8NfYJENTxm7Bb8/Gg== X-Received: by 2002:a05:6a21:35c4:b0:1a3:dc86:40b1 with SMTP id ba4-20020a056a2135c400b001a3dc8640b1mr5541094pzc.36.1713016505401; Sat, 13 Apr 2024 06:55:05 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id b22-20020a056a000cd600b006ead792b6f2sm4402906pfv.1.2024.04.13.06.55.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Apr 2024 06:55:04 -0700 (PDT) Message-ID: <629f6802-b204-4981-bafb-4a210bde45f0@gmail.com> Date: Sat, 13 Apr 2024 10:55:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240413105554.57677-1-post@frankplowman.com> Content-Language: en-US From: James Almer In-Reply-To: <20240413105554.57677-1-post@frankplowman.com> Subject: Re: [FFmpeg-devel] [PATCH] lavc/vvc: Increase size of ctb_size_y X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/13/2024 7:55 AM, Frank Plowman wrote: > sps_log2_ctu_size_minus5 is between 0 and 2, with 3 reserved for future > use. The VVC decoder allows sps_log2_ctu_size_minus5 to be 3, and so > ctb_size_y should be at least 16 bits to prevent overflows. An > alternative patch would leave sps_log2_ctu_size_minus5 as 8 bits and > disallow sps_log2_ctu_size_minus5 = 3. The spec says a value of 3 should be ignored, which i assume means decoding is not meant to stop. So this patch is probably better than outright rejecting the value in CBS. > > Signed-off-by: Frank Plowman > --- > libavcodec/vvc/ps.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vvc/ps.h b/libavcodec/vvc/ps.h > index 78f1687fef..6656a06320 100644 > --- a/libavcodec/vvc/ps.h > +++ b/libavcodec/vvc/ps.h > @@ -69,7 +69,7 @@ typedef struct VVCSPS { > uint8_t bit_depth; ///< BitDepth > uint8_t qp_bd_offset; ///< QpBdOffset > uint8_t ctb_log2_size_y; ///< CtbLog2SizeY > - uint8_t ctb_size_y; ///< CtbSizeY > + uint16_t ctb_size_y; ///< CtbSizeY > uint8_t min_cb_log2_size_y; ///< MinCbLog2SizeY > uint8_t min_cb_size_y; ///< MinCbSizeY > uint8_t max_tb_size_y; ///< MaxTbSizeY _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".