From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 04FC040391 for ; Wed, 19 Jan 2022 16:48:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2987368B0D7; Wed, 19 Jan 2022 18:48:47 +0200 (EET) Received: from shout01.mail.de (shout01.mail.de [62.201.172.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8AE7A68AC87 for ; Wed, 19 Jan 2022 18:48:40 +0200 (EET) Received: from postfix01.mail.de (postfix02.bt.mail.de [10.0.121.126]) by shout01.mail.de (Postfix) with ESMTP id BEBAEA0606 for ; Wed, 19 Jan 2022 17:48:39 +0100 (CET) Received: from smtp04.mail.de (smtp04.bt.mail.de [10.0.121.214]) by postfix01.mail.de (Postfix) with ESMTP id A5923A03C1 for ; Wed, 19 Jan 2022 17:48:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1642610919; bh=PvaIY50O/sEMqp8oTK3DYueLXklur6aZ6cEtz2iNyIw=; h=Date:Subject:To:References:From:In-Reply-To:From; b=o15z7osSxiEmKrR7IaNBTDI4ojVCzhzHiMCj4Z4J+cQkG2J4oKXPHfVVQkXXkMOsb Ubr4B3i2le//8d870Xym8mr/8XrZ+CWItGWytqAEOTzlRkseecR0q/L5AjnnQajEhD SUPghMLYJSvywI0gFBiLK9o9tR2HbR2XKqQdpDO0d6Iz5d0hoaUOiK4l+QVN99y7y4 f+X4FZuQq7oh+LDFlqmKF3E1naGguHI43aj1RmicK2ikhObv57Nt9wR83BNzqEA/aH yPoQEf8E/p1CVicFyF3CElv9H8VH9EDsqRh1MmsOrHEW9In1cKODQfJAgfEFRPY7X1 3q5bFrpjK4t7Q== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtp04.mail.de (Postfix) with ESMTPSA id 63DFEC00AE for ; Wed, 19 Jan 2022 17:48:38 +0100 (CET) Message-ID: <62890260-bf04-7ec1-f6d9-2d284852718f@mail.de> Date: Wed, 19 Jan 2022 17:48:38 +0100 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Thilo Borgmann In-Reply-To: X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 962 X-purgate-ID: 154282::1642610919-00007C04-A20BE5CE/0/0 Subject: Re: [FFmpeg-devel] [PATCH 1/5] libavdevice/avfoundation.m: use setAudioSettings, extend supported formats X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am 19.01.22 um 15:28 schrieb Andreas Rheinhardt: > Romain Beauxis: >> This patch switches the logic around audio settings to let the caller drive the >> format. >> >> After experimenting with the AudioConverter, we realized that, even when >> adhering to a strict implementation of the documented API, we were still getting >> errors during conversions. The input device would randomly change from e.g. >> s32le to s24le between restarts and error out on conversion (using a freshly >> initialized converter). >> >> Using setAudioSettings allow the OS to drive audio conversion internally and >> pick whatever appropriate settings for the audio device. This has been working >> very well and is also the way AVFoundation audio input is setup in videolan. >> > > Your mail is broken: we don't want patches as eml; instead you should > attach what git format-patch produces. Or you can use git send-email > directly. +1, please. -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".