From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8F0B44DA79 for ; Tue, 3 Jun 2025 16:40:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5FCDB68D972; Tue, 3 Jun 2025 19:40:31 +0300 (EEST) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 42A6468D95C for ; Tue, 3 Jun 2025 19:40:24 +0300 (EEST) Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-553331c3dc7so5997696e87.3 for ; Tue, 03 Jun 2025 09:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1748968823; x=1749573623; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=I2fBBsnbwggrGjInZDmvhlWa3zA0WF5GbIvzLBLM3hg=; b=CyF9WSwCNyB3ArdmRqLD2t6284fVS0rzzSS56OooA7l3elYvFU+NiMoPwVp1AyPaLO o9vtBsCMygl7VpUlfNFGt0gR5cFY5RSzZTehhzoe/Kd8SLo+O2Px47m58vXVXRu/jY6z ZTrCRTKa0G97Esm/TkC9t7ZzlKk3WwRJlUp7jKA55+dPH/49m1/hu/ODUhHwJ4oqWEne gijnIXR6pmQSMSF4Z6i+fDw6+wB+KARF234lcgU6Vhqxfq20LjbvlOFvNgJu6JhLjCiG 2cdkZ1Qp5S4TmXDG7pbOVd+l4E7fuokS3P6BlBAotgt0u6abgSpnh73GktaPMmjCALT4 27tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748968823; x=1749573623; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I2fBBsnbwggrGjInZDmvhlWa3zA0WF5GbIvzLBLM3hg=; b=L/xzOP/Rwmm11KmonR/WOHgSnR2fiPq+vKlMkejfshDQ7gHZ0G23P4wLHO9qKXym9M eMzxQtT9BtczbVBwkH5GL14cdiQQccvslFtFoRkIdOejM5k+vtC7OOr6ceYdLd7pbHgY vgr2byoGW38uryl/8fwrHIezJhNxFtFOXipYFr8zOr8cbgyNH47Fy49TX2d3iTIb2MjT 32pAV4PnBJMB4SNdCdaviXtuIKlM+NvRxUmC71cmhI4P7ke8jrScl/6JPwd+X63fHn9G VOTIQHq1pY6d8/9TjpUAFuN8rxd3/gRQQ/vocr+lWGUn96dWhJATyuwtyM6+NM5PK8rv a0/Q== X-Gm-Message-State: AOJu0YxeKaqs8sCIcHTWwpobfRRYEtKlZgLdRaCNrI6NyS+sPGBALuBk l3GKzJLERFk9vz3Lf0Zuu6AAKKh2Gi9XlrwasDcxljOIEw3dgV45k2pBIBBLjq5LKzWudO8UzOT yLwzwM3wJ X-Gm-Gg: ASbGncuehOIScjUJdSq5//agqZ88Nvh6I9IY55ttuY4BlIV2t0/21qmDo6BBeYk9DV8 VVM+o9xFOio9lCDCLI+DYk/fF8/vFiGcaswzudNgG9/wy8RYNtWdoJiQ7tcekzkajx20n8lxE+X 8U+PqPoufeg8wrwaqn6urBsg6NobNiWZA2NES50hU4syd1q8Beso9RndClxNv+UgqCZP6VzMrL6 DXietnezn8ilr9mohLjXyHhnUX1KeZAw4QQOb6cFYJTnjqCgq6O42+z8QTsabwuGVkqZng6glvd KEGofcU2NLHZBB0y/nSAQRx03LxdTA3p2+5Ns6z/pOAKCkxLXwZEreBrajuzQa0xcYZaum9zdiP xWX4MGVXS8SJeSSk6qwhvH4+bo433EGwqZu2G//kGnc/lZ4g= X-Google-Smtp-Source: AGHT+IEnIGNxL0cZzF9BfMkiSRwhzwriwc09BuwLcUikZ47Xw4iARf6+bvqTrVC4rrJwFmRkyfX45Q== X-Received: by 2002:a05:6512:2390:b0:553:37b0:d992 with SMTP id 2adb3069b0e04-55342f5dfaamr3457609e87.19.1748968822853; Tue, 03 Jun 2025 09:40:22 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5533787d35dsm1973120e87.46.2025.06.03.09.40.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 09:40:22 -0700 (PDT) Date: Tue, 3 Jun 2025 19:40:17 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20250603181557.GB181379@haasn.xyz> Message-ID: <627b8a6-50e5-d9c6-e811-6b72a5ea3fee@martin.st> References: <20250602184133.2175-1-jamrial@gmail.com> <20250603181557.GB181379@haasn.xyz> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avutil/x86/intmath: remove inline asm implementations for clip functions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 3 Jun 2025, Niklas Haas wrote: > On Mon, 02 Jun 2025 15:41:33 -0300 James Almer wrote: >> GCC/Clang is smart enough to emit minss/maxss the same way as these functions. >> The only theoretical benefit was in x86_32, where x87 floats are used, but the >> penalty of making the clipping opaque to the compiler's scheduler plus moving >> values from mmx regs to xmm and back will offset any potential speedup. >> x86_32 builds targetting anything made in the last two decades and a half >> should use -msse -mfp=sse anyway. > > As mention in the another thread, x87 FPU usage causes non-bitexact results in > swscale. Should we at this point consider setting -mfpu=sse by default for > x86_32 builds? I don't object to doing that - however, if we have float code, that is expected to be bitexact, the root issue still remains even if we force SSE fpmath on x86. The same issue could crop up on any architecture/OS/compiler combo, it's just that x87 math shows the issues much easier. (Not making a judgement whether that's an issue we want to deal with, or whether we're ok with having bitexact code that relies on float math that behaves close enough to some specific reference.) // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".