From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1618443E97 for ; Sun, 18 Dec 2022 17:18:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 551D568B8D2; Sun, 18 Dec 2022 19:18:17 +0200 (EET) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E90E768B3EA for ; Sun, 18 Dec 2022 19:18:10 +0200 (EET) Received: by mail-oi1-f182.google.com with SMTP id r205so5306961oib.9 for ; Sun, 18 Dec 2022 09:18:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DddxZF6VR6f9WE56D87Q5YeoHY2mEz82xOvZV6Jy2t4=; b=H2FbemBWNYPyKRs2XR3MzstNNNH/UjAbKFectl8ymcVC+KFiSWgSyuL57SPA19qK9j Ja+Xbif4ODhKbU4QHctiWiyiVkx5FpRGNEfRMTsuTfoRKnBVTLf+MD3990Gm53SrYsCw gZVmKXY7WrxCsVF0CYU7PP2agYE+cqkDS3pWs96jWeKISUJphINoQWLYNsQEi7qiuJ8F 02eiZAGUpDEP80v76QUKMVokPHIDOetma+MMrxB2XGYnvvDd2wO+xvvdstiZKWH8I92j 4r9XrxRIHDfe7lUOqaE+wAswTS/VdK+fht8NM8HThQIIYBe3YxhbFPPnYvlueeGbZxxt Id8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DddxZF6VR6f9WE56D87Q5YeoHY2mEz82xOvZV6Jy2t4=; b=M4NVcKovRJbSJPMYM/gn/sO5NIcp+LSJjvmsMX1W3TYUhvGH/NZ+FOm3A2a8aSrwFf z5KZocbZv3oyd6+vOX17mjMrelNWuUzFuLNqO4v3GXCxcM1JQEazt70WeFZ74qwP8xJh 8x2FPVFB0AFndtTts/CakiUzSAahF+e+xJ8TrugRXqwhLLETOqL3ZdLvRF/z9Ls0/4kf vGoLprHk/BHeIoLCNo0CR+OiP9KdxWYZVzoy3U7Y+zAVT9SXoZO1MjOg/sbgfgBMnFxv nEeE1Io/XbPv3tYUfwxfTyj7Xld+WH3VNyEBchJdd4trmzxqf73GYcl/0PwSHUJXZTQj KLNA== X-Gm-Message-State: AFqh2kpoC8y1CBR80ZMJggwT3R68OY1IrXhVMUX6w/u20UOlS7s3f/9Q 1eiqM6f4qvUdD/duzKi4tN2YCXUJMSw= X-Google-Smtp-Source: AMrXdXsCCO7VWjRSR6cbdA8ZPIwvuCKSRXZRzRYQMw6xheOP4WqWOh38zmnEKY8IVGNL8Eq6VgsB+A== X-Received: by 2002:a05:6808:13c1:b0:360:ceb6:1f6f with SMTP id d1-20020a05680813c100b00360ceb61f6fmr4549376oiw.54.1671383888845; Sun, 18 Dec 2022 09:18:08 -0800 (PST) Received: from [192.168.0.11] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id y19-20020a544d93000000b0035474ff66b3sm3377995oix.35.2022.12.18.09.18.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Dec 2022 09:18:08 -0800 (PST) Message-ID: <6258116a-9530-36bc-8c9f-8b829bc70e49@gmail.com> Date: Sun, 18 Dec 2022 14:18:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221218170823.32130-1-michael@niedermayer.cc> <20221218170823.32130-5-michael@niedermayer.cc> From: James Almer In-Reply-To: <20221218170823.32130-5-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/wavpack: Avoid undefined shift in get_tail() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/18/2022 2:08 PM, Michael Niedermayer wrote: > Fixes: left shift of 1208485947 by 1 places cannot be represented in type 'int' > Fixes: 54058/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5827521084260352 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c > index 3cb4077550..42859ab0a1 100644 > --- a/libavcodec/wavpack.c > +++ b/libavcodec/wavpack.c > @@ -129,7 +129,7 @@ static av_always_inline unsigned get_tail(GetBitContext *gb, unsigned k) > e = (1LL << (p + 1)) - k - 1; > res = get_bits_long(gb, p); > if (res >= e) > - res = (res << 1) - e + get_bits1(gb); > + res = ((unsigned)res << 1) - e + get_bits1(gb); Don't we usually do << 1U for this? > return res; > } > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".