From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 5/5] avcodec/wavpack: Avoid undefined shift in get_tail()
Date: Sun, 18 Dec 2022 14:18:30 -0300
Message-ID: <6258116a-9530-36bc-8c9f-8b829bc70e49@gmail.com> (raw)
In-Reply-To: <20221218170823.32130-5-michael@niedermayer.cc>
On 12/18/2022 2:08 PM, Michael Niedermayer wrote:
> Fixes: left shift of 1208485947 by 1 places cannot be represented in type 'int'
> Fixes: 54058/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5827521084260352
>
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavcodec/wavpack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
> index 3cb4077550..42859ab0a1 100644
> --- a/libavcodec/wavpack.c
> +++ b/libavcodec/wavpack.c
> @@ -129,7 +129,7 @@ static av_always_inline unsigned get_tail(GetBitContext *gb, unsigned k)
> e = (1LL << (p + 1)) - k - 1;
> res = get_bits_long(gb, p);
> if (res >= e)
> - res = (res << 1) - e + get_bits1(gb);
> + res = ((unsigned)res << 1) - e + get_bits1(gb);
Don't we usually do << 1U for this?
> return res;
> }
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-18 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 17:08 [FFmpeg-devel] [PATCH 1/5] avcodec/tiff: Check camera_calibration for 0 Michael Niedermayer
2022-12-18 17:08 ` [FFmpeg-devel] [PATCH 2/5] avcodec/tiff: Prettify code in dng_blit() Michael Niedermayer
2023-01-11 10:30 ` Michael Niedermayer
2022-12-18 17:08 ` [FFmpeg-devel] [PATCH 3/5] avcodec/apac: Sanity check bits_per_coded_sample Michael Niedermayer
2022-12-19 19:35 ` Paul B Mahol
2022-12-20 17:13 ` Michael Niedermayer
2022-12-18 17:08 ` [FFmpeg-devel] [PATCH 4/5] avcodec/h264_slice: Use unsigned for fgs seed computation Michael Niedermayer
2023-01-11 10:32 ` Michael Niedermayer
2022-12-18 17:08 ` [FFmpeg-devel] [PATCH 5/5] avcodec/wavpack: Avoid undefined shift in get_tail() Michael Niedermayer
2022-12-18 17:18 ` James Almer [this message]
2022-12-18 17:32 ` Andreas Rheinhardt
2022-12-18 18:14 ` Paul B Mahol
2022-12-20 16:42 ` Michael Niedermayer
2023-01-11 10:29 ` [FFmpeg-devel] [PATCH 1/5] avcodec/tiff: Check camera_calibration for 0 Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6258116a-9530-36bc-8c9f-8b829bc70e49@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git