From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0247444C74 for ; Fri, 13 Jan 2023 20:53:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D4B5E68BC7E; Fri, 13 Jan 2023 22:53:09 +0200 (EET) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E13E868813B for ; Fri, 13 Jan 2023 22:53:02 +0200 (EET) Received: by mail-ot1-f41.google.com with SMTP id cc13-20020a05683061cd00b00684b8cf2f4dso4661895otb.12 for ; Fri, 13 Jan 2023 12:53:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a7LN8Iq4gpm3DOq6KVlYB8QPsidM31yNTCEzBEcM98Q=; b=Zrj9EulEWaG+Qm2fIRKCZEXrKErFcxaIeO1240OU/RF8NEE2J2GWobOl8Xp8kRsqZ9 vF/OYj5TnmI8osNFOx3G6MlhjPymkH5mmZqYBiSg9w458djCWuoWZX3HvdyhnnBqFsHH cTmJtpRGCBO/0MUFaqiy11ft0w7jHJBr/MUEQWKVc1Sgs8Bz4e1n/QPplFepNI4uybKN RQASb1kVmn2oDKBwXLMKkmPpN6VFCQ4PHh/vQKloxbXfmWAIqEc98CO9WPWQdNMEnW7m jMpKWG03uS9dx+iS3Fhfh2+Mhyp87cpOGD+MRDcipanFOkh5lAVUUd7nUDB1jUzqOJEx j42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a7LN8Iq4gpm3DOq6KVlYB8QPsidM31yNTCEzBEcM98Q=; b=Kvj7rXGj1DGxf2JNU2kw7LRV1IB21vMhERvUyhlW19YOVuvs9I8Cgkkjt/5rq2sXrP Tq/ZPStAbD6AJtRYp7JpzKmdqZJU2dm9Dc2rFCWqnTL5n+J5iftXo90rjKina/knqbDB GxmjX5glOYWzqw4AvOkRBTxFYk5LJ4a//GpE4D3sfNDT3+WQhlHKQQgd5IIJ/Ns4YqSM IJRcpfNvB9hPKOKQ45IzmsEj6dPo5BPihkwSPdmPxfcKfR7mDP3baoxgibcIBWa4ammc /pf0TyzCxyN5D646HzQuDA8H4y6ESFQIjUgpO714Sy6RpBknvIalMumOuwxoa6KU8Njo 6pVQ== X-Gm-Message-State: AFqh2ko8NquSD+bzB4F85ZxPXKsTdsX3R/MmqD/JGDfLzr+yyuO+MOmw 8K0WMovDPOX55KJoYQfS0Y4HVFIsiMM= X-Google-Smtp-Source: AMrXdXscRQYSeIGi1xnimxIZ4jvIQZQ9+gnDEFLZvNjsze0vXn5a2oN0I4LNhBBPTIzzfAYIK6MXCQ== X-Received: by 2002:a9d:64c2:0:b0:670:74de:ed3e with SMTP id n2-20020a9d64c2000000b0067074deed3emr37283305otl.16.1673643180456; Fri, 13 Jan 2023 12:53:00 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id c25-20020a9d67d9000000b00667d9a866b0sm10821782otn.59.2023.01.13.12.52.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jan 2023 12:52:59 -0800 (PST) Message-ID: <62497d11-56af-a19c-fe2d-b907f2c32898@gmail.com> Date: Fri, 13 Jan 2023 17:53:20 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230113000138.9994-1-michael@niedermayer.cc> <20230113000138.9994-2-michael@niedermayer.cc> <8b9a4802-58fe-3009-2002-b3b6cddc4d19@gmail.com> <20230113204932.GO1949656@pb2> From: James Almer In-Reply-To: <20230113204932.GO1949656@pb2> Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/xpmdec: Check size before allocation to avoid truncation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/13/2023 5:49 PM, Michael Niedermayer wrote: > On Thu, Jan 12, 2023 at 09:11:35PM -0300, James Almer wrote: >> >> >> On 1/12/2023 9:01 PM, Michael Niedermayer wrote: >>> Fixes:OOM >>> Fixes:out of array access (no testcase) >>> Fixes: 48567/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XPM_fuzzer-6573323838685184 >>> >>> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/xpmdec.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/libavcodec/xpmdec.c b/libavcodec/xpmdec.c >>> index ff1f51dd32..504cc47d8f 100644 >>> --- a/libavcodec/xpmdec.c >>> +++ b/libavcodec/xpmdec.c >>> @@ -356,6 +356,9 @@ static int xpm_decode_frame(AVCodecContext *avctx, AVFrame *p, >>> size *= 4; >>> + if (size > SIZE_MAX) >>> + return AVERROR(ENOMEM); >> >> Maybe check for (size > SIZE_MAX / 4) before the multiplication above >> instead. > > what is the advantage of this ? An int64_t value will never be bigger than or equal to SIZE_MAX on 64 bits targets, so maybe some compiler out there will warn about it. > > thx > > [...] > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".