Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/vorbis_parser: quiet log on unrecognized packet types
Date: Tue, 28 Mar 2023 17:43:30 -0300
Message-ID: <6195691d-627c-2bf2-085a-7150818b6954@gmail.com> (raw)
In-Reply-To: <20230328203226.34753-1-rcombs@rcombs.me>

On 3/28/2023 5:32 PM, rcombs wrote:
> ---
>   libavcodec/vorbis_parser.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavcodec/vorbis_parser.c b/libavcodec/vorbis_parser.c
> index a7d15d4ce9..65ad3fe2a5 100644
> --- a/libavcodec/vorbis_parser.c
> +++ b/libavcodec/vorbis_parser.c
> @@ -234,7 +234,8 @@ int av_vorbis_parse_frame_flags(AVVorbisParseContext *s, const uint8_t *buf,
>               else if (buf[0] == 5)
>                   *flags |= VORBIS_FLAG_SETUP;
>               else
> -                goto bad_packet;
> +                av_log(s, AV_LOG_VERBOSE, "Ignoring packet with unknown type %i\n",

Probably should be %u.

> +                       buf[0]);
>   
>               /* Special packets have no duration. */
>               return 0;
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2023-03-28 20:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 20:32 rcombs
2023-03-28 20:32 ` [FFmpeg-devel] [PATCH 2/2] lavf/oggdec: fix demux with unrecognized header packets rcombs
2023-03-28 20:44   ` James Almer
2023-03-28 20:42 ` [FFmpeg-devel] [PATCH 1/2] lavc/vorbis_parser: quiet log on unrecognized packet types James Almer
2023-03-28 20:43 ` James Almer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6195691d-627c-2bf2-085a-7150818b6954@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git