From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DF98A46290 for ; Fri, 14 Jul 2023 12:37:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 76BF768C5BE; Fri, 14 Jul 2023 15:37:07 +0300 (EEST) Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 46BB968019F for ; Fri, 14 Jul 2023 15:37:00 +0300 (EEST) Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-563439ea4a2so1240643eaf.0 for ; Fri, 14 Jul 2023 05:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689338218; x=1691930218; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=imtFC8DwnuMnG90dxwH9sYMQ6M2pEw1KXPLZF4TKn54=; b=aGqll12UR1Xo/E3Ocqt9ziVbS8Ibz9r9QZjJQsxkpkXEp8M0ZOgJVdM3WFk4cEbUxe h1pQ6dNWs8STslRJOcvkq7V7pRoTk1DLSwbOs68bGbXRzMv3KXOW37IVMCL9VEJJLDfp XISkWSlPsIbAEGzGFL6fe8QhIh3//5pEfXx8MkQxk6tygBtXj+/T6/Ego3kmN4LL+q+q E/qZoIlkR3btMcEARNcEGOzuStKZa2SJe2Nx/ZwjcV213ZO6qh3kHeJCZs2Ppgajw1S5 Kk+QBT/PgySGToQhONYLBQtz5pmeFadMnK9+ppbCuXBlqksGKcJbxYgfSFjsQ0hx/bCM ZW+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689338218; x=1691930218; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=imtFC8DwnuMnG90dxwH9sYMQ6M2pEw1KXPLZF4TKn54=; b=cKHaA1CMwrRHTY8Nqjn+oMnN4u1gWo5aL6HQAYIyP7KHhr2qG2r/w78ZROGLf/XEnw vWIzNOb8hlSLrj83mioHLxhR56h8CRV/gxKXWcko1KDUfD2BcBmJXLIaIJiS2JWJYh1P z8sAjjXnLtTAaSh+ZomfPJjaE0k6UZTLcCZ/aOMuPeaNjWuqurd8A+BSH3HaSrWZRBUV OxZmBqol/FF2TKT35Ju0SKBqHOOhH/xQ1snmYJm+6xTKzs+cavCisgENXMo8vuW5Kpwd VB/Cxst9Ra8lsJEbMiBxy0ETl/wlskxOpErc6a224RkmC+zr+MY8cb8BSWkqZuqxwumF 1jxA== X-Gm-Message-State: ABy/qLYPhL0QhmYQdT8Epjm1PHFnL0Y7CB2xAMOMzn5y+Ih79CE3INR1 YCZnqOBI0L+i708NBBt40s3S2cFPUyE= X-Google-Smtp-Source: APBJJlE1OWK8KRgXm/Y3aCbZVvCvQYsU0+qXyPjLVcnM/OoYxpVC0Jj4mizmZPET8x8mrbIJKKVY5A== X-Received: by 2002:a4a:840b:0:b0:566:fe4f:4a09 with SMTP id l11-20020a4a840b000000b00566fe4f4a09mr3410455oog.4.1689338217734; Fri, 14 Jul 2023 05:36:57 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id q138-20020a4a3390000000b00565ccb41ba5sm3869491ooq.3.2023.07.14.05.36.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jul 2023 05:36:57 -0700 (PDT) Message-ID: <615b6b61-bf61-30af-865f-fc92aa4f4066@gmail.com> Date: Fri, 14 Jul 2023 09:37:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: ffmpeg-devel@ffmpeg.org References: <9901e2e6-5f42-537a-8478-9d29c4dbd39f@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] Build failure un Debian Testing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/14/2023 7:12 AM, Nicolas George wrote: > James Almer (12023-07-13): >> Curious that they pull git snapshots of this package for Debian testing. For >> others they seem to stick to tagged releases. > > I do not understand what you mean. *I* pulled my work tree to the head > to fix a bug in the OpenGL device, it was the first time since Testing > was unfrozen, and I noticed it fails to build. I mean that for pretty much every other package, Debian Unstable/Testing sticks to tagged releases. But for this one they pull git snapshots every other day. If they did what the do for every other package, they'd have waited until binutils 2.41 was tagged. > >> This definitely sounds like a regression in binutils, so other than >> reporting it upstream, i don't see much more we can do. > > It could also be a case where we have been using a slightly invalid and > unsupported construct. My knowledge of assembly stopped at the 386, so I > cannot tell which one it is, but I think the likeliness are balanced. > Somebody more skilled will look at it, hopefully. I'm not an expert, but i learned a bit of inline asm when i was porting some of it to nasm syntax. > static inline uint32_t NEG_USR32(uint32_t a, int8_t s){ > __asm__ ("shrl %1, %0\n\t" Nothing to say here, it's just shr. > : "+r" (a) r means the first operand, %0, needs to be a register. The + means it's both input and output, meaning the value at the time of entering this block is not to be ignored/discarded, and the value at the time of leaving the block needs to be in a. > : "ic" ((uint8_t)(-s)) i means this operand can be an immediate value, and c means it can also be the rcx/ecx/cx/cl register. According to https://www.felixcloutier.com/x86/sal:sar:shl:shr this is indeed correct. > ); > return a; > } This is most likely a bug in the assembler. The "Error: operand type mismatch for 'shr'" error message makes me think it may be trying to use a register other than CL for the second operand. That said, i don't know if this asm block is needed at all, seeing how the generic C implementation is define NEG_USR32(a,s) (((uint32_t)(a))>>(32-(s))) Which the compiler can surely convert into whatever is most optimized for the target. The BMI2 instruction set added shrx, which accepts any register as second operand, for example. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".