From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0E4A344FD4 for ; Mon, 17 Apr 2023 02:38:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 350BF68BE2A; Mon, 17 Apr 2023 05:38:29 +0300 (EEST) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E165468A23A for ; Mon, 17 Apr 2023 05:38:22 +0300 (EEST) Received: by mail-ot1-f48.google.com with SMTP id w15-20020a056830410f00b006a386a0568dso18888711ott.4 for ; Sun, 16 Apr 2023 19:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681699100; x=1684291100; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L7y8uJF1sJaJrcWQD/JKAE/AvLDeMkZ4PrxjrpI/1J0=; b=MRPcb8WG3uGhJ18BQCA/NR/h3W2FBi4zk/vkt7YtzUqBqi9o7CyO4AZ77n0LYof8XB DCMF3Px6y7UPWjjPm21bisp++iERlyWAfuWqzdR4HE+uANSEoTEul2jde5m7FgoWvuTA 3uf46Yj/NU73BCZNkB/CQ1ee69YU/GQ0WzZq7OI2MfPSINIJiA1aymSmZu+YTkrM8XVZ t186H76/MXgIZC4VFXEongeCdoESScDQStsTKbi/ncTHDSV0rPMTxfDiK7tpQAIdc1kW 1mmS3F0i5N56oyzOvhxWt4MYkXkg2DR4xLVeIMFxE9cH5K3gzP8HN5lPQtuhosvdlK1P s96g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681699100; x=1684291100; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L7y8uJF1sJaJrcWQD/JKAE/AvLDeMkZ4PrxjrpI/1J0=; b=Uioa4JfJ6pSiPCkagujCaUZHZkgPAPUMU5VvzhN942EoXXPkHCJVEKPmtCPIe+bAif 1+UTuFNhgNMMbY/q3L2ohJhyq/P0FBxLY+6TC6rhn2Z+JGqf4PePK4sUxRpmg8fh71YM q0awDIzeSzX+nvVCZ2an6Cuk/z2NkhQDiA0x4R4/6dAX+lvk/hvqZ7eXg0BUAcP53cJP yrK+StHd9Ysr0vTVbRA4QlBLkEK/FPRhBMkLkp+j7d9l6oqRogpEpe4HgKuvzR5WW8Vb kxuyxPeJMfoVyaU6u6tMmxgMJw7YFXFfJhEzNq4Cd/imxKjFPH+AvgeS0kjEwWpDIE9G EPzg== X-Gm-Message-State: AAQBX9f9bB1zO5fSCvQ7w1L9HVzwM+GvUNr443czbUjsk4PFhev+iGbS OubxoDYXtQDoYT9uazl4o/pA44oMIHQ= X-Google-Smtp-Source: AKy350bMG3LPT9EMb2zYXF8PQ9OJgoUKt4eCNP0AxgHnVZ9U5oOm9qddu9ApYw5eUyHupvPIYCcSig== X-Received: by 2002:a9d:6952:0:b0:6a5:e674:c499 with SMTP id p18-20020a9d6952000000b006a5e674c499mr1913855oto.1.1681699100447; Sun, 16 Apr 2023 19:38:20 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id g15-20020a9d6a0f000000b006a3f4c6f138sm1232075otn.36.2023.04.16.19.38.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 19:38:20 -0700 (PDT) Message-ID: <61510d92-41d5-5aab-d3c9-c3c601f69ebf@gmail.com> Date: Sun, 16 Apr 2023 23:38:23 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230417023212.46507-1-jiasheng@iscas.ac.cn> From: James Almer In-Reply-To: <20230417023212.46507-1-jiasheng@iscas.ac.cn> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/rv34: Add check for av_malloc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/16/2023 11:32 PM, Jiasheng Jiang wrote: > Add the check for the return value of the av_malloc in order to avoid > NULL pointer deference. > > Fixes: b86ab38137 ("Add weighted motion compensation for RV40 B-frames") > Signed-off-by: Jiasheng Jiang > --- > libavcodec/rv34.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/rv34.c b/libavcodec/rv34.c > index 45f64666f8..51f18147af 100644 > --- a/libavcodec/rv34.c > +++ b/libavcodec/rv34.c > @@ -1692,6 +1692,8 @@ int ff_rv34_decode_frame(AVCodecContext *avctx, AVFrame *pict, > int i; > > r->tmp_b_block_base = av_malloc(s->linesize * 48); > + if (!r->tmp_b_block_base) > + return AVERROR(ENOMEM); > for (i = 0; i < 2; i++) > r->tmp_b_block_y[i] = r->tmp_b_block_base > + i * 16 * s->linesize; Applied, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".