From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 558514B5DD for ; Tue, 9 Jul 2024 12:41:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8BB9E68DC65; Tue, 9 Jul 2024 15:41:25 +0300 (EEST) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E61FF68D96E for ; Tue, 9 Jul 2024 15:41:18 +0300 (EEST) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a689ad8d1f6so547586266b.2 for ; Tue, 09 Jul 2024 05:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720528878; x=1721133678; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=KwkyHe70oHXhOSOfOSjqMaFttjzfE7IaRE9Z79ZmQ8g=; b=BBRBZmKik3uPmh+XpH0pQYWkhrYtqx0E8x5sJy8cdMvuVxLAh0IXFhr+HnAVBraYyf +R513VPGDdmWXm2UC7ryTych515v73kMh3iQidr7XWgw04P1nATbZZ4ePP3I3903vD/X DoIsHt4dPmErUFAKVqNuc0jCXr1qGxHdKk2y97DKLvq3P9rgM9lHiksIHqTgtLkSnKkP P2N/harNZXanPZkEZH760wETHMewHr0+sbvKPWFsxoyJ582U7OA4+PWYICk71ck9Dpq2 kSSAFeWYtewEymp8/sHfKFlYjpg5TjPmiLokiypzmcsBfyN3cXlarr2Ped59OGtDcXl0 y2TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720528878; x=1721133678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KwkyHe70oHXhOSOfOSjqMaFttjzfE7IaRE9Z79ZmQ8g=; b=IIBOx17Zdv78f69V1PYskLlmhQHua5k3zk5Ot63nPBwI8IiUtqM7152hE7A2Xll/sS eKadCfs6b5y294PMeo+MaTGx1oFXCkrYzexjD/oMsvqN8eQUVGWuagEONgs29QATIUBv pnvCGIk4Ta9oEkF1uEOn4J0updHpDOwZ5HAywLC2FBypPRYNET51+qP62W7iZzg/1qd5 O092US6gaSwIcI/4xUKGDfw4toMCFHgG1Tybwby9tT+lWJIVezLFjn6RGKCJ1/yWbAN8 UmBdSwB+tXCtdd7mKWGdgIOXYXXSTWFdhmY9CkRpe1ri9trKmJxyGlpqn687rFItpZQs c5Og== X-Gm-Message-State: AOJu0YzEZufRSw1G01xe8eQpU3UdBTo/3gQXyI38g6QvVjCEjptKFAQN C3GatQa4LUQamF9JtW9FktBGoDkHLMyD7RTfBC+ZwKkc/z+WSO+cG/3R9g== X-Google-Smtp-Source: AGHT+IHexN3goZ7hGt6C+K1TKt/7JMhBoSGqBFChBXB6TH4Gv7MdizkhElACVrGWEvvrDoqkzCJXVw== X-Received: by 2002:a17:906:378b:b0:a77:dd1c:6270 with SMTP id a640c23a62f3a-a780b688911mr165517466b.5.1720528877998; Tue, 09 Jul 2024 05:41:17 -0700 (PDT) Received: from [192.168.178.30] (p200300cccf0d6b00682dd9db762ca3ee.dip0.t-ipconnect.de. [2003:cc:cf0d:6b00:682d:d9db:762c:a3ee]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-594bda30fabsm1029923a12.93.2024.07.09.05.41.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jul 2024 05:41:17 -0700 (PDT) From: epirat07@gmail.com To: FFmpeg development discussions and patches Date: Tue, 09 Jul 2024 14:41:16 +0200 X-Mailer: MailMate (1.14r6022) Message-ID: <60EF3818-98FC-441B-87D5-4494623799E9@gmail.com> In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavfi/perlin: Fix out of bounds stack buffer write X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6 Jul 2024, at 11:26, Stefano Sabatini wrote: > On date Tuesday 2024-07-02 20:38:00 +0200, Marvin Scholz wrote: >> An incorrect calculation in ff_perlin_init causes a write to the >> stack array at index 256, which is out of bounds. >> >> Fixes: CID1608711 >> --- >> libavfilter/perlin.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavfilter/perlin.c b/libavfilter/perlin.c >> index 09bae7ad33..ffad8c1e4e 100644 >> --- a/libavfilter/perlin.c >> +++ b/libavfilter/perlin.c >> @@ -129,7 +129,7 @@ int ff_perlin_init(FFPerlin *perlin, double period, int octaves, double persiste >> for (i = 0; i < 256; i++) { >> unsigned int random_idx = av_lfg_get(&lfg) % (256-i); >> uint8_t random_val = random_permutations[random_idx]; >> - random_permutations[random_idx] = random_permutations[256-i]; >> + random_permutations[random_idx] = random_permutations[255-i]; >> >> perlin->permutations[i] = perlin->permutations[i+256] = random_val; >> } > > Looks good, thanks. Please push then, I do not have commit access. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".