From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B80B848005 for ; Fri, 8 Dec 2023 08:39:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2647268CFF8; Fri, 8 Dec 2023 10:39:13 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AFAFB68CDF6 for ; Fri, 8 Dec 2023 10:39:05 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 3B88d4Xc022448-3B88d4Xd022448; Fri, 8 Dec 2023 10:39:04 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id DC685A4D0A; Fri, 8 Dec 2023 10:39:04 +0200 (EET) Date: Fri, 8 Dec 2023 10:39:04 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20231208081536.14141-1-klember@redhat.com> Message-ID: <606f7cbb-a8a-4f37-6f62-89bf645fc813@martin.st> References: <20231208081536.14141-1-klember@redhat.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] lavc/libopenh264: Drop openh264 runtime version checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Kalev Lember Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Fri, 8 Dec 2023, Kalev Lember wrote: > This should no longer be an issue with newer openh264 releases and we > can drop the runtime version check and rely on upstream doing the right > thing and bump the library soname if the ABI changes, similar to how > other libraries are consumed in ffmpeg. > > Almost all major distributions now include openh264 and this means there > are more eyes on ABI changes and issues are discovered and reported > quickly. See e.g. https://github.com/cisco/openh264/issues/3564 where an > ABI issue was quickly discovered and fixed. > > Relaxing the check allows downstream distributions to build ffmpeg > against e.g. openh264 2.3.1 and ship an update to ABI-compatible > openh264 2.4.0, without needing to coordinate a lock step update between > ffmpeg and openh264 (which can be difficult if openh264 is distributed > by Cisco and ffmpeg comes from the distro, such as is the case for > Fedora). > > Signed-off-by: Kalev Lember > --- > libavcodec/libopenh264.c | 15 --------------- > libavcodec/libopenh264.h | 2 -- > libavcodec/libopenh264dec.c | 4 ---- > libavcodec/libopenh264enc.c | 4 ---- > 4 files changed, 25 deletions(-) I guess this seems reasonable to me, so LGTM. The version check would be more relevant if we would be dlopening the OpenH264 library (which pretty much is what one has to do in order to take advantage of the patent offer from Cisco), but the libavcodec wrapper doesn't dlopen this library (and doing the dlopen dance for ffmpeg is kind of pointless, there's more of a point to it if individual apps want to integrate OpenH264 directly), so this should indeed be fine. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".