From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9BF204548D for ; Mon, 30 Jan 2023 15:16:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D1DBD68BD64; Mon, 30 Jan 2023 17:16:18 +0200 (EET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A1F068BD4C for ; Mon, 30 Jan 2023 17:16:12 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675091777; x=1706627777; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=eLn1CSsQyfro7W1rWcnDdID2K/cNqBKeYcgeyyFU+r4=; b=AIUSnSE0xmza6vznsQE0K8FIwQtDAOEYU97KZdDmVOhzCbsRSYn2N0cS 2MDpj9eYhgIkcjzSuT31yIMEc7NPPhbVICgrFYHIgjTsVv8zdz1wLm5wb vip5Z8H6O9IXmMnj+UxGBWrnuni6wpFyD6XrBpBrGYmNpaQBe73fWuBAK JZqyuktuWI9TOMeoOXB5EXMjops+xcWG5FjGYdeCoPeDPrLykgmWb6JF4 E3iQKye1j7TwRisdpEClkGj1bsCrzS0pufsSXyGWHzLzfx9mmreDKzV4J ifYmSET1hYWyqVImaoBSoM/K5p13NZH/XONv3RKtKr9h7Tk0alV1QhTLQ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="326246452" X-IronPort-AV: E=Sophos;i="5.97,258,1669104000"; d="scan'208";a="326246452" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 07:15:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="806709874" X-IronPort-AV: E=Sophos;i="5.97,258,1669104000"; d="scan'208";a="806709874" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 30 Jan 2023 07:15:57 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 30 Jan 2023 07:15:57 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 30 Jan 2023 07:15:57 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 30 Jan 2023 07:15:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F+GwEeaFklOrOLnyDO2pxZGrRDBwXgzc//UWqNSCB2E4LPIhwlPUWNinG8xCAJeeZa793mM55+Ga1ZCne9iNlMbsr0qU+bMN4P9VNcC0yTAi67HAbj2hBQ+ereS8AR6UBNYGH8QrJf/NA21GEVEfsU4eYqRthStkrewA4NebQBDU6ERVTYAR1j9F3SjtPaoO6QHqEBsvZBxskD4MdFgZbe7MxNx9Om5FzulyVG1wTDO0K2JFuwkfYrzHSifcU/+hWG2c5T71uD/pP8IgSSahnZNYEP/5pJKNkNsXbRleLn5AvKVoZ3NPdG1r69c39rZoiQmDLPap5TE2h92F7OAg3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eLn1CSsQyfro7W1rWcnDdID2K/cNqBKeYcgeyyFU+r4=; b=RERPH4CxwFGKRe+d3NRZ0GUMdBkI+VefrwB6PKyDRND6ZQ6MlfOMKs7GkVcr4vxxNGxYtgb8aswENg80THsyd54ZQBAn+wN8QNKS88Xfaso+T9Ynhs7r6o19QqCwMpBi26Uq1nVnUt90engZQ8ION+PtJyKfLe8asgl0H+LU5PSjlp0RfOhtnrOjnDxPjqHVuRmN7fClP8lKyzQYxNvWDai54pK5k2CqUVBZw6qeoI9vECgZQdjra6FZb4uwN0UvZakc+H1NKsZZHljuroer4BCo574+0sQWDwSx7gwed7km0tIOdmwmmzhOj91Q/ncxnrj+znouAnPne445CfUBaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN9PR11MB5532.namprd11.prod.outlook.com (2603:10b6:408:105::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 15:15:54 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::36ba:13c8:6a29:c7af]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::36ba:13c8:6a29:c7af%8]) with mapi id 15.20.6043.036; Mon, 30 Jan 2023 15:15:54 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix segfault Thread-Index: AQHZNIBTmAtMlGb6nUCtM5FaW/97pa63EnoA Date: Mon, 30 Jan 2023 15:15:53 +0000 Message-ID: <601087569af7d6b82fe47f82c28dd17b99e7e59f.camel@intel.com> References: <20230130052321.27566-1-haihao.xiang@intel.com> <167506535205.4503.8778082800087432409@lain.khirnov.net> In-Reply-To: <167506535205.4503.8778082800087432409@lain.khirnov.net> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|BN9PR11MB5532:EE_ x-ms-office365-filtering-correlation-id: 9684a34b-a674-4356-c9bd-08db02d4e150 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4tlX3P3LoTO9RyoQoEYD+mtB3V/KxAn1YXpk1qXVpsYP+fY3j1E/nnZ17eZSx02mSKWxVN6k2fOh+hfWX+83/JdUgaqCxHXh2+B32X6c5XXix/gzKal5cr13W4nXd4+2u43kPfzVLNY4NqLJRLuhd3LEoCGnmGe1b0LRQzUVKMmZ2H1wnghNmwMx6zjbuPO2THvdJYVjC+QLorgiWGAPD48peNPR1NZNAPjttA6kutfnW/eASxBQFVTCB5rOn6aZgSOLeQXM5Oiud4Sb6svJGPJasxg8FmELG7Nk4XDoTyAoi+ifTJSp+zsbDtaUKc9Z28N/9CSNPAsEaV+SY1Zaubv5XCX2W0dGcVdLVTdfn3M8OpqgMSN7M18G5NkBtfwwawl38aMgtt6uDLf418D5MUBUyeskeU/bwaUozU7jqbwnQU/w/eiYkfls6g7qnE0O5lxg5dzx9ce6cdem21FzxZrUULhzsw6ULWjUz7a6dLSAbaNheq0qYfg1qZzToeZDmDIu8hu4RsYm6qEoyCntkKSwq1sXY185spxiOtPa9kTy8yKpkXHZKbkF21bpUIayAjiPp7QtT+6c9CO4MwEED7MQ3mbYZVTuDDr3R3McuBqUdSmk20VFVKE9/XjiRlagJmb+gFpiI3Ttk3t6kgJYS2kA5agPebCtKmrxxgJas59B9JF1AOvMH47P6NqCAhniv3NMxhEiGO/dV5ZvWfeOQw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(366004)(136003)(346002)(39860400002)(451199018)(36756003)(316002)(91956017)(66946007)(66476007)(66446008)(8676002)(66556008)(76116006)(64756008)(6916009)(8936002)(5660300002)(122000001)(38100700002)(86362001)(38070700005)(82960400001)(71200400001)(26005)(6506007)(186003)(6512007)(2906002)(6486002)(478600001)(83380400001)(41300700001)(2616005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TTlvTjI5WnZDaktsSzJiZ1NMYTZGYWNZZVN0M0NibVg0YmFXMkpkUHJ5Q2dX?= =?utf-8?B?VUpYeFBJUWNpQ1JGSjJiMndmb0JUWTFyUWdjS1pNTkNtdllVUTJPUzZiNlVY?= =?utf-8?B?SHZGeHEzelhKYnc1b1JWUmhTODNUb0xTSzlhMkpwb1FJeSt5Vit5V0w0ZWtL?= =?utf-8?B?WkdQU0U4Q01SeVppT3ZQcmpOcG1IbC8zYUJkV3NndXFPSWV1aE1KaWNSSUY1?= =?utf-8?B?WnIvN05HNnEvTTA5a0hzSDExVmppMCtRcmFFMTVBR1dBUUtpNE9jZGVKQjUy?= =?utf-8?B?b3Q1UTg4RkppM3JvcDFiK2ZWNVltNFhCUDV2d3Mxdk81OGh5ZC93aFRuVGZ5?= =?utf-8?B?RktCNmo5aFpaWTRva0wvN0FzKzFYT1dVRjBRNEUxZFQ0d1dwMkFKb2FjZklZ?= =?utf-8?B?elB5dUFDMUVmQ085TG1GakFyRGs5RDFVTGduSWEvWERNUWhBa2svaE1QOFdN?= =?utf-8?B?ajRhUC8vODRFd3puVk1NN2RIWnpGY3FIM0xxOVNubDcvay9qNUFsWUdOcWFQ?= =?utf-8?B?NEphSXFwZHNacUtrbDljRU9OWjlPbGtQSmlaNVVZK3NybnhIZEIzSXRyVTIz?= =?utf-8?B?aDJ3RmVOOFduMWFYSWp0OWMySTVjcFhXdHlpR0NRU0plakNhd3RIMHFTSnpT?= =?utf-8?B?d1ZwdkpTQ3hBY1lwK0J3M1prdHJmNzdwdGhnL3BMODJCdUFraytVYkk4bTVy?= =?utf-8?B?b0ZhNkVabzlNUXIrQ3dTa3h6V1lDRC9IUzgrYkRHWUhFM3B0YU91SThvS3Vr?= =?utf-8?B?azk3L0ptNFhGcmdObXFLMW53UUdXNkRaMTY3S2NFQWhPTmgxNXJoWTlteEtF?= =?utf-8?B?d01BSDhCTUttRHRZYTRWRUh6VW5JK0dJbzZlRXJxdXQ5ZW1FOU9qdEtPaDho?= =?utf-8?B?cXFLc3ZIQ3JLNSs0enQ0L2dHdnhDOFBhRlY3Y3NSbjVkck9sYUsyNS9YOEY2?= =?utf-8?B?ejMyaWtRa0VCTGEwRTVyZXZVS2o0SllXVmdLdlRRQmlTS1NxZ1d3bzhZNU5B?= =?utf-8?B?eFhmNnVuMU9aWmw5anFIbjVmZnVzYklJdndhMkRHb2tOTGdGeUl5UXo1UDR2?= =?utf-8?B?U3VZTWZQNks5VDJFeWtTQlh4T1JLeTkwSnQzQWZONGVwVFdxaURtS0U0R3c1?= =?utf-8?B?ZGtpQVJsZk5HUFIwbEt4RWc2T3poZmJack9BTkhRQlNTUUFlVHRVbmpuaFNW?= =?utf-8?B?UUFsamFXdjFXRnRqMTJ6di85cHZpdDJLZHpySzRUK1M1WVJQbG1KcVdoWjF4?= =?utf-8?B?ajBtSngxaVlxamxTTVpKamZNT3p4N0pDK0NtQURkUE8rdHNWVFdTTmJXSUdX?= =?utf-8?B?bTc0cVY1NUcyWDFJMlQveWpFa0I5RXRkSE9HM0x1N1I1ZmtaTXhsNlh0QTFC?= =?utf-8?B?eVB5UW1rZWFyQUxnTDJQRGhRVHBGT25BZmhidlNCZmJaUVNYdGtKa0RxcnRM?= =?utf-8?B?MjRwZHFvTGw5akh2OG4xS3VFbWNmS1RMQ1M0Y0M4c0NoeU9YUmJaNFFveHRT?= =?utf-8?B?YVo5d0VUbDBGRTZOZWhkVkNsYmhuS0JtU2owYnlKRkU0N3AyTXoveFhKUU1h?= =?utf-8?B?N2lPaitvNDA5cktrakg4dGdlSGdXTDRWbysrSzMvUkdnUG5wdEt3ckZGT0RY?= =?utf-8?B?NXlxS3pwSTZ4WXd4NVJDSWpjVjNCakxndW9GbHN2ZFduQ0lxSHJqTkRQRHlI?= =?utf-8?B?akp2YXJTMDVBNytIUjBWRU1xVGRTNWNKQlpmZGp4U25KNktpSmJ3S2lqZXUw?= =?utf-8?B?YUE0c2FOR2FRQk9tdE9JVnB2cUxpRkhxSVpncThVS2NPRzlwbDJRWU42Qmxx?= =?utf-8?B?S1lQVFBGZWphdlhWVURTa3NXUjgzdU56QkhrU0JaNjQ4ZHNPaWc2OUN2N0Zk?= =?utf-8?B?UmNVMFJaTjBySjVIc1V5bkRCSDYvYmxQakRUWks3QjFsRmJncjFIRVVVWnZJ?= =?utf-8?B?NjBqc3dqbXFwM2s3eWl6SGxsYUM4R3Y4RWVTSkNFYmVpaEYwOGFMbXBpd244?= =?utf-8?B?cGFUaFRBS1NtSHVpRUJUYmtXeU4xWDNOL2tFYUowVlBQZmQ0WmxHWEpLdS83?= =?utf-8?B?eXQxMW9Rb3RQb2R4Y2hCdlo1a1FLTzdER3ZOaE45b0JkNHY3WVp4OXBuV2pr?= =?utf-8?B?RCs1ejMrNkpxQTFTTUJISlkvOFcwZ005aDNpUHZUU2pTZHJKVk5XV1NmUDRP?= =?utf-8?B?TVE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9684a34b-a674-4356-c9bd-08db02d4e150 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2023 15:15:53.9391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YrPTaF9O/C7v2f//wfesoj+isEIAWtRxDacKJG/YXmyBmpHXQ2P7U7LbmbrLIvqyjpK+5OTmSgB2J17lWdGCzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5532 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: fix segfault X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Ma, 2023-01-30 at 08:55 +0100, Anton Khirnov wrote: > Quoting Xiang, Haihao (2023-01-30 06:23:21) > > From: Haihao Xiang > > > > This is a regression since commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 > > > > input_image is freed in vaapi_encode_wait() however it is still used in > > commit fbdba9a1a69fe4df413d9e9df1b11db522946e75 > > > > $ ffmpeg -vaapi_device /dev/dri/renderD128 -f lavfi -i testsrc -vf > > "format=nv12,hwupload" -c:v h264_vaapi -f null - > > > > Note input_image will be freed in vaapi_encode_free() now. > > > > Cc: Anton Khirnov > > Signed-off-by: Haihao Xiang > > --- > > libavcodec/vaapi_encode.c | 3 --- > > 1 file changed, 3 deletions(-) > > Thank you, looks good. > > Could swear I tested this, but apparently not :/ There is another issue caused by commit fbdba91, some commands for transcode doesn't work now. E.g. $ ffmpeg -y -init_hw_device vaapi=hw:/dev/dri/renderD128 -hwaccel_output_format vaapi -hwaccel vaapi -i input.mpg -c:v h264_vaapi out.h264 ... [mpeg2video @ 0x55991e9c5540] get_buffer() failed [mpeg2video @ 0x55991e9c5540] get_buffer() failed (-12 (nil)) Error while decoding stream #0:0: Operation not permitted ... User will has to use -extra_hw_frames option to require more hardware frames. E.g. $ ffmpeg -y -init_hw_device vaapi=hw:/dev/dri/renderD128 -hwaccel_output_format vaapi -hwaccel vaapi -extra_hw_frames 8 -i input.mpg -c:v h264_vaapi out.h264 Is this also taken as an regression ? Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".