From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9EF3248072 for ; Thu, 9 Nov 2023 11:47:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3F5DF68CBA6; Thu, 9 Nov 2023 13:47:48 +0200 (EET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 16FE868C283 for ; Thu, 9 Nov 2023 13:47:42 +0200 (EET) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6b44befac59so1516993b3a.0 for ; Thu, 09 Nov 2023 03:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699530459; x=1700135259; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ma2+VyEVh2fYA6nGTV4KXpY0m/RWd1Ph3G4qeH2ipig=; b=kvjndQiJc4BAW9VObW+Gu9/9JJJqFY/Gb3eccQ7krIqd1b3T5iQio3oCifP5ydhbNm 2lqxW72Yt7/njLoiEL0YdbNOmR5BIwHT6s6u00euKoR07EcpLWTjH1Osf+c/Fni6nu88 7zuYzSsn7ABctq0yDoVAHR2FxgnDTgJXyYtAkc1FY77MVbKq4qCjggV0loJw99ChJKaK 4cx4HeqIAdlXI2MKYpdPqLZ4ObrdEdbT3xRtBoCxd/wZugHt66SpSZ6WRUUJ1uBGEluV uOuqEIg4U8db2BJLVdezfo+o5Vv9iqa5+29bX20jS7DPtYxw9s9ryn17i0sHLzgQ1u4d ctmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699530459; x=1700135259; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ma2+VyEVh2fYA6nGTV4KXpY0m/RWd1Ph3G4qeH2ipig=; b=bXiKcxBHlBcbh4hwuogw85Z/eLi9cjreNKUj61E68fRGUuDk6VnGARmQHd5JVLPwFE Zf+z2f88WB2G/Wy4JPGdFWHcX7xFCOTZr6wL2+5e2ZpYT8+9RBLRm/b/k9dd6lET0sRy TNA+sFz9Mtnhfh43H1FWhLAbULHaHlnca+UtYRPqImEw+9aIVL8dKh8fnZwJ2zAMefB+ U3DzHro4qnFDHta3QlJa9lxVpsNtqLcnpDhP8xViRS8CoMYK/OLUgtfp2RgsXot4O1jQ TO2KziyMB6/30Q3zm7q/NHmQxvPwvCArJBTotTgkp6Q6NCpjqaur0Dbq7XaRfRpZCh2s RQ4Q== X-Gm-Message-State: AOJu0YxODym/J+fLoogomaJ65Vkgda9JW1D8BPLwxLrqQQGIN7CQT5Cl sYoKsdii8guFTb56usoRhQ36+kVDE3k= X-Google-Smtp-Source: AGHT+IEa4zlxYBusHpHjpyQUZcQ7w6+vmEJcEPA+ojS3n6jkMnyIfH1mgSAWUM81itV1soyvJtlxBQ== X-Received: by 2002:a05:6a20:daa4:b0:133:1d62:dcbd with SMTP id iy36-20020a056a20daa400b001331d62dcbdmr12284632pzb.28.1699530459351; Thu, 09 Nov 2023 03:47:39 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id x10-20020a63484a000000b0056606274e54sm4481040pgk.31.2023.11.09.03.47.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 03:47:38 -0800 (PST) Message-ID: <5ff31151-4ec7-48ab-9cc8-5cbe81bb4cbd@gmail.com> Date: Thu, 9 Nov 2023 08:47:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20231104092125.10213-1-anton@khirnov.net> <20231104092125.10213-15-anton@khirnov.net> <169953006589.11195.2105026997611442764@lain.khirnov.net> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <169953006589.11195.2105026997611442764@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 14/24] fftools/ffmpeg_mux: move bitstream filtering to the muxer thread X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/9/2023 8:41 AM, Anton Khirnov wrote: > Quoting James Almer (2023-11-04 14:39:44) >> On 11/4/2023 4:56 AM, Anton Khirnov wrote: >>> This will be the appropriate place for it after the rest of transcoding >>> is switched to a threaded architecture. >>> --- >>> fftools/ffmpeg_mux.c | 112 ++++++++++++++++++++++++++----------------- >>> 1 file changed, 67 insertions(+), 45 deletions(-) >>> >>> diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c >>> index 82352b7981..57fb8a8413 100644 >>> --- a/fftools/ffmpeg_mux.c >>> +++ b/fftools/ffmpeg_mux.c >>> @@ -207,6 +207,67 @@ static int sync_queue_process(Muxer *mux, OutputStream *ost, AVPacket *pkt, int >>> return 0; >>> } >>> >>> +/* apply the output bitstream filters */ >>> +static int mux_packet_filter(Muxer *mux, OutputStream *ost, >>> + AVPacket *pkt, int *stream_eof) >>> +{ >>> + MuxStream *ms = ms_from_ost(ost); >>> + const char *err_msg; >>> + int ret = 0; >>> + >>> + if (ms->bsf_ctx) { >>> + int bsf_eof = 0; >>> + >>> + if (pkt) >>> + av_packet_rescale_ts(pkt, pkt->time_base, ms->bsf_ctx->time_base_in); >>> + >>> + ret = av_bsf_send_packet(ms->bsf_ctx, pkt); >>> + if (ret < 0) { >> >> Unrelated to this patch, but this should probably include a comment >> about the reason we're not checking for EAGAIN, like we do for >> avcodec_send_packet(). > > Isn't the situation pretty much the same here - seeing EAGAIN would be a > bug? Yes, and a similar comment here is a good idea as people may use ffmpeg.c as a reference implementation for our APIs. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".