From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6BE9349716 for ; Sun, 18 Feb 2024 12:49:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 29BA268D34C; Sun, 18 Feb 2024 14:49:48 +0200 (EET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B5B268D1D7 for ; Sun, 18 Feb 2024 14:49:42 +0200 (EET) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5d3907ff128so3075937a12.3 for ; Sun, 18 Feb 2024 04:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708260579; x=1708865379; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=fz4pGM4lquO+9rTAgKXL+dA7kCSGIoZ0fJbtAFZyYYM=; b=nAmq+8+hRlEyP6zRD2r3wgogiUhw3wafbrfJdeTY5VciScoq2NEaM8eVnQCMo08Cr2 LOVDm0Gqi1ZXVEbLMUsZ4offqegLa+wgSWE7n+LM1sQlR/DB61YVS1rA2HoeoKM10deM Lvx6jg3GV4YDys60QsZMLi8shqGIucJZbjLJSgqKUyICYV/AFnnrOEaJ6PIZaBWPWV55 hVb4rfVUUgozzvvwBocrxdfOgm4Z7RnSpY/ec380iRtKY6XjZqO7XPCSvwPQu+mqVvlK BUsRlI0MsHpaXKlY91N+CUqy5V5sbBydCazvDhS+e/XU7wPGxPH0lejLB5pEzBJ2ouUj CgIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708260579; x=1708865379; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fz4pGM4lquO+9rTAgKXL+dA7kCSGIoZ0fJbtAFZyYYM=; b=H671yj4wRHXeboLBpNuTiX52OPnluml0qUItpJkKoWDgylEp2M7/4R5RDaokJlj2nu aZJD7pbBiQ5XSsz6HGLi08XDJbN6pd58CJEt+IsAmPyQ+LxH6iwJHgi+PNB8p6D5//Ye xUI+RvQ7v6KaDRVgFR7dk/Y5sH+mAAONRPr4nPEGzMsCKFQViPh2ll2PDiS3nBZSBHNZ 1tpJXJRLhddL2TFfsGrkPcbHO+2EPWcA3vvwk6f3JYs/AX8YxozLqEYDOfAAqmp4vG2t o+z5TcrJU1e2rlfWxYb0wEyOqlXA9NPkSsef7sj2+4QZ9gIWW5Tk8m6eGqP4oalcb8XR iEtA== X-Gm-Message-State: AOJu0Ywwo4Hh7lRrskmjPwm8QjXHi3dhagaxTH2EzzwHixXKc5CIKPpw xvOWbUpNLrKavsJxYoQI/KtP9q5d8LNLD0Q3hE52Z0G53mnXhzPhIxP4v9gb X-Google-Smtp-Source: AGHT+IEp9o1IB4BX1/0cbTqFLeLK3iTjuR/xJtRt7maFX7vsnBoBp3H+UT7IdDD5l6DxeQPpaAckNw== X-Received: by 2002:a17:902:e744:b0:1d9:c367:201b with SMTP id p4-20020a170902e74400b001d9c367201bmr13238259plf.29.1708260579117; Sun, 18 Feb 2024 04:49:39 -0800 (PST) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id c24-20020a170902d91800b001db68d6c4d7sm2627637plz.287.2024.02.18.04.49.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Feb 2024 04:49:38 -0800 (PST) Message-ID: <5fa600da-3af2-488a-bd4f-9a6f630c7ab3@gmail.com> Date: Sun, 18 Feb 2024 09:49:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240218104534.17743-1-cus@passwd.hu> Content-Language: en-US From: James Almer In-Reply-To: <20240218104534.17743-1-cus@passwd.hu> Subject: Re: [FFmpeg-devel] [PATCH] fate: use an even more exotic channel layout mov-mp4-pcm-float test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/18/2024 7:45 AM, Marton Balint wrote: > The old layout happened to be a native layout and therefore missed some > recently fixed layout parsing bugs. > > Signed-off-by: Marton Balint > --- > tests/fate/mov.mak | 2 +- > tests/ref/fate/mov-mp4-pcm-float | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak > index 4850c8aa94..8d154c8b5b 100644 > --- a/tests/fate/mov.mak > +++ b/tests/fate/mov.mak > @@ -187,7 +187,7 @@ fate-mov-mp4-pcm: CMD = transcode wav $(TARGET_PATH)/tests/data/asynth-44100-1.w > FATE_MOV_FFMPEG-$(call TRANSCODE, PCM_S16LE, MOV, WAV_DEMUXER PAN_FILTER) \ > += fate-mov-mp4-pcm-float > fate-mov-mp4-pcm-float: tests/data/asynth-44100-1.wav > -fate-mov-mp4-pcm-float: CMD = transcode wav $(TARGET_PATH)/tests/data/asynth-44100-1.wav mp4 "-af aresample,pan=FL+LFE+BR|c0=c0|c1=c0|c2=c0 -c:a pcm_f32le" "-map 0 -c copy -frames:a 0" > +fate-mov-mp4-pcm-float: CMD = transcode wav $(TARGET_PATH)/tests/data/asynth-44100-1.wav mp4 "-af aresample,pan=FR+FL+FR|c0=c0|c1=c0|c2=c0 -c:a pcm_f32le" "-map 0 -c copy -frames:a 0" Wouldn't FR+FL+LFE be enough to test this? While also generating a file that's realistic. > > fate-mov-pcm-remux: tests/data/asynth-44100-1.wav > fate-mov-pcm-remux: CMD = md5 -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -map 0 -c copy -fflags +bitexact -f mp4 > diff --git a/tests/ref/fate/mov-mp4-pcm-float b/tests/ref/fate/mov-mp4-pcm-float > index 851b79090c..7da8fd2aba 100644 > --- a/tests/ref/fate/mov-mp4-pcm-float > +++ b/tests/ref/fate/mov-mp4-pcm-float > @@ -1,7 +1,7 @@ > -691a76a847e0f3720c09cca341971f19 *tests/data/fate/mov-mp4-pcm-float.mp4 > +7b998e652d5b7154e646a98bd2bf28a1 *tests/data/fate/mov-mp4-pcm-float.mp4 > 3175929 tests/data/fate/mov-mp4-pcm-float.mp4 > #tb 0: 1/44100 > #media_type 0: audio > #codec_id 0: pcm_f32le > #sample_rate 0: 44100 > -#channel_layout_name 0: 3 channels (FL+LFE+BR) > +#channel_layout_name 0: 3 channels (FR+FL+FR) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".