From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 75D8D43732 for ; Wed, 27 Jul 2022 09:46:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 122DD68B9B7; Wed, 27 Jul 2022 12:46:27 +0300 (EEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E552368B964 for ; Wed, 27 Jul 2022 12:46:19 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658915185; x=1690451185; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=eA0pT25hgcHB0g7FDVtjaHR1ba+otq3VHRjW2qjcc4g=; b=fgnJHT0o18vfa9IxZndKOEm6FdaWTcuuC31dPMJ5bwSCzLVm5uG+wmOG JH1tZoBjLpxgVmKIBvQ7BssXr22Y4whRoyynwuefoNLHXir6K5rq0fm1R rrC8S6E7rh9+PSemvmxHCHh21frJP+OrDGIZB+Qru8g4aXhTyUEehumMU AvGtploqtFay7Gr2/J3oXnu2cHRTuXg7MQ/s9ItXPjvuizxYHziE3AYf2 1MCpAe62LNSEpi59gNlHZz8uYLqZddaRZ0vycW9B1Qrpqt0v5YEn6xCMy 55BOwZkZmgxgnxGl8ivoTa4FEGjUsli/i+iDcxIa+iKNqe9D1GP8PJo8m Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10420"; a="288910744" X-IronPort-AV: E=Sophos;i="5.93,195,1654585200"; d="scan'208";a="288910744" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 22:35:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,195,1654585200"; d="scan'208";a="689742031" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2022 22:35:54 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 26 Jul 2022 22:35:54 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 26 Jul 2022 22:35:53 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 26 Jul 2022 22:35:53 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Tue, 26 Jul 2022 22:35:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LUL4k3u4cXoqrK/Lz8gxkkRziaJTcrMdvGBk2/8E+ZNVSUAIb+rFjswpJUNQa9RSgHNB/g6BgWdys+sfvy00vSW9frBUxvQzEEoC8xyhP6qd2VrDsQRJ8OlRRj9r/ZRkr1VxdIIL3iUibV5Y8G/ayl5ZlZkL6iq1z4eIIuxn25UxsIpEx68taMJdEQRqbxDNvsR9aeodmC+8G3ykzJION4hd+bSjkQV6yPP4xtpu9NOH8k5DQ6TftnZa9K18JHD86/DW/PbnCO6slwwPaKmCJGciTftG66BPitEcZyQqagxjbkP/dAgEWXjSVX5D8XGoAK5Sl8gBXoxAmsfPp9KnNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eA0pT25hgcHB0g7FDVtjaHR1ba+otq3VHRjW2qjcc4g=; b=DJU+eV2UqeSoxUZ6cng1vL+51knqWaeIi2rAVZMvEMVgumHpTNaVR8yWmNe/3xXyF0UnQZ2fJQY6vdTJEqqB0ml1/m2dKEpBZ3inkySyzgzp8tXPKkPJnrcKa6blNCv61GTtY7rkTiN/EOfcXc0Gn0/5zY5g99PGu3V+gE1i/OnujokereKTRGGxw7hi4HTCuDea6xyfTgVLWOGGAP5SIFpzgnDV9IhX1u1ur/EkUBP6W0jCeaeT1ZLMN5ZhPM+hRUgacGmZ6uQ4uA26BwglbMogR9wrDgk4E9OZ5lc8El5oC0V648MJ4lR+U8RFVR1IGxLI5C5aeDfEe5daS3NfXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MN2PR11MB3902.namprd11.prod.outlook.com (2603:10b6:208:150::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Wed, 27 Jul 2022 05:35:52 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 05:35:52 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v3 1/4] lavc/hevc_refs: fix dpb logical for IRAP Thread-Index: AQHYmAj1tnPPduKrdU+BYVl4nKy9R62D3BCAgArA0oCAAyiBAA== Date: Wed, 27 Jul 2022 05:35:51 +0000 Message-ID: <5f70eb72c97b5dc1a09949bcf74841b00df7c007.camel@intel.com> References: <20220715050644.879488-1-fei.w.wang@intel.com> <8020b05e3e101471d4c307552ade97b4594243cc.camel@intel.com> In-Reply-To: <8020b05e3e101471d4c307552ade97b4594243cc.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a355e6bf-dbfd-41ff-914a-08da6f91de80 x-ms-traffictypediagnostic: MN2PR11MB3902:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 192CXWakQvMuwbNUa1IC015YWZLEyhAx3cATDoC4wPQw7hF3REy4ktR+Fd4tkGZH3kMnHsqqvKXnW6gxbp/ONrJzgxnBv4B8AWMGByUdyzUZrE/MU6rR51sfXP5RS5pxR7QonWBBMVbVS3nxGN825p0zu7C33kkjgvQlmaCrZkNydmPOyBv4xkb09fNPofKMiabUFXgLsfh5ucUZZm7N/VdthJIk37Mr5BMVFl/grLItmwxAsXpww+AGbJ5AH+j+9qphgPprqJBJlAVFRzwN+szWYVpeWTg4o/yR8LzGkV4io4swuEv76WaDbckiKeY4dwPamVHlJsmSsNKSMB8XenWINefrGxi2fRxOwCzgJ/Gto6VZElb3vWkeGEWvO+UoTuQJpwb2TjK81lJwdaZybCMWXlxOBUIHr1u+tSrxVZ9M7BFQiMM0/UNf+XmIY7DmLGVpBtLcPcjJPjwIq6tDIwPtYvtbIsgFgEJZ4ZM0bGkW76AvlCXKmKIksy14YNYnqrJts2ZeO3o26M7eTUUmbdvQKouVtzfbExVL+IWndLasMJ/Wk+IVDArGzlowHlB5bD2W/86yGWKwWzxItZR46ejA31pIPu/onaJ28WCmCx+4pNePSrXSvFXx7BegnzYAvCf6YBRTWJt5+9nq/HY8LGXzeQov4j3fN/XZRrlmh8tlre0W4tHfccNl2gSyQWjz8jC6GuBpsC/F18gZOJktOICc7mz9TnI7ZGlG3oJzJHYUbdQrqx4qMRVg4HpBjxonBu7wMl8aoKp06/KCjYGHdll5+V/o1FczLR4zfqHa/2+4W3dyIVq+bnLoa/B6vkMXRG3B/BQhVPf4Mm5GKGxbLw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(376002)(396003)(136003)(346002)(39860400002)(36756003)(38070700005)(82960400001)(122000001)(71200400001)(64756008)(66446008)(86362001)(8936002)(8676002)(76116006)(66556008)(66476007)(66946007)(6486002)(5660300002)(4326008)(478600001)(316002)(38100700002)(54906003)(107886003)(6916009)(91956017)(186003)(83380400001)(2616005)(6512007)(26005)(6506007)(41300700001)(2906002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L0RsbGxuYlJoVDhMdUFzdWVtNnZDQk1wdzRLL2EvTVFiNVVLRXhpeE0xTVpx?= =?utf-8?B?Nk42U3IrU2hwekJJYlFGMWUrSnhRQXd3VlExaldFdDRUMDJZSWoyOTlXK2tC?= =?utf-8?B?Q0R3eVlZMVFBMEsvUW43aERQSkI0dFpPZDlaZ1dSY29ZS2Y3LytFMktKbTdv?= =?utf-8?B?RG1NY3ZsbVczRVBwTXNDSjNSUDNhVFRuOFl6aFNuclZOb29nTW1sOVA0WE1Y?= =?utf-8?B?T1FxdHovVk5uVnZtNVlQMFptR0h3dUFmOGJUckc0RitFaVdYV3dzVWpyaG1O?= =?utf-8?B?Ynl3dHVvUDNzM0ZrYXdvT05yU3V4U2ZycFFEQW5uRFhvUVB0OEFpWW1sVVpH?= =?utf-8?B?SWdRbnE4c1RHOWdLRGpjNEVtN2x0Y2U4ZTd2OHQyZUIvOG5iMTh2TjR1N01n?= =?utf-8?B?U1RGTEFPTm8vSkhIS2VkSGJYb2lWL01kQXVybk5QOUVCZUlSUGc5Q21OU2ly?= =?utf-8?B?MUd1M3BPOTg1M2ZWaTNEcDB4QVkxUldkbi94dWtGUnZUcEFKS1VHSk5VQzJs?= =?utf-8?B?bUtDT0ltS2JMeGsrL0d5eldIcGREMXE2VWNpMVdUN2FEcEkzQWZyM1ZCTXdx?= =?utf-8?B?NXl1VnlPUzdId1dpZ1JJQW85NEFLak8wNmNGU3piT1RrcExURnRnQS9iQmtp?= =?utf-8?B?Z1p1L2d3cm1sRkF1c2Y5cU5aTVhidDNwbkZkQ1ppMVlteEE1WVI3R1YyWGMy?= =?utf-8?B?TjUwNmFxUUEzWklITk9ucjRSQ3pjVjh2ZFdsdVhkaEdTL09kRmc2TXorcW9T?= =?utf-8?B?eUtTQXAxZGE4TFJaMlZvTFplVE1sSncvd1NpWHJlR0dOT2hLSUxpZk92R0U3?= =?utf-8?B?SUI5WmtQSWVlOGZ1T1hjbnNQYURoTlArLzk4ZUF5Q0J3bTRLbktLRmpINHp2?= =?utf-8?B?K1pzdzRyR2VVY3hnekFuaW1SbEFlb055dEluU0ZiUTJHZ2tsV0dTcDZXUDkw?= =?utf-8?B?dHFrUDczdW8zOWVHSnJwNkdYMFRHRmdvWml2SmdJdld5WDc4Q3lqVzVGMEhs?= =?utf-8?B?dFZValdRRm5FOGFYYzZDZ2V5OVp6U25Ec0d1bllnMkZwSWViYTF6ZFBBRGx5?= =?utf-8?B?NW0yVVlaelg2Zy9uLyt6a3ZDYkJQZ3FLY1RUVUtlSHdkUkYxU0pnTDJzUW8y?= =?utf-8?B?S1RZWmhmQ1V4YlFkOXdvd3ZqeVdQS2JVeVBPcDZXNytRcWVRcmo4SU5CM0ov?= =?utf-8?B?Q1JKTW5wMFIvM3g3Q0hGVjhhYXlHWVN2UFNhZE1KRXVGTjRSSjdTTzlMYktV?= =?utf-8?B?bGdnbU9ZaE44MjN1MkhFamNES29XNy8vTWx6SHorejdtWXlDWERRUFo5cUZN?= =?utf-8?B?SFM4aUFCd2Q0UlBOWVZIaks5Y0RVNnQzMktCSGQyU1J4Q0FBUXZMQTBpL3Zl?= =?utf-8?B?V0FIdmx5VlhpUE16RUlYL0wvNXkyTThFb1hLTjVDZk1nWUdkek1FbXNRbU9V?= =?utf-8?B?TS96QjdhbWEwNllvT1UvUVFXOE16ZVc3ekpYZVhqSWprdkpmbXMvbGhGQ2Vt?= =?utf-8?B?VDNWK29QNUNFdjZWMmxtcmtWU2VBVlQ0bVpIZUI1N1pPTlA2YUdPZVBmb1kr?= =?utf-8?B?d09PNXJtZkJKUG1sTnhyVXR6aUk1NHVoQzRvTkNvd29qYTMxT05aSllrZ0ZK?= =?utf-8?B?V1RRQkd2Qi9GMXB1S1E5WS9UK3dhRFUxeW1KYzdxNURaK25mRWI3eEJlSStB?= =?utf-8?B?bDJqZERrK1VzV0pGUnVGVXp3a2kvT2lhOURYWkZ5blc0a0xKOHRzYXhreGxZ?= =?utf-8?B?R2VVZ00yNWhzcXhDck1nVDd1R0wrcy9DcTVyQXhDOEtOOUZjSnl3Z0pIbjI3?= =?utf-8?B?Zi9Lby9CcUx0aVA0cVlmUmdyZklKUW1kZjdoUUtXZFdYZ3RuY1M2aFpwaHRa?= =?utf-8?B?UzdpTnlBVVpEQzVWU01OVS9wTHA3WnVqdGl1eWozRUlBQ0ViMEUxd2JXOENv?= =?utf-8?B?djZpTFFMK3dvZ1Y1TEFQVWtoaVhoZXA4S0lHNlh3QmE0R1czMm1FMFEvOVgy?= =?utf-8?B?cS92c3drMkpqZmVGMFM3WW5Gc3grWmtwenlEckZ1SklLZDBMd3RzbnZhZlRG?= =?utf-8?B?WUVjR29BbjBaS01pZHBVL0hBNmxhSE5BVHArSUcydXhOOXRvOEhucUhzTVNy?= =?utf-8?B?cVN6cGp5NjlmME9yUW5PclliaXFKazlYN1czVHo4Qkc4N0xTc0JBa3VRYTYw?= =?utf-8?B?alE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a355e6bf-dbfd-41ff-914a-08da6f91de80 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 05:35:51.9630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Nq91rKNXrH5vfQDQ92jhDTrSi4FXfxiyzTWEa0gG1DMbFsvlfMtggt1k5YglnHmLSMKm6ocZGsln17oEkv7HEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3902 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3 1/4] lavc/hevc_refs: fix dpb logical for IRAP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Xu, Guangxin" , "Wang, Fei W" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-07-25 at 05:22 +0000, Xiang, Haihao wrote: > On Mon, 2022-07-18 at 09:09 +0000, Xiang, Haihao wrote: > > On Fri, 2022-07-15 at 13:06 +0800, Fei Wang wrote: > > > From: Xu Guangxin > > > > > > According to C.5.2.2, item 2. When we got an IRAP, and the > > > NoOutputOfPriorPicsFlag = 0, we need bump all outputable frames. > > > > > > Tested-by: Fei Wang > > > Signed-off-by: Xu Guangxin > > > --- > > > update: > > > 1. clean and replace 0xff with HEVC_SEQUENCE_COUNTER_MASK > > > > > > libavcodec/hevc_refs.c | 23 +++++++++++++---------- > > > 1 file changed, 13 insertions(+), 10 deletions(-) > > > > > > diff --git a/libavcodec/hevc_refs.c b/libavcodec/hevc_refs.c > > > index 6a70c817b0..2b0468d6c4 100644 > > > --- a/libavcodec/hevc_refs.c > > > +++ b/libavcodec/hevc_refs.c > > > @@ -175,21 +175,24 @@ int ff_hevc_set_new_ref(HEVCContext *s, AVFrame > > > **frame, > > > int poc) > > > > > > int ff_hevc_output_frame(HEVCContext *s, AVFrame *out, int flush) > > > { > > > + if (IS_IRAP(s) && s->no_rasl_output_flag == 1) { > > > + const static int mask = HEVC_FRAME_FLAG_BUMPING | > > > HEVC_FRAME_FLAG_OUTPUT; > > > + for (int i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > > > + HEVCFrame *frame = &s->DPB[i]; > > > + if ((frame->flags & mask) == HEVC_FRAME_FLAG_OUTPUT && > > > + frame->sequence != s->seq_decode) { > > > + if (s->sh.no_output_of_prior_pics_flag == 1) > > > + ff_hevc_unref_frame(s, frame, > > > HEVC_FRAME_FLAG_OUTPUT); > > > + else > > > + frame->flags |= HEVC_FRAME_FLAG_BUMPING; > > > + } > > > + } > > > + } > > > do { > > > int nb_output = 0; > > > int min_poc = INT_MAX; > > > int i, min_idx, ret; > > > > > > - if (s->sh.no_output_of_prior_pics_flag == 1 && s- > > > > no_rasl_output_flag > > > > > > == 1) { > > > - for (i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > > > - HEVCFrame *frame = &s->DPB[i]; > > > - if (!(frame->flags & HEVC_FRAME_FLAG_BUMPING) && frame- > > > >poc > > > != s->poc && > > > - frame->sequence == s->seq_output) { > > > - ff_hevc_unref_frame(s, frame, > > > HEVC_FRAME_FLAG_OUTPUT); > > > - } > > > - } > > > - } > > > - > > > for (i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > > > HEVCFrame *frame = &s->DPB[i]; > > > if ((frame->flags & HEVC_FRAME_FLAG_OUTPUT) && > > > > Patchset LGTM. > > > > The patchset works well for me. Are there any more comments here ? If not, > I'll > apply this patchset in a few days. > Applied, thx -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".