From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0D986428DD for ; Sun, 5 Jun 2022 12:18:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1EC2F68B656; Sun, 5 Jun 2022 15:18:29 +0300 (EEST) Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D325068B5B3 for ; Sun, 5 Jun 2022 15:18:21 +0300 (EEST) Received: by mail-oi1-f180.google.com with SMTP id i66so16331201oia.11 for ; Sun, 05 Jun 2022 05:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:references:in-reply-to:content-transfer-encoding; bh=LRdBHRaEBX7wyhKfXCHWEnCgkAcG3UchPi5gsTE5UWM=; b=Xwkyyak2galC+/Fy7mwnF7BvtRdnel21LyBnamCZwEIbaVR6GK0L2BiUPXPCHpOeXp puqiyvMzbG7qx/8ZonLnfGIFTvHn3MKBWySCELQCRNudy8flRqryEkyEIoBdn24qYbxX 7nafEEQgxRP+xop4NDE+EFZosKNoXryuBQfcz9T1JbTZEDBUF6FcyiQmSkOXvU/snOIX iIfF2b6/ZF0zy2VQeOmDqlMksML4UH1w7NzSs2xF1nax/duOLLM2Lu9uqr81xubNQpPm jBuSY8Y1klDV5xuDEKxuMmJJ5lSJUSuuQyN7I39obS60UKIkpRArkX9NJZnN5+p7UGbs +OOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=LRdBHRaEBX7wyhKfXCHWEnCgkAcG3UchPi5gsTE5UWM=; b=aCStsk9n2h++YcCXkZHCZwhM6Wp/p3txNzXwWbiKo/8oTSJuDLm/PkFp8rdfZHORf2 TPGT+k+5lMiDytpubpEy//VM/FN3XIZnRONcN0kFSEJmGwCHNpUydM2r9qDCZfOoQa8z IanH4VGimOCYax4z0264e5mXr7eUpOhU97NrpOT6w32Z+6PpdFbfxQi2Q6qxuhwCszJY JM+zbiPp/YB1MUZ6u+i+ChIpZUfGDr5pu9w9g3TrjSX4TJCKtxuQzj38RopP2uvH1KUG 8yO0RFmRJdzEJBndcbcYHa7Y5dV8pRWkebwLOJFbooX0wpgJfV/MhOFYjodUOiD9tjLS l7bg== X-Gm-Message-State: AOAM532gpOvrqB2uub2gR7rcwUG4WdM05Hp5kWYIAr7PSI5kLRaecrxi YBhtApuJ3mkbrXPw/684L4eUAGj3iK4= X-Google-Smtp-Source: ABdhPJzokpUlhU9mpgZ8Vz9JTr+ikBOO4LIfraMD9W0giVgMf+EcFHS9HZ0zNvtBSPOPfVrT5YZlWw== X-Received: by 2002:a05:6808:1b12:b0:32e:6ccd:3ffa with SMTP id bx18-20020a0568081b1200b0032e6ccd3ffamr4173576oib.121.1654431499547; Sun, 05 Jun 2022 05:18:19 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.204]) by smtp.gmail.com with ESMTPSA id kw38-20020a056870ac2600b000f32c6b6871sm5876802oab.10.2022.06.05.05.18.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jun 2022 05:18:19 -0700 (PDT) Message-ID: <5f2ec80f-25c1-e5a9-8d49-4d4f07eebc02@gmail.com> Date: Sun, 5 Jun 2022 09:18:18 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20220525225200.65113-1-jamrial@gmail.com> In-Reply-To: <20220525225200.65113-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/remove_extradata_bsf: add a list of supported codec ids X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/25/2022 7:52 PM, James Almer wrote: > There's no point allowing the use of this filter for codecs where > it will silently do nothing. > > Signed-off-by: James Almer > --- > libavcodec/remove_extradata_bsf.c | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/remove_extradata_bsf.c b/libavcodec/remove_extradata_bsf.c > index 66b7d00bd8..584213e40f 100644 > --- a/libavcodec/remove_extradata_bsf.c > +++ b/libavcodec/remove_extradata_bsf.c > @@ -18,6 +18,7 @@ > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > */ > > +#include "libavutil/avassert.h" > #include "libavutil/log.h" > #include "libavutil/opt.h" > > @@ -217,7 +218,7 @@ static int remove_extradata(AVBSFContext *ctx, AVPacket *pkt) > i = vc1_split(pkt->data, pkt->size); > break; > default: > - i = 0; > + av_assert0(0); > } > > pkt->data += i; > @@ -238,6 +239,20 @@ static const AVOption options[] = { > { NULL }, > }; > > +static const enum AVCodecID codec_ids[] = { > + AV_CODEC_ID_AV1, > + AV_CODEC_ID_AVS2, > + AV_CODEC_ID_AVS3, > + AV_CODEC_ID_CAVS, > + AV_CODEC_ID_H264, > + AV_CODEC_ID_HEVC, > + AV_CODEC_ID_MPEG1VIDEO, > + AV_CODEC_ID_MPEG2VIDEO, > + AV_CODEC_ID_MPEG4, > + AV_CODEC_ID_VC1, > + AV_CODEC_ID_NONE, > +}; > + > static const AVClass remove_extradata_class = { > .class_name = "remove_extradata", > .item_name = av_default_item_name, > @@ -247,6 +262,7 @@ static const AVClass remove_extradata_class = { > > const FFBitStreamFilter ff_remove_extradata_bsf = { > .p.name = "remove_extra", > + .p.codec_ids = codec_ids, > .p.priv_class = &remove_extradata_class, > .priv_data_size = sizeof(RemoveExtradataContext), > .filter = remove_extradata, Will apply. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".