From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7196243CFB for ; Wed, 7 Sep 2022 08:47:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CDDEF68BB46; Wed, 7 Sep 2022 11:47:28 +0300 (EEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 94BA968BB45 for ; Wed, 7 Sep 2022 11:47:22 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662540447; x=1694076447; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=VJ8q1fxD50PkU/6+oz5ZJSVmRIp/TThXiJ09L+Oxt0I=; b=PcdAYeOD1dPEez3/Q5aE4Ptp3Lo4wiz6WBDdBtlumiYJVNeUuboxZGl/ G1Lk+8Y+1TN7rXkxKs1OhQpGzFtjwerAiatLP7D4dZtOdxO3DcxKgHc5f eQPLR9w0IGGFNLVW2IqSW3+X/8C0gmfFOg5V0UySoOMNX6lOg8RbUgWmy lMUNxNywqf4ScBCicg3HytOxV0Kx2/fWVS11nN5NhG+WoY3OhBoPWihaK cSOX2RKRIWo+zyyP0PA2Y58+4yw1LteIVZI/gxBA/BvBYM8XeGbGOstip yNTfQRsvAmW7a9XMgpI7HJhm0w4rmzcFvxGY1MAY2omp/NCSsxaa/h/I+ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="276558113" X-IronPort-AV: E=Sophos;i="5.93,296,1654585200"; d="scan'208";a="276558113" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 01:47:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,296,1654585200"; d="scan'208";a="859565366" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 07 Sep 2022 01:47:19 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 7 Sep 2022 01:47:19 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 7 Sep 2022 01:47:18 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 7 Sep 2022 01:47:18 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 7 Sep 2022 01:47:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWmNCNpqiJNfT1EDoGzHplpKd3JbzJSQ5QL4GTAIMPyksXPgrenXUQi+rbO1RRnIYMY9pcVrRDLakary86aRCBZS47QEvr/pLfZJhs9sKBViWeo6nEvxk51pd9WpkvFU/NnrBjXBxBmpIdRl9CKxMUQva1/lQ/KJVVToBcJ7SeErhSyYQaZOSMEIOjZH+bIZO04DmHdqP/QW7/nrwCQ06pBcxbDvvO8begMyWVlWKDN0jotrcDJXPthKGR30PA1hJcjOvTOak1SJkZUH8/Ce/AzQKRWL0mVapsGoXu4LyBMX9swz9elD/FG+H6J9aDrCHiGLXLhYLcwxWEaDoH53yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VJ8q1fxD50PkU/6+oz5ZJSVmRIp/TThXiJ09L+Oxt0I=; b=AsYnN4ZLOH5PvLuuBLqh8NNDIZZFPQ9QqDXRszMQJIEocJOk7vYmMUUs7suH8xliRMgXQKpaBjFyrISGKn4NyckG1el3DjaAq1lDYfm0sjv5gD6YYrFhytAHUfjHzp5Ppz+HpXoRgx1OQ1+XetL9wqn7zSlhHbBs1gbmmKd89fIrb7uqUKNSCmDvGerBHnCd+JyH1yliSHPvO6p8bUpMFuKeD8JNLmGrCZyjRCj/XtesEHXpJh9PBiT0foyqulbEzFVDQo5cBbsYB66baNU/0f+7sZqp8oq5QboYM/x5lasgMka+dkpJ9sSqGfWhx+fj25702VxGiKoc9700GrECYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by CH0PR11MB5377.namprd11.prod.outlook.com (2603:10b6:610:b8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 08:47:17 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5588.012; Wed, 7 Sep 2022 08:47:16 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v3 1/3] lavc/decode: Warp get_hw_config function Thread-Index: AQHYvNfrugJqolC0E0yQ6dGZ75Ayu63TsygA Date: Wed, 7 Sep 2022 08:47:16 +0000 Message-ID: <5f17aad9fd5084dc2f4618e22c6e2346e6347933.camel@intel.com> References: <20220823081929.413947-1-fei.w.wang@intel.com> <7f8cdfa93aac92c3ef889548c2540cf74033cc3b.camel@intel.com> In-Reply-To: <7f8cdfa93aac92c3ef889548c2540cf74033cc3b.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8fde9808-498a-49b7-9a0e-08da90ad9140 x-ms-traffictypediagnostic: CH0PR11MB5377:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3EqxitBNmFEiPpWh3h3jO1xHqycMhR7pVRBP7erCXi8w7CyKKK5EW9ANQh6gpsDVEVhheJChqha6Czb+boGpieVVpLamsYWxB+bipC2n+hojo94W1chN3ftDDnAE46p8rCAnIk494nu4LCkY78xFFjMjiFbV2Tg64zlo9MHmdg5HHEdJSczIDWezxoh7nLFRbPxqdDwc9t+sw7n05VRn/OFFc0f1SN+M+f+4NCPZbwHpRes/YvPMzXKhzzAtJYMoAa8S0ls/Sk+rCUbn6n4aV4IJC5Mb4MGZo8iD13IcIBj0wRaVbRuMJZSjoqh7aZrIEyF3NU8ediUIy4qFYvzzYQ8SbUKrUTL9kzPuYlo+DqWwhcfopGAXumfYJwpKEb8GesUtVutQK+7PlPNqddduGUkVoLHjsKYe4H+NMergckUViqqcUuJIfOk4oL9YkEq+szjnag/rhjF6/Wib7rM9W7qdL320rkUSp1XD7kwiysL/oWXul64cI1wL6dZc1d9E2VTxd7junQh3NrBKG7WAJmdh8gkZlCyB+IqV5sKfPEgrkCLA9Ae9dZSjIq63utUJoPKIf8u2DtWI9SWkU2rr//M1W4dIC5c9Z0Jcllc+hPiaO8ASyR16PSLDNIIhD1kESLpOCSANhFJi2QCzbPekMICLVTVxRCh7fhlRb1fKukJqk5LZ7rCjNWZUHU05zjRQlolQvZsHw+SgISNl3n7OL5cZmO1aO1LF3obdJHIQV8m5KsKfqNZJK0Zzz5VneCzH55QW6QUHPU6J5lgdOKUYUK065/SffLOg77a5HTR/Puw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(396003)(366004)(136003)(346002)(39860400002)(64756008)(6512007)(71200400001)(6506007)(6916009)(6486002)(38070700005)(8676002)(316002)(41300700001)(66946007)(66476007)(66556008)(26005)(86362001)(82960400001)(66446008)(107886003)(478600001)(38100700002)(36756003)(8936002)(2906002)(83380400001)(2616005)(186003)(122000001)(4326008)(91956017)(76116006)(5660300002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c0dmYldoZXJQS0JNZm11WTNHUXBJMnN0L2ZoRXJLVjdiMXpITkg0TXNlSmxQ?= =?utf-8?B?QlBHcStCbkxDcHhjMUF1MEV3N3FQak02SGwvQnY5NVU5Z21zaDV3RFdxWnZR?= =?utf-8?B?TkphME5KcW9jWlpBOUhtNXNKcGxsRHdneG5lc1FpSW9pY3VSaU0wQjM5YzZW?= =?utf-8?B?Q0x0K0FpOVRuUFNxZGdQek5DTEtrbTc3R1RzSlJNQ2crc3haK3JGVVBMcWJD?= =?utf-8?B?aEhpM3Bmcmd1U3I5cnB0U0FYVHh3V2V1RmhZdGd4ZURKQ1BOaVFqWDg0d1Bp?= =?utf-8?B?S09GTGJrQS8rekFGYWV1dGc2YWJvVmFCdGtwTys5MXVsKzEwbVhjclVvWk1t?= =?utf-8?B?Zm1TemxMQTZPTG5Ed2IwQ1RCdkV5dWIrVVNJbWpyeFFRVkMwVzZJVzdGUDNJ?= =?utf-8?B?VXQwWXVmVThNYjJQWHY5cGNpWmw0akdiWG5GV0pOeGwwVDI3NFBNRnZXS3cz?= =?utf-8?B?aVdENUlhWFltQjhMQVhPUmI1WUZnMXgzV0tZTnE0UHNTTHhoYTRjeUlsLzNC?= =?utf-8?B?aEtsb1JMSFNLNysxdmFsRGJ1eFlDZGpteFZTb3k4UDhPa3dHL1A1YlNFdjBq?= =?utf-8?B?dXhheXQyZitGSVB2Nm5UM0hFeVozRzhTSTd1MGNIM0pSM3V5cGNiZnFYc3hw?= =?utf-8?B?d3c4eWdCejR2a3pkaHZYbTZBL0M5TlVyaTFpOWI4c2c3a2FVNUlSRUlBelh3?= =?utf-8?B?RlBXK0NCa01ENXEzRGlRK3lBcWk5b0J2MjNoU0pieGpsa3Z2eG9wLysxU0x2?= =?utf-8?B?dmM1elF6YnQzYXZoY2dwRERpMHR2L1BoZE9TSVhDSjZuR0VCRFFKK0NQb2Nz?= =?utf-8?B?KzFhL3JLb2VlaUxDeFhwYk5PbDY3WUpyeG8zNGxFMUVmVkZNR2hZbW0za3dF?= =?utf-8?B?QVRFZis2Wm03MkpHOE8rYmo3Z1hYZUwyVDdNZ0pJR1pUYTNkelNxN2xyWVJD?= =?utf-8?B?MWRrYk51ZVF3ZkFvaUd3Vm54N1BObGxoT2hjSFdaTkxLTlJPWEtMc0RkRE9L?= =?utf-8?B?UExucHNNOGhKWTZDTVBUVUJGcXU0Q1VaaFJ2Y2FpMmZSSlFIVjkzeW1WRDgz?= =?utf-8?B?VE81OWNiSWFKdm12dk92YjZiY1ZPRHZvWjZsK1pueGQ4YXp3YzJRYllKaTA1?= =?utf-8?B?TVNicGpsRkt0TE5aSFAxdXp2d285REJXNnRjQVR4NTBYeUVJd0dSSlNLT2lh?= =?utf-8?B?ZGZjOGVra1MrdnZDc0doQVJsN2ZUWmJhN1BzTzh2Yyt4ZmxGQVlkM01ENkFx?= =?utf-8?B?cXVvR2NBUjgzNWZkU1JBb2VoK0FjeWkweXNYeWJKQWtVY3lQa3AzTmhjNDd4?= =?utf-8?B?SGVnZndLUWllb0pOUS9ZeEY1eko3MWpjUzRWUE1sNnMwN2lOQTBSWkI2Uk51?= =?utf-8?B?d3Arc3JDeW00TnNGSWZTS2VnVzJ2a2Y1MDRRT0QxcVlsVGIya2F5VHNoY3V3?= =?utf-8?B?ZFJiR2JVSC96aHQvWnNjS0piT0ZWWGxyV3hGTWFpZWtUU2JhWk9qMkpaZmtJ?= =?utf-8?B?aE5MMzdNSzlWRXdESHR3aGlCMkZrYW9XckdxNWw5RnpKVG52RFhlMFZyY1dX?= =?utf-8?B?WjZPY3RuYWIwNFcvdzVGOVp5ZzVUd3F5UlpXTXZ3bzhGL2VRcytuZnA2MXBS?= =?utf-8?B?MHR6bEswV0oyN1p4STZBRTJ6UW1BcjRhN1lBMUh6WHpHQVUxWmxsZnAwWG5R?= =?utf-8?B?bEtRQ1RYS3p1RmdJTnl2TXZVbTJOSEgzMDJzdFNmbTk5aHYyb2hONlJ2QVhn?= =?utf-8?B?c3U5cE95Nzd1Smx0UDZMbW5tRzRlQkR0SjZNeTNBc1dKcHI5MUFEOENzcEp3?= =?utf-8?B?Y1BDTTNkY0FKRGJXK0dHY2RwYWdOY3psenBEVk4yWndoeXlJa0xzemlON1Mw?= =?utf-8?B?aGVmVkF1UDRFRXp6c0FXMExCYmhYTkhTbVRqWmp0bVR4QkpJYXJKZEowT2lN?= =?utf-8?B?REQxSllmazl6MXhWNmNXUGl0ZEExajJqK0NVVDY5ekF1bXVwTndCMkVzK0hT?= =?utf-8?B?V2srcHEvV2RLbTlNZ21pSDdVeFdMM3BYRXUrQUx6WlN4TEwyUzBUVFF2a21h?= =?utf-8?B?b3lsNXJXT24zUFU1aFltVE5XWnhHSjJMc0ZXaUVTaERsd2xSb21JajluZHhm?= =?utf-8?B?dGNwVjA5MlQ5MmRFMjRIdVpTd1BHbWs2ZFE1ZitTYmVJVTFKb0hCOVR6cExr?= =?utf-8?B?UkE9PQ==?= Content-ID: <901E1AA9FF339C419C58D684C300327E@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fde9808-498a-49b7-9a0e-08da90ad9140 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2022 08:47:16.6393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pF6dGx6S2Zpp40V3pJwdFai8GsYQEufyaqwF0IMqmWaXrnYoeW/m3QHBjRTSw3wBUIvGLA2BzpkuvGoIgQyPdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5377 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3 1/3] lavc/decode: Warp get_hw_config function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "linjie.fu@intel.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-08-31 at 01:20 +0000, Wang, Fei W wrote: > On Tue, 2022-08-23 at 16:19 +0800, Fei Wang wrote: > > From: Linjie Fu > > > > Wrap the procedure of getting the hardware config from a pixel format > > into a function. > > > > Signed-off-by: Linjie Fu > > Signed-off-by: Fei Wang > > --- > > libavcodec/decode.c | 31 +++++++++++++++++++------------ > > 1 file changed, 19 insertions(+), 12 deletions(-) > > > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > > index 75373989c6..3b69426c09 100644 > > --- a/libavcodec/decode.c > > +++ b/libavcodec/decode.c > > @@ -1156,6 +1156,24 @@ static void hwaccel_uninit(AVCodecContext > > *avctx) > > av_buffer_unref(&avctx->hw_frames_ctx); > > } > > > > +static const AVCodecHWConfigInternal *get_hw_config(AVCodecContext > > *avctx, enum AVPixelFormat fmt) > > +{ > > + const AVCodecHWConfigInternal *hw_config; > > + > > + if (!ffcodec(avctx->codec)->hw_configs) > > + return NULL; > > + > > + for (int i = 0;; i++) { > > + hw_config = ffcodec(avctx->codec)->hw_configs[i]; > > + if (!hw_config) > > + return NULL; > > + if (hw_config->public.pix_fmt == fmt) > > + return hw_config; > > + } > > + > > + return NULL; > > +} > > + > > int ff_get_format(AVCodecContext *avctx, const enum AVPixelFormat > > *fmt) > > { > > const AVPixFmtDescriptor *desc; > > @@ -1213,18 +1231,7 @@ int ff_get_format(AVCodecContext *avctx, const > > enum AVPixelFormat *fmt) > > break; > > } > > > > - if (ffcodec(avctx->codec)->hw_configs) { > > - for (i = 0;; i++) { > > - hw_config = ffcodec(avctx->codec)->hw_configs[i]; > > - if (!hw_config) > > - break; > > - if (hw_config->public.pix_fmt == user_choice) > > - break; > > - } > > - } else { > > - hw_config = NULL; > > - } > > - > > + hw_config = get_hw_config(avctx, user_choice); > > if (!hw_config) { > > // No config available, so no extra setup required. > > ret = user_choice; > > Ping, any more comments on V3? > The patchset LGTM and works well for me, I'll apply this patchset if no more comment. -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".