Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH 1/2] libavformat/http: expose actual Location header value
@ 2023-09-19  8:52 Michael Riedl
  2023-09-19  9:05 ` Marvin Scholz
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Riedl @ 2023-09-19  8:52 UTC (permalink / raw)
  To: ffmpeg-devel

This is needed for muxers which need to access the Location header as transmitted when no redirection happen.

Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>
---
 libavformat/http.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/http.c b/libavformat/http.c
index c0fe7c36d91..27f9c8e3000 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -166,6 +166,7 @@ static const AVOption options[] = {
     { "basic", "HTTP basic authentication", 0, AV_OPT_TYPE_CONST, { .i64 = HTTP_AUTH_BASIC }, 0, 0, D | E, "auth_type"},
     { "send_expect_100", "Force sending an Expect: 100-continue header for POST", OFFSET(send_expect_100), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, E },
     { "location", "The actual location of the data received", OFFSET(location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
+    { "new_location", "The location header value of the data received", OFFSET(new_location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D },
     { "offset", "initial byte offset", OFFSET(off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
     { "end_offset", "try to limit the request to bytes preceding this offset", OFFSET(end_off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
     { "method", "Override the HTTP method or set the expected HTTP method from a client", OFFSET(method), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
-- 
2.39.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [PATCH 1/2] libavformat/http: expose actual Location header value
  2023-09-19  8:52 [FFmpeg-devel] [PATCH 1/2] libavformat/http: expose actual Location header value Michael Riedl
@ 2023-09-19  9:05 ` Marvin Scholz
  0 siblings, 0 replies; 4+ messages in thread
From: Marvin Scholz @ 2023-09-19  9:05 UTC (permalink / raw)
  To: FFmpeg development discussions and patches



On 19 Sep 2023, at 10:52, Michael Riedl wrote:

> This is needed for muxers which need to access the Location header as transmitted when no redirection happen.
>

Why are you sending the same patch over and over to the ML?

If you have new versions of a patchset, reply to the original and change the topic to:

[PATCH v2 1/2] etc...

(You can use the -vN option of git-format-patch/send-email for that.)

Else it is rather frustrating and confusing for people trying to review
your patches…

> Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>
> ---
>  libavformat/http.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/http.c b/libavformat/http.c
> index c0fe7c36d91..27f9c8e3000 100644
> --- a/libavformat/http.c
> +++ b/libavformat/http.c
> @@ -166,6 +166,7 @@ static const AVOption options[] = {
>      { "basic", "HTTP basic authentication", 0, AV_OPT_TYPE_CONST, { .i64 = HTTP_AUTH_BASIC }, 0, 0, D | E, "auth_type"},
>      { "send_expect_100", "Force sending an Expect: 100-continue header for POST", OFFSET(send_expect_100), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, E },
>      { "location", "The actual location of the data received", OFFSET(location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
> +    { "new_location", "The location header value of the data received", OFFSET(new_location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D },
>      { "offset", "initial byte offset", OFFSET(off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
>      { "end_offset", "try to limit the request to bytes preceding this offset", OFFSET(end_off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
>      { "method", "Override the HTTP method or set the expected HTTP method from a client", OFFSET(method), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
> -- 
> 2.39.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [FFmpeg-devel] [PATCH 1/2] libavformat/http: expose actual Location header value
@ 2023-09-19  8:08 Michael Riedl
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Riedl @ 2023-09-19  8:08 UTC (permalink / raw)
  To: ffmpeg-devel

This is needed for muxers which need to access the Location header as transmitted when no redirection happen.

Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>
---
  libavformat/http.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/libavformat/http.c b/libavformat/http.c
index c0fe7c36d91..27f9c8e3000 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -166,6 +166,7 @@ static const AVOption options[] = {
      { "basic", "HTTP basic authentication", 0, AV_OPT_TYPE_CONST, { .i64 = HTTP_AUTH_BASIC }, 0, 0, D | E, "auth_type"},
      { "send_expect_100", "Force sending an Expect: 100-continue header for POST", OFFSET(send_expect_100), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, E },
      { "location", "The actual location of the data received", OFFSET(location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
+    { "new_location", "The location header value of the data received", OFFSET(new_location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D },
      { "offset", "initial byte offset", OFFSET(off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
      { "end_offset", "try to limit the request to bytes preceding this offset", OFFSET(end_off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, D },
      { "method", "Override the HTTP method or set the expected HTTP method from a client", OFFSET(method), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
-- 
2.39.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [FFmpeg-devel] [PATCH 1/2] libavformat/http: expose actual Location header value
@ 2023-09-19  7:40 Michael Riedl
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Riedl @ 2023-09-19  7:40 UTC (permalink / raw)
  To: ffmpeg-devel

This is needed for muxers which need to access the Location header as 
transmitted when no redirection happen.

Signed-off-by: Michael Riedl <michael.riedl@nativewaves.com>
---
  libavformat/http.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/libavformat/http.c b/libavformat/http.c
index c0fe7c36d91..27f9c8e3000 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -166,6 +166,7 @@ static const AVOption options[] = {
      { "basic", "HTTP basic authentication", 0, AV_OPT_TYPE_CONST, { 
.i64 = HTTP_AUTH_BASIC }, 0, 0, D | E, "auth_type"},
      { "send_expect_100", "Force sending an Expect: 100-continue header 
for POST", OFFSET(send_expect_100), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 
1, E },
      { "location", "The actual location of the data received", 
OFFSET(location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D | E },
+    { "new_location", "The location header value of the data received", 
OFFSET(new_location), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, D },
      { "offset", "initial byte offset", OFFSET(off), AV_OPT_TYPE_INT64, 
{ .i64 = 0 }, 0, INT64_MAX, D },
      { "end_offset", "try to limit the request to bytes preceding this 
offset", OFFSET(end_off), AV_OPT_TYPE_INT64, { .i64 = 0 }, 0, INT64_MAX, 
D },
      { "method", "Override the HTTP method or set the expected HTTP 
method from a client", OFFSET(method), AV_OPT_TYPE_STRING, { .str = NULL 
}, 0, 0, D | E },
-- 
2.39.2

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-19  9:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-19  8:52 [FFmpeg-devel] [PATCH 1/2] libavformat/http: expose actual Location header value Michael Riedl
2023-09-19  9:05 ` Marvin Scholz
  -- strict thread matches above, loose matches on Subject: below --
2023-09-19  8:08 Michael Riedl
2023-09-19  7:40 Michael Riedl

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git