From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4714240532 for ; Thu, 26 May 2022 00:43:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AA53768B587; Thu, 26 May 2022 03:43:00 +0300 (EEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B49668AD28 for ; Thu, 26 May 2022 03:42:52 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653525778; x=1685061778; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=ST+VpT/cJEbQICwU+Pq/fiy1vHymnJ68xTf+3XBlNiQ=; b=mvSQXc+xG+HKtVyrVn/yLWsyOixjB/AXd6XeSsiJdoGrc++ShXnGcXwp GoJ9Pk/Obz4LKLV9jlwwdT75yLg9p0JN91Ru3DT8vN1NWJyCDcbH0+OsE wx81RRE4yKfTk3DmmmDtUAy/WIqonZwcImbIJfA/Mv3GT4p6tJdfNtk1s d0jap02zPODYOYyRO8UHI2qwXUTcEBjDiFpw5o+7e9GxU1XXghjyDli2X J6hezFw84wx9UspcvkFn9WdvCLr8BnQB5W58qGJnwDDtQIi+I/WFN570T 4ZcL+8iTbRkr4yhY+KoyDUHsZPoKhcQj+gl0YpCbNpZFSXoZDnqaapTlC A==; X-IronPort-AV: E=McAfee;i="6400,9594,10358"; a="299316604" X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="299316604" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2022 17:42:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,252,1647327600"; d="scan'208";a="704242317" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 25 May 2022 17:42:49 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 25 May 2022 17:42:49 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 25 May 2022 17:42:48 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 25 May 2022 17:42:48 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 25 May 2022 17:42:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VLfd/VyT0wtW3EvpYNeBDNHY3YFZY/mCP5fvlqJ5jWsjt6AcamjIdg1N6DhZZZ/xoeetn4wDms75sD64rHAI5HxIfBEe/1+uM6phg2E1oMOi1s8dTR9DRonJDzCkJoykaaFs/VRcB/CXgS6PsIBmmkiDlU2PmXyo8pevCkF06GzXngLWKMv+EWhmNHfUBLy1sk2BMlIp8ViofIbb/hzUJPTTmkrBbXkVhNTPp85shiIK1i6WITOKTdrhoM9sqQrZUZX6ufFa4pBiTUF4HhIEq5tdobpKrCGa8YK1rM9HO4NRERssewnthrMckFpdx5mdKV2y2teiLelGTm1colRhlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ST+VpT/cJEbQICwU+Pq/fiy1vHymnJ68xTf+3XBlNiQ=; b=L3yAMPh0U9SKP3+0YK4Ct07w5YenQLPrZ5t4TmCziDv/Bxnwc5DrlBCpofEBV1cvBCyPGTkLsBA9ZeD6Oi5cCSvGIuPzgEyH1eoIBckzx6idjCBviWBQW1WWErKP5DxxAbahKX2HGkRgpfl98EHzG9xZLuBI9Ll/p6ClcYnk3Ok330pXDhbplffMjkDYc1jhjiOY3jQ6MTnD0aLGcKlpr0XWpLIgl91mUKtT+h+MYiUcCOhOA/b7pcpmozfa0XSX3FyAqKyOhSD3JbAnXIZGUOO1Tr3jdnHJKwSv33DtPPFDN/LEbWkOmR+mI8/O5wydt6U8Py6+wA6N4+43LrjE9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DM6PR11MB3820.namprd11.prod.outlook.com (2603:10b6:5:140::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 26 May 2022 00:42:42 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::2d06:ec38:937a:da73%6]) with mapi id 15.20.5293.013; Thu, 26 May 2022 00:42:41 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx Thread-Index: AQHYcFF7XU3XidBeXUO3iRXKqD8oE60vxroAgACLpAA= Date: Thu, 26 May 2022 00:42:41 +0000 Message-ID: <5ec39988a81b90bc55bef74df3a40eedaa0200a1.camel@intel.com> References: <20220522121911.10993-1-haihao.xiang@intel.com> <167a0f90-1d7e-1d42-85f7-5cc301faa17a@rothenpieler.org> <2fb3cc47-05a5-4268-c5e7-922ad12592bc@gmail.com> In-Reply-To: <2fb3cc47-05a5-4268-c5e7-922ad12592bc@gmail.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 229836ad-2d34-4e37-3eef-08da3eb0a466 x-ms-traffictypediagnostic: DM6PR11MB3820:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ut7+0f7O2o6O4MpsGmvpPuW9FMnDiXSlNM3Eq5gvYQ6uY2B02rxWevR2lyIwVSpnt8wnmywhlc9qFstktJOfAL3SGDhJNZxhtmi+ZPZNxec2/SfX4HoR3kq8u8dB+Rdk6y5HUcH7JEc7DRaNqoZ5gsIJru+9J1ZpxMjmWYkB+g1SVYY9M5k/YnLUoLodgX4VABc44a+RJZHpUrznuqEzLFIiFPVqThs2/hegYdi8nD+Pth1kN8tKlUU7srw2pF45ugpLmAX5ycmpwR6beyxIGBhJPnlh55CA13QpMe/QLBB2e8KmPErASIzFehLIWvz6LMQQ91aPRbN9s+Q5jo7HxzkyxIJMeS20UVJIBkkuSUKElGQpt/mTx59HuOEUIADlxtUS8eLAswImB1DrcpHz8oWw5Kg1Fuf2L+QDwBu1j4FCy6oZITIgsdAlE6aoQz048rcJbk78wpCnDTp1ie/hbE1/uqfpfyKG5D2nu86J8tLayBCIerdOcK50dBHT0mD8u+JYTdql2QfXFEQg2hJwN/ylCceiz1Wl1Y1lAW53C35afZQQUbeMqp6O+lnzM8ugwPBaDkzZG7jrjh22nBxE9WDqg8/OyFR3A1ShR9NKmEgCeg2Fx+ifWA2Q/5EuA2CuLtEAkGhR4M8IFtVXxiT8/tTX6sqdazArwrf7bOOvb3CtTZEsl40zxSQJujkPa/Q7CpF4kQKpuihSCug1ttDpB/ORamvJ5ca4Sy0TfuGbWjE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(71200400001)(2616005)(6486002)(6916009)(186003)(36756003)(2906002)(5660300002)(8936002)(66946007)(316002)(83380400001)(66556008)(66446008)(64756008)(91956017)(76116006)(86362001)(66476007)(8676002)(6512007)(26005)(38070700005)(6506007)(53546011)(38100700002)(82960400001)(122000001)(508600001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z0E5cU9Ra0xwTHU1ZnA3bDZEYzZ5SVZOYTB1NkVYT1FMRE9SaGNaSFY1ayt2?= =?utf-8?B?dFBXTzJQNlo1K05SUSt0Rm9YWjlLK0NRcWhHODJBR2N3anJQN0ZxcnhCMTk5?= =?utf-8?B?QTc0VUF1dm9iaXU2dk5qbTh3cWFZdmcrTHV3YzhGc3VuSzc2NGlIYngwRWhs?= =?utf-8?B?Q3pjbjdwV3pGUUprQlNvNWgyc2ZVdVlrb1RxbnJjd3hXUnE5aExXRUU1YVpj?= =?utf-8?B?bDFjM3pGck1ndzQ4ZUJ6R2d4RjhUNHJvVFRkb0lyaDFnenRQbG1oMmtqYU9Z?= =?utf-8?B?K3E4VU93a01FNjVqNU5xdm1GYzNlSngxTU5jalpHSUVmbXh4TEM0ZDZuNDdn?= =?utf-8?B?RTgzdE9qUVFxNFkvd3NkUVh4NW5PN2c2ci9ub0R5MkdMUUxGblZvOFJLQkdv?= =?utf-8?B?TGE1dU1NUlR4ZVhBb09FT2Z6R0VreXpzZjJjSTB3dnNBVjdXV1JLajRQS3h5?= =?utf-8?B?Tm4raWxjTTI4N1BCOGlCemtwRmMySS9meklYOVRBaUxQK1g4ajF2OE9UV3h2?= =?utf-8?B?MzV1Z0JDUUtPTDlWYW1tNStGbjZQSHJHNmlKVTZ5dlpLT2xCNk9KMWExV3BH?= =?utf-8?B?cnhudnRLS2dEekI4S2JaUll0UWdwL3hnVjdiN1daeDdyOWZ3b0tOMkova09L?= =?utf-8?B?QXlpSytJQmxaVnV5enlCWXloUk5NSC9YTjJiQndzWmNEK2hJcUN6aEJLZnNU?= =?utf-8?B?bWI0L0dNN1Z4Nm93Y1ZPRkQ3ZXp5UEJzdVhuUHBVajhxUnpmQVlQaFZrZ2tE?= =?utf-8?B?VFBDalpZY1hpQThuMld3MHVic0pBRHRzNUY2dHpOM1RHanIxY2ovQ3BCM25s?= =?utf-8?B?RHg4VG1BOTk2M081anRTaENKa0lOeDhTRjMydnhCMWt2VmxpSkdEU1cwL2Y0?= =?utf-8?B?NURMT0pFdk9lQXFySjE0Rmd3ajFQMy9ZN1M0SFlIb1F6WUdNVWFXMVI2U3F6?= =?utf-8?B?V3lWMEpraVFOVjFCNHFFa00rSVlhZkhsWmhQRjd6YTlGanFWVFAxUG1BYTVF?= =?utf-8?B?b0hFL3UyblRRSHdDUGt0VVlIYUpGTWJ1VTI0R0d1NDN4UG45THlOMTZpaHNu?= =?utf-8?B?bHNXUTNEc1FFOWdNcjJaUGtwL3JLTEt4ZXA4c3N6YVltVUFCdmdIN256NDB1?= =?utf-8?B?SU1hOG5uMWVyRGVrWHJ5b0Q2WkhNMUhaOERjRGN1bXU1clFJRVBNOHFrdWRS?= =?utf-8?B?a1ZZS0JnazVFZURWblhIeGdjNW91SGdFSHorc3lxQ3R0UExTUHo5cnpFaU9O?= =?utf-8?B?cEhwU1FFd2s4b0xINWNmcHJYQVZyMjBIU0NxU2xXZFVFbFVCMjhPZkpUWTc3?= =?utf-8?B?eFRjTW5vL0hsemxub3IvVEN5VVVQdWpScFM4N1pNcTJQLzFVQ01IQ2pVZXd3?= =?utf-8?B?MzhJSWpJVm83dU42RUFBbm1NdDYxR3ZLcEdKbU54Mi9HY2FxeHRJaXNoQm5l?= =?utf-8?B?UDlpTnRLcnIwZFpGL1NSejdaZkUyQUNmRHdKbm9jRVhEbUtWYUZaVzlkazFK?= =?utf-8?B?VlFZb01jblBMK0tKbjJyYXhZdUxxYWNiYm11dTh5U0dKZldBOU45d0czQ2Fs?= =?utf-8?B?dDdzTDE3dVVBQmRHcnRsU1FGUU4zaGJyeU9TSUhMS3VyMmx4ZHo3NkltVmFX?= =?utf-8?B?WWtSaVRDTGNrMGNZMFhJVE1qVkNYcEV0NjJiQ3FrZlRwWno5QjZJaUUrRmRx?= =?utf-8?B?bjE2UDYzaU54RlZ3d3JhWDBOWFpKZDNIZ3Z5M0dyOGIxVmpzd2JEQW1UcnNG?= =?utf-8?B?S09jNERyQTc1WUJZYTlXY1p3bU82bmhxTkh3NmJNQi9GZnVLU0xwY2l5MXM2?= =?utf-8?B?L1ZEbzdlR05sektnYWl6Sk9CT2ZZbDAvUVZMeHZ5ejVXYis3bDR6Y05DcDFH?= =?utf-8?B?VlRwODk0NGZQczN5cU5nQlRVc0Z0WWtURUJUR0ZFNzNTazltWlNnVDZtRko4?= =?utf-8?B?T0dFc3B5a1N4TXdtSENYZHl5OHFPNWF1Nk1PUUVtSWtxaGx5VmozVmhLckdp?= =?utf-8?B?TlhRM3JsYnpUVlRKSXV1Z3BYTmc1VFpvZ1ZpL21zK0g3eFR6N3hrcm5BUzNn?= =?utf-8?B?M3ZkZXdQTmFaUDVwRTBRRE4zempuZEFWckNPUUhtNzlwVXEvMElWalF6Tndv?= =?utf-8?B?Vy9qVzUyRTl5L0VLdUNqcTBnMWdERDY3QVNQWVQ0ZHR6c0h5b2JkamdaNSt3?= =?utf-8?B?N2hodW5wQUNseVdFOGd6blVUOUNsdkE4SkFWNXBNSU1CZnBIK1k4TVFSWjQ0?= =?utf-8?B?QzkvYVROT29PS2xLeWJsaWV6NXpPOTdmbXFveUpjNnZSbk4xY2ZJOU9oTGZH?= =?utf-8?B?ZTJvMnZib1NKWmNIZnJsdS9rME54V2kvbW1CelFSbERuenJoMndpdDA3ZnY4?= =?utf-8?Q?GXRco4E8pe/Bm1WE=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 229836ad-2d34-4e37-3eef-08da3eb0a466 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2022 00:42:41.9051 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GhV/Vmkpi7/IjuGdKeRwkfbF0uC4PEhQev2SoloVb2WGir1zNPUqlctbfurw+jyvTuRAEr1z2Xg84cXdtx++Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3820 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-05-25 at 12:22 -0400, Leo Izen wrote: > > On 5/25/22 12:05, Timo Rothenpieler wrote: > > > > > > On 22/05/2022 14:19, Haihao Xiang wrote: > > > libmfx 1.28 was released 3 years ago, it is easy to get a greater > > > version than 1.28. We may remove lots of compile-time checks if adding > > > the requirement for the minimal version in the configure script. > > > --- > > > configure | 7 +- > > > libavcodec/qsv.c | 24 -- > > > libavcodec/qsvenc.c | 471 +++++++++++++------------------------ > > > libavcodec/qsvenc.h | 51 +--- > > > libavcodec/qsvenc_h264.c | 6 - > > > libavcodec/qsvenc_hevc.c | 10 - > > > libavfilter/vf_scale_qsv.c | 13 +- > > > libavfilter/vf_vpp_qsv.c | 143 ++++++----- > > > libavutil/hwcontext_qsv.c | 2 - > > > 9 files changed, 249 insertions(+), 478 deletions(-) > > > > > > diff --git a/configure b/configure > > > index f115b21064..2337f0a8f2 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -6566,8 +6566,11 @@ enabled liblensfun && require_pkg_config > > > liblensfun lensfun lensfun.h lf_ > > > # Media SDK or Intel Media Server Studio, these don't come with > > > # pkg-config support. Instead, users should make sure that the build > > > # can find the libraries and headers through other means. > > > -enabled libmfx && { check_pkg_config libmfx libmfx > > > "mfx/mfxvideo.h" MFXInit || > > > - { require libmfx "mfx/mfxvideo.h" > > > MFXInit "-llibmfx $advapi32_extralibs" && warn "using libmfx without > > > pkg-config"; } } > > > +enabled libmfx && { check_pkg_config libmfx "mfx >= 1.28" > > > "mfx/mfxvideo.h" MFXInit || > > > + { require libmfx "mfx/mfxvideo.h > > > mfx/mfxdefs.h" MFXInit "-llibmfx $advapi32_extralibs" && > > > > This broke build with mfx_dispatch. Before this, it checked for > > libmfx.pc. Now it checks for mfx.pc, which is not installed by it. > > > > Which of those is correct? It should definitely not drop support for > > libmfx.pc, which was checked before this. > > It also attempts to link to -llibmfx, which means liblibmfx.so. I'm > guessing it's supposed to link to -lmfx instead. It is -llibmfx in the original code. Please see commit 164e2773261451ef33c4616296ec5bebecff42af for why it is -llibmfx instead of -lmfx here. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".