[FFmpeg-devel] Re: [PATCH v2] avformat/udp: fix warning about unused varible

[Timo Rothenpieler via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1714 bytes --]

On 21.09.2025 03:19, Brad Smith via ffmpeg-devel wrote:
> libavformat/udp.c:283:9: warning: unused variable 'i' [-Wunused-variable]
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
>   libavformat/udp.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/udp.c b/libavformat/udp.c
> index e1dec49010..839c301369 100644
> --- a/libavformat/udp.c
> +++ b/libavformat/udp.c
> @@ -282,14 +282,12 @@ static int udp_set_multicast_sources(URLContext *h,
>                                        struct sockaddr_storage *sources,
>                                        int nb_sources, int include)
>   {
> -    int i;
>       if (addr->sa_family != AF_INET) {
>   #if HAVE_STRUCT_GROUP_SOURCE_REQ && defined(MCAST_BLOCK_SOURCE)
>           /* For IPv4 prefer the old approach, as that alone works reliably on
>            * Windows and it also supports supplying the interface based on its
>            * address. */
> -        int i;
> -        for (i = 0; i < nb_sources; i++) {
> +        for (int i = 0; i < nb_sources; i++) {
>               struct group_source_req mreqs;
>               int level = addr->sa_family == AF_INET ? IPPROTO_IP : IPPROTO_IPV6;
>   
> @@ -316,7 +314,7 @@ static int udp_set_multicast_sources(URLContext *h,
>   #endif
>       }
>   #if HAVE_STRUCT_IP_MREQ_SOURCE && defined(IP_BLOCK_SOURCE)
> -    for (i = 0; i < nb_sources; i++) {
> +    for (int i = 0; i < nb_sources; i++) {
>           struct ip_mreq_source mreqs;
>           if (sources[i].ss_family != AF_INET) {
>               av_log(h, AV_LOG_ERROR, "Source/block address %d is of incorrect protocol family\n", i + 1);

looks okay to me

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4742 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org