From: Sil Vilerino <sivileri@linux.microsoft.com>
To: ffmpeg-devel@ffmpeg.org, ffmpeg-devel-bounces@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] hwcontext_vaapi: Add support for vaGetDisplayWin32 initialization
Date: Thu, 13 Apr 2023 08:56:47 -0400
Message-ID: <5e3ba908-bb96-4be5-d5f4-32680a09b538@linux.microsoft.com> (raw)
In-Reply-To: <BL1PR21MB335440303237E28BAA30E7AEE5989@BL1PR21MB3354.namprd21.prod.outlook.com>
On 4/12/2023 4:08 AM, Anton Khirnov wrote:
> Quoting Xiang, Haihao (2023-04-12 05:06:29)
>>
>> LGTM and it works for me on Windows. I'll push this in the next few
>> days if no other comments or objections.
>
> This patch does way too many changes at once. I would much prefer if the changes to hwcontext_vaapi, qsv, and ffmpeg CLI were split into separate patches.
>
Hi Anton,
Thanks for taking a look. Sent V3 yesterday splitting it into separate
three patches for those components you mentioned. I got some feedback on
the version V3 too so I'll be sending V4 for the patches that need
further changes in a couple of days after people got some time to finish
commenting on V3.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-04-13 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 21:41 Sil Vilerino
2023-04-12 3:06 ` Xiang, Haihao
2023-04-12 8:08 ` Anton Khirnov
[not found] ` <BL1PR21MB335440303237E28BAA30E7AEE5989@BL1PR21MB3354.namprd21.prod.outlook.com>
2023-04-13 12:56 ` Sil Vilerino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e3ba908-bb96-4be5-d5f4-32680a09b538@linux.microsoft.com \
--to=sivileri@linux.microsoft.com \
--cc=ffmpeg-devel-bounces@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git