From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9E1E3405A8 for ; Thu, 26 May 2022 21:00:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F0F9468B580; Fri, 27 May 2022 00:00:33 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 26CE268AA67 for ; Fri, 27 May 2022 00:00:27 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 24QL0Pav004019-24QL0Paw004019 for ; Fri, 27 May 2022 00:00:25 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id AC51CA142D for ; Fri, 27 May 2022 00:00:25 +0300 (EEST) Date: Fri, 27 May 2022 00:00:23 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <5e208810-bd84-b48d-7aba-32d2eec624c1@martin.st> References: <14f3713f1846486cb58cbdf26e654983@EX13D07UWB004.ant.amazon.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] swscale/aarch64: add hscale specializations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 26 May 2022, J. Dekker wrote: >> + >> + // gather random access data from src into contiguous memory >> + ldr w8, [x3, w8, UXTW] // src[filterPos[idx + 0]][0..3] > Current asm code has lowercase uxtw, would prefer to keep it consistent. >> + ldr w9, [x3, w9, UXTW] // src[filterPos[idx + 1]][0..3] >> + ldr w10, [x3, w10, UXTW] // src[filterPos[idx + 2]][0..3] >> + ldr w11, [x3, w11, UXTW] // src[filterPos[idx + 3]][0..3] >> + ldr w12, [x3, w12, UXTW] // src[filterPos[idx + 4]][0..3] >> + ldr w13, [x3, w13, UXTW] // src[filterPos[idx + 5]][0..3] >> + ldr w14, [x3, w14, UXTW] // src[filterPos[idx + 6]][0..3] >> + ldr w15, [x3, w15, UXTW] // src[filterPos[idx + 7]][0..3] >> + stp w8, w9, [sp] // *scratch_mem = { src[filterPos[idx + 0]][0..3], src[filterPos[idx + 1]][0..3] } >> + stp w10, w11, [sp, #8] // *scratch_mem = { src[filterPos[idx + 2]][0..3], src[filterPos[idx + 3]][0..3] } >> + stp w12, w13, [sp, #16] // *scratch_mem = { src[filterPos[idx + 4]][0..3], src[filterPos[idx + 5]][0..3] } >> + stp w14, w15, [sp, #24] // *scratch_mem = { src[filterPos[idx + 6]][0..3], src[filterPos[idx + 7]][0..3] } >> + >> +1: >> + ld4 {v16.8B, v17.8B, v18.8B, v19.8B}, [sp] // transpose 8 bytes each from src into 4 registers > Same with format specifiers being lower case, i.e. v16.8b That's indeed the convention for most of our code, but we do have some amount of code using uppercase for these too. In particular, this file itself uses uppercase for such things so far. Ideally we would reformat those files to use consistent styles, but until then I don't have a very strong opinion about it (we can add it matching the surrounding code and then reformat it all later, or add the new code in the generally preferred style). // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".