From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BF4BC44BFF for ; Mon, 14 Nov 2022 02:12:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C07BD68BD35; Mon, 14 Nov 2022 04:12:29 +0200 (EET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F47A68BBA0 for ; Mon, 14 Nov 2022 04:12:22 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668391948; x=1699927948; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=iL+hnEGAhcL7Qe68Owmm4kthQCbOrAv9dpxoViHeUIU=; b=UyEYKDTUJ/9qFYwvvzHvB16WI4ryQ9w2G4mruRubcd9aeaVlu9nv3UjH W4fEj9TLCkiiAlLPywo4CiD4EesJB4xh7vxWiAt4YwmSS1S+YeacfgRHI tOJWu90BVwo2gkI0f5ZfggNg0js/m6s0wxk539Ds1jSJT+CD2QZC5wN2G KI3owSO2dzTlYgAIC91z4mjEA7Olgfj8fXqO2O0cIqm4rxHdEkuiOysFy XSbbENUTVBZKIpRA/t/NRSECNfWIkmWgVecnDSTQsvdaXsZ9ucnjZR+8e QsmVaSIQxZ7s3/rZts5ACtfLpDo6sxrk7iGHqVRFyumTfzCYthW2mhCEg w==; X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="398154078" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="398154078" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2022 18:12:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="707128467" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="707128467" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 13 Nov 2022 18:12:05 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 13 Nov 2022 18:12:05 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 13 Nov 2022 18:12:05 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 13 Nov 2022 18:12:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QUORchnyJvjLMFrPX//kqydBAMUz/kq3VrbqseLaq+CzObl1v/w1Hr0O6JqordvTLksBvOQuHK6z4mwbEA0HmaPwFAaQXKcCiD7nRkgQoL6WnwseTZ2ip8cd5KHpv77vdwwu1Ectd4rvbjk5qWBB+hEVYWe62BZsbV2mecs1vPatUb4xmdKr4z+9f67qZiDvAEY21YscapJAON1gRmjL7jHZIkr0B+SEMgBfm6mJLNYxKCCkqTlvqHm73boqtgyy9S/zyYFiI857ZC/9bHOTPv9Rl9AhGKI6+MhdooBJLTOkt+gebV2lEdVN15iCajQJFoSuroDX2eZnM6Pn2iJ/SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iL+hnEGAhcL7Qe68Owmm4kthQCbOrAv9dpxoViHeUIU=; b=YTpe3gPDZ8mXyJ1U2DOfHMpB7wtXVKS8PJFFA/+RMNbik24IF2dadwOI1ctqaPXijuUpjM6HdeJ9pa2VbGi7iEuU3bEWtFFndxjKjmIXxSd6ZEAFTxM0y2ASOmV0k6PfrO/2/gHYeQwWB+biyQLByT5R44njDqFaKaHxMU/o8SKgmV8oDFG0mQXiAOaBzwkKUljwVlZCGPI09/jWzOniKc7z8c+cJ12exIX6ho35gElS2FlmcaPKHFIBqsVJdXE+6XZIOymiY7DEL6Fdo0CYZ4/8r3QgN3iGoHxCBFEXrL9sP+gO72KmvukVk6eMuQcsizxLePPWp4d7djqOuMiGwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DM4PR11MB7255.namprd11.prod.outlook.com (2603:10b6:8:10d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 02:12:03 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::ca2a:c3a1:b0cb:c003]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::ca2a:c3a1:b0cb:c003%9]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 02:12:03 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v7] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI Thread-Index: AQHY8CrL0KI1InozpkmR3D2PqCovQ64y8iIAgAYhCQCABKl4gA== Date: Mon, 14 Nov 2022 02:12:03 +0000 Message-ID: <5e0042059ac30b65976dec7b82764bc529fceceb.camel@intel.com> References: <20221104082925.25598-1-bin.wang@intel.com> <1aef874ff5e61735e448276b9cfcb08a8b476be8.camel@intel.com> <1ed11e661437c1e64b36763803949a73544bffc8.camel@intel.com> In-Reply-To: <1ed11e661437c1e64b36763803949a73544bffc8.camel@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|DM4PR11MB7255:EE_ x-ms-office365-filtering-correlation-id: 38a707b8-d031-4200-8f50-08dac5e59f02 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ocgFUS27/jxPonesbGJ+UEFAuJFaHW+EroAvKZaZQ2AVF1Le16vWaeTvdtNzFHqYdWCagHGr11lBUnzxIO/inzHoPhl9K39Y2rPqSzHSR0vjWN/z4H1OmsPP8K5/eUJW7DaDOWTlP33U7x0wzxcG43St+J+wl1qg3qPkhOGSr4XG0omYBCZ6ymO+viDgnf/zr66QDEsAGBM9XcB6OcVPxvxfOuVl+7IZLDMwPzhNEC19X4pCdJBgb5iDjUMZ3sD0EMm4GgHgXmZROBwlRWdmkcVot4Zm0CJxA4Uz7mucsLZqFgX7bY9Itf+YVS+gZ1M9p6l7Hwt4wy47xz1Y5/DpFLBKT9UcfSj3J9xhVlBebkxpxP6TXyDD73/5+JgOBusYKSv59M3Fw/4HurEap8Eik8JgKrAZ+pg3wjCyEQCKgI41GS1eB6iGKCU6MXvHht6G8Mxzbzp239OoAXwkeXvsE1DT3xkHpILt+L4DaXJujei+FDYiDX9oF7mlh5oSvLUUgONvy6P22OT5n3X6jpQpjzqISX+ipjaPjF//LFj84hhfyhmm/d5zizj/pt2+lNwsMXqy2POSrowTVm+MQ/1sQWeCeAwF7ThRiKt3YKxMTHsYCVH2CazUMPcrdzu26MdyP2ayknxo9OQ9fN6i3AtQte6kYoUxCQWxZbJ4LqoDINS7S1DB/G7KKJ36LyeZk2u4bzeZ07b/foVyErKH+U2vY/1IG+vtOtOTKoWTBr8ejnBq9B0z/agownNiUVgiaZxzxbf/n+bOFpkCayQ1iMUDCfsA9p8tRCVN2NDxhYdPNQY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(376002)(346002)(396003)(136003)(451199015)(83380400001)(86362001)(38100700002)(122000001)(82960400001)(30864003)(38070700005)(2906002)(41300700001)(8676002)(4326008)(5660300002)(8936002)(64756008)(6506007)(26005)(66446008)(6512007)(107886003)(186003)(478600001)(316002)(2616005)(6916009)(71200400001)(66476007)(66556008)(76116006)(91956017)(66946007)(6486002)(4001150100001)(36756003)(2004002)(559001)(579004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NngxaVUyZSt2VmN2SmlYMEpGU3dhSVVNT1BHZXNIaHZXN2JJOWJjRDFGUVhL?= =?utf-8?B?WkpPZWI4YUVWTHJ6RGh6Z3E1UVVpNjEwNktYY3g2cWR6UExlZUNLUi81aTJ0?= =?utf-8?B?NS9UNDdGMHRsTVphbU82ZWtTcmJDSWUyRGxUUFJ3Q2thNk9DNGJWbmE4ZFF4?= =?utf-8?B?VDd3cXpLZzR2WFZlWWxqaWtvdDZ4VVVpU3JNK29aT2c1eUFtblg3VnBmdEFP?= =?utf-8?B?NzFYR3Y1OVRvbjdjKy8xeXhjNHNrbi90b2JQQkkzZklvSmptRlJTSDZzUkFZ?= =?utf-8?B?MVh1VEF3aHZsV3RNa1BvZVErcEF1THlQMzlUWEtoblB3bWpOZEZlYUhtM05u?= =?utf-8?B?NkRrejlqTzk0eCtSaTlzVTFtRzJhWW1OUHN6dklEbDJFYlNtNUZPWkU0NW95?= =?utf-8?B?TlJJUCthT3NOa25yN2sxZ2JoR0JCako3cmF3NDhUbmx1ckFZNG45eSsrR1NW?= =?utf-8?B?WEpkeFlKL2dDL1Izb1A2emgwVmlYcGxTQ2FkRlYyaDJ2TDU2Q2NZK3VvS0kz?= =?utf-8?B?VGhac1Z4N1FlY1NWcmtOY3llM2M5VWxFalQvam9Jdzh1UGdWSExCNjJLT0Vz?= =?utf-8?B?azBHRWVmYVRRcTJDRkMvNnBFRDNlY21sRS9XYlZINEZlTkRkd0tyKzlXdjlU?= =?utf-8?B?bU11eWVEQUFUQU9FQzA2Sm1Rc3lURXpUdWNLMFhNUnBva0lKcjNpektSNEpN?= =?utf-8?B?VUhsVFEzWE9PZ0pjTlphWUtIN0NpWC85NmhPdzZpeGpTbG5ha3RkYmlzZTkz?= =?utf-8?B?Njg4dmh6UkxqaDBqVTk1UVRjck5WUWphbVc4R1dwWXhYK2pTVC8zZ1JOeUNN?= =?utf-8?B?TmFWRUpwM1VZR1Z1eUlsTXFSaU52aHNodUNaaWhoc2JjQmZWQ0F5Y0NGVnlz?= =?utf-8?B?OVdwVlYybWxSTlE2TmFITXlrVXVVWEtJVERpV0d2a1hFNmR1NG16c1NUUU5Y?= =?utf-8?B?NCt4VEJUV2Vhd2FnZXo3UXcxWVJCN1dFZ1hmY1o3Nk1WUjNJL05NSTB0aGVX?= =?utf-8?B?clZtZ2pzYmt3SUNseW1GTFBBRGw3Q0dBK3FFMmZiOTl5VGtWNkpSZk8wSEd6?= =?utf-8?B?Y1lxbjVuNzVNeGFvTXRDaTNPZFZzSDMxSzkzeVcxM25rMzJCcnhvN0NrQWE4?= =?utf-8?B?RjJ0K0RlU3hGNjRiRXdZOHZZMGdBcmVYY2lxMGJNQUI2MWdXSHo3S1VEUlJS?= =?utf-8?B?WVZxdEVUTGh3aXp5NWpZN2FabmNJNXNqU3hoVUFFQTljZSttZHdTdlBCblh2?= =?utf-8?B?Z1JxRXJhUU5sbVdCTGJ6RitSdG54bkdPYmVHeno0bm1wYzFWUUpRNzBLTHhX?= =?utf-8?B?aGxSZTlORWtEbnBFT3VhcEVRMllBOVJjakh4aVRQb1JEU1hZTEhPUG4ybTAr?= =?utf-8?B?T0VqT1JmVjVvRGtCZ1R2ZktmQVBVaXhIbmRoU090ZGt5L013OGZVcHhabkp2?= =?utf-8?B?b1NlTTUxbFpCRkVrdFhyWXhOVmN5bXZRWUorMmJOMUFCSlM1MWdoSm5ZeDd2?= =?utf-8?B?RXFPd3M0RjRnNFFLNDNVTmFVcmd1dzVNV0Qra3NLeVNHRnRxelc0dVNJSHM5?= =?utf-8?B?a0xLVE5Udi9NQjRpSk14TDhRZmVXbXpXeDMwek9PWVlmOXVCY2tweTFJUGoz?= =?utf-8?B?RlF4M2hHamt4OWI5amVpOFNzWUFtaDFhWmo4V0toL0xDa2djR3RVa3NBMFE5?= =?utf-8?B?QmdHb20zN3dZcEFoTHFIck9pUFlkRDRBa2NCSlJ0eGR5WGlPZVV2QnB3cVpy?= =?utf-8?B?WkxBSHRKcVFsTERWNG5uZndEOWxxclg2cmF0Zlh4dWtjY0dRUHZjSDhXRUN2?= =?utf-8?B?Vm9BM0N0OXF6MFZrWUsrVlNVNjhxNDVPckxRSVgvanM4QVp2UHlqNStqNzVj?= =?utf-8?B?RkFXbU1RZW5pbGpxT1RiT0pyTUI4YXh4bUh1Rm5VYXVrbEpMWDlzME1MZVRw?= =?utf-8?B?NEFGVGtQbS9PL1FBOWFKajRpdFMwM2dBNWdnRUNNRE9FcmluR3U1R29NU1U1?= =?utf-8?B?V2cwNi9IT011QUhaUXkxUVB6SS9LMFJIRFJoZWZVZTVYZTZ2VTR4R3dRVSth?= =?utf-8?B?RW5UTnNCSE1pZGwvN0lSc3lnT2M5N0Y0L1ZwL3hRT1AyMXE2Um9kQ0tHaEx2?= =?utf-8?B?QnJuUUNMM041WitLSzVSNmhOdzFYdGxYaVVzQzV0VjhGeHhGWEs1U2o1THQz?= =?utf-8?B?T0E9PQ==?= Content-ID: <44351D032A464646A5BF1556E12EF3AD@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38a707b8-d031-4200-8f50-08dac5e59f02 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 02:12:03.1805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YRHxz8oviK294AWJLi/LJk0xnVitRpl31Vy/xM6dgkVTiqXur54iS2Yj4WvM09AbkRg/5ikcysnvDs3QLsKayw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7255 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v7] libavfilter/x86/vf_convolution: add sobel filter optimization and unit test with intel AVX512 VNNI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Wang, Bin" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2022-11-11 at 03:00 +0000, Xiang, Haihao wrote: > On Mon, 2022-11-07 at 05:24 +0000, Xiang, Haihao wrote: > > On Fri, 2022-11-04 at 16:29 +0800, bin.wang-at-intel.com@ffmpeg.org wrote: > > > From: bwang30 > > > > > > This commit enabled assembly code with intel AVX512 VNNI and added unit > > > test > > > for sobel filter > > > > > > sobel_c: 4537 > > > sobel_avx512icl 2136 > > > > > > Signed-off-by: bwang30 > > > --- > > > libavfilter/convolution.h | 74 +++++++++++++ > > > libavfilter/vf_convolution.c | 91 +++------------- > > > libavfilter/x86/vf_convolution.asm | 147 ++++++++++++++++++++++++++ > > > libavfilter/x86/vf_convolution_init.c | 18 ++++ > > > tests/checkasm/Makefile | 1 + > > > tests/checkasm/checkasm.c | 3 + > > > tests/checkasm/checkasm.h | 1 + > > > tests/checkasm/vf_convolution.c | 104 ++++++++++++++++++ > > > tests/fate/checkasm.mak | 1 + > > > 9 files changed, 362 insertions(+), 78 deletions(-) > > > create mode 100644 tests/checkasm/vf_convolution.c > > > > > > diff --git a/libavfilter/convolution.h b/libavfilter/convolution.h > > > index 88aabe9a20..e44bfb5da8 100644 > > > --- a/libavfilter/convolution.h > > > +++ b/libavfilter/convolution.h > > > @@ -21,6 +21,7 @@ > > > #ifndef AVFILTER_CONVOLUTION_H > > > #define AVFILTER_CONVOLUTION_H > > > #include "avfilter.h" > > > +#include "libavutil/intreadwrite.h" > > > > > > enum MatrixMode { > > > MATRIX_SQUARE, > > > @@ -61,4 +62,77 @@ typedef struct ConvolutionContext { > > > } ConvolutionContext; > > > > > > void ff_convolution_init_x86(ConvolutionContext *s); > > > +void ff_sobel_init_x86(ConvolutionContext *s, int depth, int nb_planes); > > > + > > > +static void setup_3x3(int radius, const uint8_t *c[], const uint8_t *src, > > > int > > > stride, > > > + int x, int w, int y, int h, int bpc) > > > +{ > > > + int i; > > > + > > > + for (i = 0; i < 9; i++) { > > > + int xoff = FFABS(x + ((i % 3) - 1)); > > > + int yoff = FFABS(y + (i / 3) - 1); > > > + > > > + xoff = xoff >= w ? 2 * w - 1 - xoff : xoff; > > > + yoff = yoff >= h ? 2 * h - 1 - yoff : yoff; > > > + > > > + c[i] = src + xoff * bpc + yoff * stride; > > > + } > > > +} > > > + > > > +static void filter_sobel(uint8_t *dst, int width, > > > + float scale, float delta, const int *const > > > matrix, > > > + const uint8_t *c[], int peak, int radius, > > > + int dstride, int stride, int size) > > > +{ > > > + const uint8_t *c0 = c[0], *c1 = c[1], *c2 = c[2]; > > > + const uint8_t *c3 = c[3], *c5 = c[5]; > > > + const uint8_t *c6 = c[6], *c7 = c[7], *c8 = c[8]; > > > + int x; > > > + > > > + for (x = 0; x < width; x++) { > > > + float suma = c0[x] * -1 + c1[x] * -2 + c2[x] * -1 + > > > + c6[x] * 1 + c7[x] * 2 + c8[x] * 1; > > > + float sumb = c0[x] * -1 + c2[x] * 1 + c3[x] * -2 + > > > + c5[x] * 2 + c6[x] * -1 + c8[x] * 1; > > > + > > > + dst[x] = av_clip_uint8(sqrtf(suma*suma + sumb*sumb) * scale + > > > delta); > > > + } > > > +} > > > + > > > +static void filter16_sobel(uint8_t *dstp, int width, > > > + float scale, float delta, const int *const > > > matrix, > > > + const uint8_t *c[], int peak, int radius, > > > + int dstride, int stride, int size) > > > +{ > > > + uint16_t *dst = (uint16_t *)dstp; > > > + int x; > > > + > > > + for (x = 0; x < width; x++) { > > > + float suma = AV_RN16A(&c[0][2 * x]) * -1 + AV_RN16A(&c[1][2 * x]) > > > * > > > -2 + AV_RN16A(&c[2][2 * x]) * -1 + > > > + AV_RN16A(&c[6][2 * x]) * 1 + AV_RN16A(&c[7][2 * x]) > > > * 2 + AV_RN16A(&c[8][2 * x]) * 1; > > > + float sumb = AV_RN16A(&c[0][2 * x]) * -1 + AV_RN16A(&c[2][2 * x]) > > > * 1 + AV_RN16A(&c[3][2 * x]) * -2 + > > > + AV_RN16A(&c[5][2 * x]) * 2 + AV_RN16A(&c[6][2 * x]) > > > * > > > -1 + AV_RN16A(&c[8][2 * x]) * 1; > > > + > > > + dst[x] = av_clip(sqrtf(suma*suma + sumb*sumb) * scale + delta, 0, > > > peak); > > > + } > > > +} > > > + > > > +static av_unused void ff_sobel_init(ConvolutionContext *s, int depth, int > > > nb_planes) > > > +{ > > > + for (int i = 0; i < 4; i++) { > > > + s->filter[i] = filter_sobel; > > > + s->copy[i] = !((1 << i) & s->planes); > > > + s->size[i] = 3; > > > + s->setup[i] = setup_3x3; > > > + s->rdiv[i] = s->scale; > > > + s->bias[i] = s->delta; > > > + } > > > + if (s->depth > 8) > > > + for (int i = 0; i < 4; i++) > > > + s->filter[i] = filter16_sobel; > > > +#if ARCH_X86_64 > > > + ff_sobel_init_x86(s, depth, nb_planes); > > > +#endif > > > +} > > > #endif > > > diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c > > > index 9a9c099e6d..7762fa2a05 100644 > > > --- a/libavfilter/vf_convolution.c > > > +++ b/libavfilter/vf_convolution.c > > > @@ -139,24 +139,6 @@ static void filter16_roberts(uint8_t *dstp, int > > > width, > > > } > > > } > > > > > > -static void filter16_sobel(uint8_t *dstp, int width, > > > - float scale, float delta, const int *const > > > matrix, > > > - const uint8_t *c[], int peak, int radius, > > > - int dstride, int stride, int size) > > > -{ > > > - uint16_t *dst = (uint16_t *)dstp; > > > - int x; > > > - > > > - for (x = 0; x < width; x++) { > > > - float suma = AV_RN16A(&c[0][2 * x]) * -1 + AV_RN16A(&c[1][2 * x]) > > > * > > > -2 + AV_RN16A(&c[2][2 * x]) * -1 + > > > - AV_RN16A(&c[6][2 * x]) * 1 + AV_RN16A(&c[7][2 * x]) > > > * 2 + AV_RN16A(&c[8][2 * x]) * 1; > > > - float sumb = AV_RN16A(&c[0][2 * x]) * -1 + AV_RN16A(&c[2][2 * x]) > > > * 1 + AV_RN16A(&c[3][2 * x]) * -2 + > > > - AV_RN16A(&c[5][2 * x]) * 2 + AV_RN16A(&c[6][2 * x]) > > > * > > > -1 + AV_RN16A(&c[8][2 * x]) * 1; > > > - > > > - dst[x] = av_clip(sqrtf(suma*suma + sumb*sumb) * scale + delta, 0, > > > peak); > > > - } > > > -} > > > - > > > static void filter16_scharr(uint8_t *dstp, int width, > > > float scale, float delta, const int *const > > > matrix, > > > const uint8_t *c[], int peak, int radius, > > > @@ -261,26 +243,6 @@ static void filter_roberts(uint8_t *dst, int width, > > > } > > > } > > > > > > -static void filter_sobel(uint8_t *dst, int width, > > > - float scale, float delta, const int *const > > > matrix, > > > - const uint8_t *c[], int peak, int radius, > > > - int dstride, int stride, int size) > > > -{ > > > - const uint8_t *c0 = c[0], *c1 = c[1], *c2 = c[2]; > > > - const uint8_t *c3 = c[3], *c5 = c[5]; > > > - const uint8_t *c6 = c[6], *c7 = c[7], *c8 = c[8]; > > > - int x; > > > - > > > - for (x = 0; x < width; x++) { > > > - float suma = c0[x] * -1 + c1[x] * -2 + c2[x] * -1 + > > > - c6[x] * 1 + c7[x] * 2 + c8[x] * 1; > > > - float sumb = c0[x] * -1 + c2[x] * 1 + c3[x] * -2 + > > > - c5[x] * 2 + c6[x] * -1 + c8[x] * 1; > > > - > > > - dst[x] = av_clip_uint8(sqrtf(suma*suma + sumb*sumb) * scale + > > > delta); > > > - } > > > -} > > > - > > > static void filter_scharr(uint8_t *dst, int width, > > > float scale, float delta, const int *const > > > matrix, > > > const uint8_t *c[], int peak, int radius, > > > @@ -552,22 +514,6 @@ static void filter_column(uint8_t *dst, int height, > > > } > > > } > > > > > > -static void setup_3x3(int radius, const uint8_t *c[], const uint8_t *src, > > > int > > > stride, > > > - int x, int w, int y, int h, int bpc) > > > -{ > > > - int i; > > > - > > > - for (i = 0; i < 9; i++) { > > > - int xoff = FFABS(x + ((i % 3) - 1)); > > > - int yoff = FFABS(y + (i / 3) - 1); > > > - > > > - xoff = xoff >= w ? 2 * w - 1 - xoff : xoff; > > > - yoff = yoff >= h ? 2 * h - 1 - yoff : yoff; > > > - > > > - c[i] = src + xoff * bpc + yoff * stride; > > > - } > > > -} > > > - > > > static void setup_5x5(int radius, const uint8_t *c[], const uint8_t *src, > > > int > > > stride, > > > int x, int w, int y, int h, int bpc) > > > { > > > @@ -708,6 +654,18 @@ static int param_init(AVFilterContext *ctx) > > > const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(inlink->format); > > > int p, i; > > > > > > + s->depth = desc->comp[0].depth; > > > + s->max = (1 << s->depth) - 1; > > > + > > > + s->planewidth[1] = s->planewidth[2] = AV_CEIL_RSHIFT(inlink->w, desc- > > > > log2_chroma_w); > > > + s->planewidth[0] = s->planewidth[3] = inlink->w; > > > + s->planeheight[1] = s->planeheight[2] = AV_CEIL_RSHIFT(inlink->h, > > > desc- > > > > log2_chroma_h); > > > + s->planeheight[0] = s->planeheight[3] = inlink->h; > > > + > > > + s->nb_planes = av_pix_fmt_count_planes(inlink->format); > > > + s->nb_threads = ff_filter_get_nb_threads(ctx); > > > + s->bpc = (s->depth + 7) / 8; > > > + > > > if (!strcmp(ctx->filter->name, "convolution")) { > > > for (i = 0; i < 4; i++) { > > > int *matrix = (int *)s->matrix[i]; > > > @@ -804,14 +762,7 @@ static int param_init(AVFilterContext *ctx) > > > s->bias[i] = s->delta; > > > } > > > } else if (!strcmp(ctx->filter->name, "sobel")) { > > > - for (i = 0; i < 4; i++) { > > > - s->filter[i] = filter_sobel; > > > - s->copy[i] = !((1 << i) & s->planes); > > > - s->size[i] = 3; > > > - s->setup[i] = setup_3x3; > > > - s->rdiv[i] = s->scale; > > > - s->bias[i] = s->delta; > > > - } > > > + ff_sobel_init(s, s->depth, s->nb_planes); > > > } else if (!strcmp(ctx->filter->name, "kirsch")) { > > > for (i = 0; i < 4; i++) { > > > s->filter[i] = filter_kirsch; > > > @@ -832,18 +783,6 @@ static int param_init(AVFilterContext *ctx) > > > } > > > } > > > > > > - s->depth = desc->comp[0].depth; > > > - s->max = (1 << s->depth) - 1; > > > - > > > - s->planewidth[1] = s->planewidth[2] = AV_CEIL_RSHIFT(inlink->w, desc- > > > > log2_chroma_w); > > > - s->planewidth[0] = s->planewidth[3] = inlink->w; > > > - s->planeheight[1] = s->planeheight[2] = AV_CEIL_RSHIFT(inlink->h, > > > desc- > > > > log2_chroma_h); > > > - s->planeheight[0] = s->planeheight[3] = inlink->h; > > > - > > > - s->nb_planes = av_pix_fmt_count_planes(inlink->format); > > > - s->nb_threads = ff_filter_get_nb_threads(ctx); > > > - s->bpc = (s->depth + 7) / 8; > > > - > > > if (!strcmp(ctx->filter->name, "convolution")) { > > > if (s->depth > 8) { > > > for (p = 0; p < s->nb_planes; p++) { > > > @@ -870,10 +809,6 @@ static int param_init(AVFilterContext *ctx) > > > if (s->depth > 8) > > > for (p = 0; p < s->nb_planes; p++) > > > s->filter[p] = filter16_roberts; > > > - } else if (!strcmp(ctx->filter->name, "sobel")) { > > > - if (s->depth > 8) > > > - for (p = 0; p < s->nb_planes; p++) > > > - s->filter[p] = filter16_sobel; > > > } else if (!strcmp(ctx->filter->name, "kirsch")) { > > > if (s->depth > 8) > > > for (p = 0; p < s->nb_planes; p++) > > > diff --git a/libavfilter/x86/vf_convolution.asm > > > b/libavfilter/x86/vf_convolution.asm > > > index 754d4d1064..c912d56752 100644 > > > --- a/libavfilter/x86/vf_convolution.asm > > > +++ b/libavfilter/x86/vf_convolution.asm > > > @@ -22,6 +22,18 @@ > > > > > > SECTION_RODATA > > > half: dd 0.5 > > > +data_p1: dd 1 > > > +data_n1: dd -1 > > > +data_p2: dd 2 > > > +data_n2: dd -2 > > > + > > > +ALIGN 64 > > > +sobel_perm: db 0, 16, 32, 48, 1, 17, 33, 49, 2, 18, 34, 50, 3, 19, > > > 35, > > > 51 > > > + db 4, 20, 36, 52, 5, 21, 37, 53, 6, 22, 38, 54, 7, 23, > > > 39, > > > 55 > > > + db 8, 24, 40, 56, 9, 25, 41, 57, 10, 26, 42, 58, 11, 27, > > > 43, > > > 59 > > > + db 12, 28, 44, 60, 13, 29, 45, 61, 14, 30, 46, 62, 15, 31, > > > 47, > > > 63 > > > +sobel_mulA: db -1, 1, -2, 2 > > > +sobel_mulB: db 1, -1, 2, -2 > > > > > > SECTION .text > > > > > > @@ -154,3 +166,138 @@ cglobal filter_3x3, 4, 15, 7, dst, width, rdiv, > > > bias, > > > matrix, ptr, c0, c1, c2, c > > > INIT_XMM sse4 > > > FILTER_3X3 > > > %endif > > > + > > > +%macro SOBEL_MUL 2 > > > + movzx ptrd, byte [c%1q + xq] > > > + imul ptrd, [%2] > > > + add rd, ptrd > > > +%endmacro > > > + > > > +%macro SOBEL_ADD 1 > > > + movzx ptrd, byte [c%1q + xq] > > > + add rd, ptrd > > > +%endmacro > > > + > > > +; void filter_sobel_avx512(uint8_t *dst, int width, > > > +; float scale, float delta, const int *const matrix, > > > +; const uint8_t *c[], int peak, int radius, > > > +; int dstride, int stride) > > > +%macro FILTER_SOBEL 0 > > > +%if UNIX64 > > > +cglobal filter_sobel, 4, 15, 7, dst, width, matrix, ptr, c0, c1, c2, c3, > > > c4, > > > c5, c6, c7, c8, r, x > > > +%else > > > +cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, > > > c1, > > > c2, c3, c4, c5, c6, c7, c8, r, x > > > +%endif > > > +%if WIN64 > > > + SWAP xmm0, xmm2 > > > + SWAP xmm1, xmm3 > > > + mov r2q, matrixmp > > > + mov r3q, ptrmp > > > + DEFINE_ARGS dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, > > > c8, > > > r, x > > > +%endif > > > + movsxdifnidn widthq, widthd > > > + VBROADCASTSS m0, xmm0 > > > + VBROADCASTSS m1, xmm1 > > > + pxor m6, m6 > > > + mov c0q, [ptrq + 0*gprsize] > > > + mov c1q, [ptrq + 1*gprsize] > > > + mov c2q, [ptrq + 2*gprsize] > > > + mov c3q, [ptrq + 3*gprsize] > > > + mov c4q, [ptrq + 4*gprsize] > > > + mov c5q, [ptrq + 5*gprsize] > > > + mov c6q, [ptrq + 6*gprsize] > > > + mov c7q, [ptrq + 7*gprsize] > > > + mov c8q, [ptrq + 8*gprsize] > > > + > > > + xor xq, xq > > > + cmp widthq, mmsize/4 > > > + jl .loop2 > > > + > > > + mov rq, widthq > > > + and rq, mmsize/4-1 > > > + sub widthq, rq > > > + > > > + mova m6, [sobel_perm] > > > +.loop1: > > > + movu xm3, [c2q + xq] > > > + pmovzxbd m5, [c0q + xq] > > > + vinserti32x4 ym3, [c6q + xq], 1 > > > + pmovzxbd m4, [c8q + xq] > > > + vinserti32x4 m2, m3, [c1q + xq], 2 > > > + vinserti32x4 m3, [c5q + xq], 2 > > > + vinserti32x4 m2, [c7q + xq], 3 > > > + vinserti32x4 m3, [c3q + xq], 3 > > > + vpermb m2, m6, m2 > > > + psubd m4, m5 > > > + vpermb m3, m6, m3 > > > + mova m5, m4 > > > + vpdpbusd m4, m2, [sobel_mulA] {1to16} > > > + vpdpbusd m5, m3, [sobel_mulB] {1to16} > > > + > > > + cvtdq2ps m4, m4 > > > + mulps m4, m4 > > > + > > > + cvtdq2ps m5, m5 > > > + VFMADD231PS m4, m5, m5 > > > + > > > + sqrtps m4, m4 > > > + fmaddps m4, m4, m0, m1 > > > + cvttps2dq m4, m4 > > > + vpmovusdb [dstq + xq], m4 > > > + > > > + add xq, mmsize/4 > > > + cmp xq, widthq > > > + jl .loop1 > > > + > > > + add widthq, rq > > > + cmp xq, widthq > > > + jge .end > > > + > > > +.loop2: > > > + xor rd, rd > > > + pxor m4, m4 > > > + > > > + ;Gx > > > + SOBEL_MUL 0, data_n1 > > > + SOBEL_MUL 1, data_n2 > > > + SOBEL_MUL 2, data_n1 > > > + SOBEL_ADD 6 > > > + SOBEL_MUL 7, data_p2 > > > + SOBEL_ADD 8 > > > + > > > + cvtsi2ss xmm4, rd > > > + mulss xmm4, xmm4 > > > + > > > + xor rd, rd > > > + ;Gy > > > + SOBEL_MUL 0, data_n1 > > > + SOBEL_ADD 2 > > > + SOBEL_MUL 3, data_n2 > > > + SOBEL_MUL 5, data_p2 > > > + SOBEL_MUL 6, data_n1 > > > + SOBEL_ADD 8 > > > + > > > + cvtsi2ss xmm5, rd > > > + fmaddss xmm4, xmm5, xmm5, xmm4 > > > + > > > + sqrtps xmm4, xmm4 > > > + fmaddss xmm4, xmm4, xmm0, xmm1 ;sum = sum * rdiv + bias > > > + cvttps2dq xmm4, xmm4 ; trunc to integer > > > + packssdw xmm4, xmm4 > > > + packuswb xmm4, xmm4 > > > + movd rd, xmm4 > > > + mov [dstq + xq], rb > > > + > > > + add xq, 1 > > > + cmp xq, widthq > > > + jl .loop2 > > > +.end: > > > + RET > > > +%endmacro > > > + > > > +%if ARCH_X86_64 > > > +%if HAVE_AVX512ICL_EXTERNAL > > > +INIT_ZMM avx512icl > > > +FILTER_SOBEL > > > +%endif > > > +%endif > > > diff --git a/libavfilter/x86/vf_convolution_init.c > > > b/libavfilter/x86/vf_convolution_init.c > > > index b78a47d02b..bff10ca1a4 100644 > > > --- a/libavfilter/x86/vf_convolution_init.c > > > +++ b/libavfilter/x86/vf_convolution_init.c > > > @@ -29,6 +29,11 @@ void ff_filter_3x3_sse4(uint8_t *dst, int width, > > > const uint8_t *c[], int peak, int radius, > > > int dstride, int stride, int size); > > > > > > +void ff_filter_sobel_avx512icl(uint8_t *dst, int width, > > > + float scale, float delta, const int *const > > > matrix, > > > + const uint8_t *c[], int peak, int radius, > > > + int dstride, int stride, int size); > > > + > > > av_cold void ff_convolution_init_x86(ConvolutionContext *s) > > > { > > > #if ARCH_X86_64 > > > @@ -44,3 +49,16 @@ av_cold void ff_convolution_init_x86(ConvolutionContext > > > *s) > > > } > > > #endif > > > } > > > + > > > +av_cold void ff_sobel_init_x86(ConvolutionContext *s, int depth, int > > > nb_planes) > > > +{ > > > +#if ARCH_X86_64 > > > + int cpu_flags = av_get_cpu_flags(); > > > + for (int i = 0; i < nb_planes; i++) { > > > + if (depth == 8) { > > > + if (EXTERNAL_AVX512ICL(cpu_flags)) > > > + s->filter[i] = ff_filter_sobel_avx512icl; > > > + } > > > + } > > > +#endif > > > +} > > > diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile > > > index 62d6616faf..a6f06c7007 100644 > > > --- a/tests/checkasm/Makefile > > > +++ b/tests/checkasm/Makefile > > > @@ -46,6 +46,7 @@ AVFILTEROBJS-$(CONFIG_GBLUR_FILTER) += vf_gblur.o > > > AVFILTEROBJS-$(CONFIG_HFLIP_FILTER) += vf_hflip.o > > > AVFILTEROBJS-$(CONFIG_THRESHOLD_FILTER) += vf_threshold.o > > > AVFILTEROBJS-$(CONFIG_NLMEANS_FILTER) += vf_nlmeans.o > > > +AVFILTEROBJS-$(CONFIG_SOBEL_FILTER) += vf_convolution.o > > > > > > CHECKASMOBJS-$(CONFIG_AVFILTER) += $(AVFILTEROBJS-yes) > > > > > > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > > > index 421bd096c5..3eb4780a64 100644 > > > --- a/tests/checkasm/checkasm.c > > > +++ b/tests/checkasm/checkasm.c > > > @@ -197,6 +197,9 @@ static const struct { > > > #if CONFIG_THRESHOLD_FILTER > > > { "vf_threshold", checkasm_check_vf_threshold }, > > > #endif > > > + #if CONFIG_SOBEL_FILTER > > > + { "vf_sobel", checkasm_check_vf_sobel }, > > > + #endif > > > #endif > > > #if CONFIG_SWSCALE > > > { "sw_gbrp", checkasm_check_sw_gbrp }, > > > diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h > > > index ee9151410e..214918e7ea 100644 > > > --- a/tests/checkasm/checkasm.h > > > +++ b/tests/checkasm/checkasm.h > > > @@ -86,6 +86,7 @@ void checkasm_check_vf_eq(void); > > > void checkasm_check_vf_gblur(void); > > > void checkasm_check_vf_hflip(void); > > > void checkasm_check_vf_threshold(void); > > > +void checkasm_check_vf_sobel(void); > > > void checkasm_check_vp8dsp(void); > > > void checkasm_check_vp9dsp(void); > > > void checkasm_check_videodsp(void); > > > diff --git a/tests/checkasm/vf_convolution.c > > > b/tests/checkasm/vf_convolution.c > > > new file mode 100644 > > > index 0000000000..007865863e > > > --- /dev/null > > > +++ b/tests/checkasm/vf_convolution.c > > > @@ -0,0 +1,104 @@ > > > +/* > > > + * This file is part of FFmpeg. > > > + * > > > + * FFmpeg is free software; you can redistribute it and/or modify > > > + * it under the terms of the GNU General Public License as published by > > > + * the Free Software Foundation; either version 2 of the License, or > > > + * (at your option) any later version. > > > + * > > > + * FFmpeg is distributed in the hope that it will be useful, > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > > + * GNU General Public License for more details. > > > + * > > > + * You should have received a copy of the GNU General Public License > > > along > > > + * with FFmpeg; if not, write to the Free Software Foundation, Inc., > > > + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > > + */ > > > + > > > +#include > > > +#include "checkasm.h" > > > +#include "libavfilter/avfilter.h" > > > +#include "libavfilter/convolution.h" > > > +#include "libavutil/intreadwrite.h" > > > +#include "libavutil/mem_internal.h" > > > + > > > +#define WIDTH 512 > > > +#define HEIGHT 512 > > > +#define SRC_STRIDE 512 > > > +#define PIXELS (WIDTH * HEIGHT) > > > + > > > +#define randomize_buffers(buf, size) \ > > > + do { \ > > > + int j; \ > > > + uint8_t *tmp_buf = (uint8_t *)buf;\ > > > + for (j = 0; j< size; j++) \ > > > + tmp_buf[j] = rnd() & 0xFF; \ > > > + } while (0) > > > + > > > +static void check_sobel(const char * report_name) > > > +{ > > > + LOCAL_ALIGNED_32(uint8_t, src, [PIXELS]); > > > + LOCAL_ALIGNED_32(uint8_t, dst_ref, [PIXELS]); > > > + LOCAL_ALIGNED_32(uint8_t, dst_new, [PIXELS]); > > > + const int height = WIDTH; > > > + const int width = HEIGHT; > > > + const int stride = SRC_STRIDE; > > > + const int dstride = SRC_STRIDE; > > > + int mode = 0; > > > + const uint8_t *c[49]; > > > + const int radius = 1; > > > + const int bpc = 1; > > > + const int step = mode == MATRIX_COLUMN ? 16 : 1; > > > + const int slice_start = 0; > > > + const int slice_end = height; > > > + int y; > > > + const int sizew = mode == MATRIX_COLUMN ? height : width; > > > + float scale = 2; > > > + float delta = 10; > > > + > > > + ConvolutionContext s; > > > + > > > + declare_func(void, uint8_t *dst, int width, float scale, float delta, > > > const int *const matrix, > > > + const uint8_t *c[], int peak, int radius, int dstride, > > > int > > > stride, int size); > > > + > > > + s.scale = scale; > > > + s.delta = delta; > > > + s.depth = 8; > > > + s.nb_planes = 3; > > > + s.planes = 15; > > > + ff_sobel_init(&s, s.depth, s.nb_planes); > > > + > > > + memset(dst_ref, 0, PIXELS); > > > + memset(dst_new, 0, PIXELS); > > > + randomize_buffers(src, PIXELS); > > > + > > > + if (check_func(s.filter[0], "%s", report_name)) { > > > + for (y = slice_start; y < slice_end; y += step) { > > > + const int xoff = mode == MATRIX_COLUMN ? (y - slice_start) * > > > bpc > > > : radius * bpc; > > > + const int yoff = mode == MATRIX_COLUMN ? radius * dstride : > > > 0; > > > + > > > + s.setup[0](radius, c, src, stride, radius, width, y, height, > > > bpc); > > > + call_ref(dst_ref + yoff + xoff, sizew - 2 * radius, > > > + scale, delta, NULL, c, 0, radius, > > > + dstride, stride, slice_end - step); > > > + call_new(dst_new + yoff + xoff, sizew - 2 * radius, > > > + scale, delta, NULL, c, 0, radius, > > > + dstride, stride, slice_end - step); > > > + if (memcmp(dst_ref + yoff + xoff, dst_new + yoff + xoff, > > > slice_end - step)) > > > + fail(); > > > + bench_new(dst_new + yoff + xoff, sizew - 2 * radius, > > > + scale, delta, NULL, c, 0, radius, > > > + dstride, stride, slice_end - step); > > > + if (mode != MATRIX_COLUMN) > > > + dst_ref += dstride; > > > + } > > > + } > > > + > > > +} > > > + > > > +void checkasm_check_vf_sobel(void) > > > +{ > > > + check_sobel("sobel"); > > > + report("convolution:sobel"); > > > +} > > > diff --git a/tests/fate/checkasm.mak b/tests/fate/checkasm.mak > > > index aa9b288e12..a4e95541f5 100644 > > > --- a/tests/fate/checkasm.mak > > > +++ b/tests/fate/checkasm.mak > > > @@ -43,6 +43,7 @@ FATE_CHECKASM = fate-checkasm- > > > aacpsdsp \ > > > fate-checkasm-vf_hflip \ > > > fate-checkasm-vf_nlmeans \ > > > fate-checkasm-vf_threshold \ > > > + fate-checkasm-vf_sobel \ > > > fate-checkasm-videodsp \ > > > fate-checkasm-vorbisdsp \ > > > fate-checkasm-vp8dsp \ > > > > LGTM and it works well for me, I saw a significant FPS improvement when > > running > > the command below. > > > > $ ffmpeg -i 1920x1080.mp4 -vf "sobel" -f null - > > > > Does anyone else have any thought on this patch? I will merge it if there are > no > more comments. Pushed, -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".