From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 078FC4A469 for ; Tue, 30 Apr 2024 18:21:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 267B268D5FF; Tue, 30 Apr 2024 21:21:19 +0300 (EEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E1B7668D449 for ; Tue, 30 Apr 2024 21:21:11 +0300 (EEST) Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-516d68d7a8bso91277e87.1 for ; Tue, 30 Apr 2024 11:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1714501271; x=1715106071; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=kR1fB+jv6fT1NeE0A4OQJVcPo5VLj130G49e4XYNxkI=; b=mxRERv+od4X0MtFchxnnCyj2ildQlEZ4PwBx24Wi/tAnitC5JJdulUYP5Gj/7WA47t q7Kr+3Tbpj2bUzkH1XAFHCewJ81+xkXwaRVX4fZisq9hjkB6UNEToQyGH1F0jUI7ecpL agFUQLTIehRB9zWskopf8e3NRwxxnE8jDW0ZOd/PQXhCUS7GVJq49tl9Roxgmdle7ng6 yGbD2+NMW8Dj5fqCNaOC9Cl7RdHxMZzmoheVcoLdGw2wZtofDvz7dBGXEuYZOCxLoK7V l6+2GE5q5Z499+wwNhjPQnxhd89TZaUdQfhj+jZ4bc42LpevGXOuvXL3pNaHSHhDrth5 H52g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714501271; x=1715106071; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kR1fB+jv6fT1NeE0A4OQJVcPo5VLj130G49e4XYNxkI=; b=u401zysIJvtZwB4HJu3oINskJJAYDDeHdwWUAsvKBZi8kqG674pD13m0BgUoCJguYS iShSJZt8kr8qo1ysUI5Cs+UXD/YPQzxDFXSn//utrIYySLFoXzMjfvCclcy2Y5DQN7rZ TWNIJFAyDRG8dPUTRN9w/ROPatFIpnOqLAxZvR41RmqExMDTFOMrK5/IT8o1S/YaMGWd +Gs5Gv8r07CuDuveF+OL+fu3NF/q6u5cSfT6LxDiEcKhcUlM7QNQjwtxAfWY5yyT5pIf LOn418UbxOAefIKpKqjSXSP63GYu/ylbab1ZVD4zOaDbcaHIwhgxhIoEodw4bnO9v5sM StNg== X-Gm-Message-State: AOJu0Yzg5qN8j13YHZgFK1xH+VGbIa8f2Zv05Gt7C6Sp5+V8+Kjx+S19 HWNs4+HTX6tvdKVNP5yLGuG/HkRGWBEhCTh+E+b+MM2dlV9mCcRZ6FAPyj6dp40FevTSTfVOaqB HQA== X-Google-Smtp-Source: AGHT+IEMxoyYl+ZZDQyoxmG/bv57ZNq6xu9iWd+ez0zr2h0kKi3ToqZSW3uZRxMOOtO4oo0FH61C3Q== X-Received: by 2002:ac2:5f7c:0:b0:51b:ab9f:6b5c with SMTP id c28-20020ac25f7c000000b0051bab9f6b5cmr1010776lfc.1.1714501270751; Tue, 30 Apr 2024 11:21:10 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id t29-20020a19911d000000b0051e18971c6asm529066lfd.55.2024.04.30.11.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 11:21:10 -0700 (PDT) Date: Tue, 30 Apr 2024 21:21:02 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <5df0319c-bf-88f8-74a6-9997d116dcf@martin.st> References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/vp3dsp_init: Set correct function pointer, fix crash X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 30 Apr 2024, Andreas Rheinhardt wrote: > Regression since fd172185580c1ccdcfb90bbfdb59fa806fad3117; > triggered by vp4/KTkvw8dg1J8.avi in the FATE suite, but not > when running fate as this code is not used when the bitexact > flag is set. > > Bisecting done by ami_stuff, patch from user Mika Fischer > in ticket #10027 (which this commit fixes). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/x86/vp3dsp_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/x86/vp3dsp_init.c b/libavcodec/x86/vp3dsp_init.c > index f54fa57b3e..edac1764cb 100644 > --- a/libavcodec/x86/vp3dsp_init.c > +++ b/libavcodec/x86/vp3dsp_init.c > @@ -53,7 +53,7 @@ av_cold void ff_vp3dsp_init_x86(VP3DSPContext *c, int flags) > > if (!(flags & AV_CODEC_FLAG_BITEXACT)) { > c->v_loop_filter = c->v_loop_filter_unaligned = ff_vp3_v_loop_filter_mmxext; > - c->h_loop_filter = c->v_loop_filter_unaligned = ff_vp3_h_loop_filter_mmxext; > + c->h_loop_filter = c->h_loop_filter_unaligned = ff_vp3_h_loop_filter_mmxext; > } > } > > -- > 2.40.1 LGTM // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".