From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavf/mxfenc: Bump EDIT_UNITS_PER_BODY
Date: Mon, 13 Feb 2023 20:33:07 +0100 (CET)
Message-ID: <5d33a37e-27ce-a39c-5c2f-b1235501a81@passwd.hu> (raw)
In-Reply-To: <8f54f0fa3e1877fbc74fd5b52b39f73a97be8858.camel@haerdin.se>
On Mon, 13 Feb 2023, Tomas Härdin wrote:
> Passes FATE because we don't have any tests that mux files with a
> whopping 250 frames. Tested with a jpeg2000 Tears of Steel sample.
Have you checked what BMX does? Because as far as I remember for
RDD9 (XDCAM HD) this should not exceed 10 seconds.
I suggest adding an option for this with -1 default, and unless the user
overrides it make it 238 in case of MPEG2 essence, and infinite (0)
otherwise.
There is also code which allocates the index entries in
EDIT_UNITS_PER_BODY increments, that probably should be replaced with
av_dynarray2_add...
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-13 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 9:58 Tomas Härdin
2023-02-13 19:33 ` Marton Balint [this message]
2023-02-13 20:45 ` Tomas Härdin
2023-02-13 21:05 ` Marton Balint
2023-02-14 9:19 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d33a37e-27ce-a39c-5c2f-b1235501a81@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git