From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6CAB14257D for ; Fri, 18 Mar 2022 22:13:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 449E768AF4C; Sat, 19 Mar 2022 00:13:35 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2399F68A43A for ; Sat, 19 Mar 2022 00:13:29 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 22IMDQ0I025955-22IMDQ0J025955 for ; Sat, 19 Mar 2022 00:13:26 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id C45D6A1438 for ; Sat, 19 Mar 2022 00:13:26 +0200 (EET) Date: Sat, 19 Mar 2022 00:13:26 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20220318081521.60218-1-martin@martin.st> Message-ID: <5cd1d131-9652-6741-47eb-95eaae82dfa3@martin.st> References: <20220318081521.60218-1-martin@martin.st> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] Keep including the full version.h when headers are included externally X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-15"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 18 Mar 2022, Martin Storsj=F6 wrote: > This avoids unnecessary churn and build breakage for users, by > making sure the whole version.h is included like it has been so far, > while keeping the benefit of not needing to rebuild most files in > the ffmpeg tree on minor/micro bumps. > --- > Surprisingly many downstream users do seem to rely on the version > defines. > --- > doc/APIchanges | 9 ++------- > libavcodec/avcodec.h | 6 ++++++ > libavdevice/avdevice.h | 6 ++++++ > libavfilter/avfilter.h | 6 ++++++ > libavformat/avformat.h | 6 ++++++ > libpostproc/postprocess.h | 6 ++++++ > libswresample/swresample.h | 6 ++++++ > libswscale/swscale.h | 6 ++++++ > 8 files changed, 44 insertions(+), 7 deletions(-) I'll go ahead and push this; Andreas wasn't against it, and it avoids = unnecessary downstream breakage. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".