From: "Martin Storsjö" <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] Keep including the full version.h when headers are included externally
Date: Sat, 19 Mar 2022 00:13:26 +0200 (EET)
Message-ID: <5cd1d131-9652-6741-47eb-95eaae82dfa3@martin.st> (raw)
In-Reply-To: <20220318081521.60218-1-martin@martin.st>
On Fri, 18 Mar 2022, Martin Storsjö wrote:
> This avoids unnecessary churn and build breakage for users, by
> making sure the whole version.h is included like it has been so far,
> while keeping the benefit of not needing to rebuild most files in
> the ffmpeg tree on minor/micro bumps.
> ---
> Surprisingly many downstream users do seem to rely on the version
> defines.
> ---
> doc/APIchanges | 9 ++-------
> libavcodec/avcodec.h | 6 ++++++
> libavdevice/avdevice.h | 6 ++++++
> libavfilter/avfilter.h | 6 ++++++
> libavformat/avformat.h | 6 ++++++
> libpostproc/postprocess.h | 6 ++++++
> libswresample/swresample.h | 6 ++++++
> libswscale/swscale.h | 6 ++++++
> 8 files changed, 44 insertions(+), 7 deletions(-)
I'll go ahead and push this; Andreas wasn't against it, and it avoids
unnecessary downstream breakage.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-03-18 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 8:15 Martin Storsjö
2022-03-18 22:13 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cd1d131-9652-6741-47eb-95eaae82dfa3@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git