From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EE741407C9 for ; Mon, 31 Jan 2022 10:11:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DAC9768B203; Mon, 31 Jan 2022 12:11:06 +0200 (EET) Received: from shout01.mail.de (shout01.mail.de [62.201.172.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F75968B083 for ; Mon, 31 Jan 2022 12:11:00 +0200 (EET) Received: from postfix01.mail.de (postfix03.bt.mail.de [10.0.121.127]) by shout01.mail.de (Postfix) with ESMTP id 805AAA05F3; Mon, 31 Jan 2022 11:10:59 +0100 (CET) Received: from smtp01.mail.de (smtp01.bt.mail.de [10.0.121.211]) by postfix01.mail.de (Postfix) with ESMTP id 649C580127; Mon, 31 Jan 2022 11:10:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1643623859; bh=gipBI3q6DVTRaf3ubVjRtAuqhsJHyfDB7wyKswsxNDo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mbl0+a4W/ZDh5Xm6KpYgqGGAHG/pfCjviP5e5j7+49cQAWIjx7uODKq/0tXUO0Yhz PjqueDI1YYiP2vB+3cKDsL/yPMmncY3tB4Y5+64zIwiwilcK7YiDHhRZsZyQ+kYnuT 1be2/yASujz6hrNatNrIHB85mtQqM56XhN8rUCh1NZXQKqWPWPVYZTOO5TbhQVkiXL 79k4OKQjgF58nXcv/Pp4L3KK9Sbni3hQfCdqg1qmnrQYTnUfhI/r/L/TfVDiR+tHF7 hXjbZRQJN4JKppmEjLxc+0kV4w96zGsE3tcC9G5z9Upmi7scHolXY/2yTplih0fDSS 3sodpocDB9l4w== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtp01.mail.de (Postfix) with ESMTPSA id CAB9E100275; Mon, 31 Jan 2022 11:10:58 +0100 (CET) Message-ID: <5c568e1c-0467-5e75-ec1d-9cbbe8c991c0@mail.de> Date: Mon, 31 Jan 2022 11:10:57 +0100 MIME-Version: 1.0 Content-Language: en-US To: toots@rastageeks.org, ffmpeg-devel@ffmpeg.org References: <20220130173045.32690-1-toots@rastageeks.org> <20220130173045.32690-2-toots@rastageeks.org> From: Thilo Borgmann In-Reply-To: <20220130173045.32690-2-toots@rastageeks.org> X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 1439 X-purgate-ID: 154282::1643623859-000015F2-3DBC2151/0/0 Subject: Re: [FFmpeg-devel] [PATCH 1/4] Use appropriate method for device discovery, fix crash with bogus device index. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: epirat07@gmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, Am 30.01.22 um 18:30 schrieb toots@rastageeks.org: > From: Romain Beauxis > > This updates the code for avfoundation to use modern device lookup APIs and also adds a check to avoid querying the video devices array beyound its maximum size. > > --- > libavdevice/avfoundation.m | 71 ++++++++++++++++++++++++++++++-------- > 1 file changed, 56 insertions(+), 15 deletions(-) > > diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m > index 0cd6e646d5..d8bcd98f81 100644 > --- a/libavdevice/avfoundation.m > +++ b/libavdevice/avfoundation.m > @@ -27,6 +27,7 @@ > > #import > #include > +#include > > #include "libavutil/channel_layout.h" > #include "libavutil/pixdesc.h" > @@ -764,8 +765,34 @@ static int avf_read_header(AVFormatContext *s) [...] the patch doesn't appear to be broken any more, though it does not apply to current HEAD Thilos-Mac-mini:FFmpeg borgmann$ git apply ../patches/avfoundation/\[PATCH\ 1_4\]\ Use\ appropriate\ method\ for\ device\ discovery\,\ fix\ crash\ with\ bogus\ device\ index.\ -\ toots\@rastageeks.org\ -\ 2022-01-30\ 1830.eml error: patch failed: libavdevice/avfoundation.m:27 error: libavdevice/avfoundation.m: patch does not apply I don't see why it does not apply as the part around line 27 looks sane. Did you try to apply to HEAD? -Thilo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".