From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 63035412C9 for ; Wed, 16 Feb 2022 11:45:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1E7C168B238; Wed, 16 Feb 2022 13:45:07 +0200 (EET) Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6E2868AF87 for ; Wed, 16 Feb 2022 13:45:00 +0200 (EET) Message-ID: <5bf9971e-a6da-70a1-0238-a101de35f7d4@zanevaniperen.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zanevaniperen.com; s=key1; t=1645011899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lsmXBbnInnMJVxPSx10haWe0oa/0b7hYoV4doiuNPt8=; b=e7Z0osDBAry2hLnETsuNljRTJZKy7QkcKXH5SKXjoPVaW8kt3EPywJUYKmKio+SOjB+E3Z lWs3J9aE4TGJE9hri8yERxhCRX06HrUfBbyvcH3IZcS5OdYvsmWYWsRj7oP8QwBCD1Y4Oq cCdXXoSb2gJp5LYWXM/ax9pUmaTsPKDJH7AmwixFPaTB7qAEo4BWPIod1Hvuf8KstipFLF dkbVFYvurT2php1E7LulpzjSKXpbxFDgGhpLy1ZXPpkzH6mtnD8ZCopqwVI0V19YNcjFpE RRxjsWI2VUC0YPwIVBAIFlS3MQIg3wKy3zn6oVY68TqcpzWNXF1qhI+PYISZTQ== Date: Wed, 16 Feb 2022 21:44:54 +1000 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220203040745.10983-1-pal@sandflow.com> <20220203040745.10983-2-pal@sandflow.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zane van Iperen In-Reply-To: <20220203040745.10983-2-pal@sandflow.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: zanevaniperen.com Subject: Re: [FFmpeg-devel] [PATCH v3 2/4] avformat/imf: fix missing error reporting when opening resources X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/2/22 14:07, pal@sandflow.com wrote: > From: Pierre-Anthony Lemieux > > --- > libavformat/imfdec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > index e6a1020ecc..658ddc40f2 100644 > --- a/libavformat/imfdec.c > +++ b/libavformat/imfdec.c > @@ -550,7 +550,9 @@ static int set_context_streams_from_tracks(AVFormatContext *s) > AVStream *first_resource_stream; > > /* Open the first resource of the track to get stream information */ > - open_track_resource_context(s, &c->tracks[i]->resources[0]); > + ret = open_track_resource_context(s, &c->tracks[i]->resources[0]); > + if (ret) > + return ret; > first_resource_stream = c->tracks[i]->resources[0].ctx->streams[0]; > av_log(s, AV_LOG_DEBUG, "Open the first resource of track %d\n", c->tracks[i]->index); > Can you please squash this into the previous patch? The rest looks mostly okay. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".