From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BC4C740D3F for ; Tue, 13 Aug 2024 07:22:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6B7E168D925; Tue, 13 Aug 2024 10:22:24 +0300 (EEST) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 67A4068D8A4 for ; Tue, 13 Aug 2024 10:22:17 +0300 (EEST) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5b391c8abd7so6080794a12.2 for ; Tue, 13 Aug 2024 00:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1723533736; x=1724138536; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=9PI5I6VADIa77nRU4BcbzRU28A24m7EOvj99/4pbPW8=; b=NRGKQ7xOqlgH1+2qJoia3y3XGG086we/L+ZWEDvkxaXwgCl5+6/ol2A6SijXP1gxsu XP21pk2q0FnJRO8nfKPRUi/KM5okCp9iEPry1V79NGpBZLlisk4Li6I4K8cKK/nSMMly xNC94UxAD2x4LDiFDLNC2+YAVY421xRGY8UtJ7zSAWD+Uy/+JzMTbu0NBHrRo3PKgCT8 itMtCi1/KYn+0CBnDZV7GQtQh7hyQp6jZkHlmeXgqxAf20JBZRUOs7MBBOSJKwoTC87b GBc9AeNEj08eyfzO+mbi5h1Tzpu4AbTk8a4o8XQMLXMT3eqL+bZzFDIl+EceX5/cPmR5 Fzyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723533736; x=1724138536; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9PI5I6VADIa77nRU4BcbzRU28A24m7EOvj99/4pbPW8=; b=mhXsCvuUnNYrT5y4UYNo/90nqeRn/ggnhm+9kwyfT3F89b/+B7nT4O04DhwoH1sKA2 /ylxKzQfHRU+k1I6ykh4nGglJjcmD7msSlxe6b1S26J8YB23evrlPs5CZEwG3h4Bl6Ks c2+o8uSUnJJNUWrwecCn1h8XuV3YYjgXzNehIIcqE1t6JztuOgXgh2cSL1IumK8KEA1M b8F0izhQ4zie8Md8s7gbmpFPvUkrj96ixft3F0Zya4koEirrYdKrTOp7lVTmFczF7Cc9 XY5DJBRCf/cBs+2uQQFkrHQLPeQcHm9uhk0P9as/VTglWTjh4ug1ObMOdR5Rgghu7din mSYQ== X-Gm-Message-State: AOJu0YzD61HcrUgJOb+GpsILMQpC2HL/UfUH5SumjiyqD+k71TOQcf60 StS0Y5dNyWc/9clwDDDgC/XyZVd+/1L2dWn5yh5laAOr6i8lgOUrt8y2zdfQ42aRXhMnk0gGJgF Ptg== X-Google-Smtp-Source: AGHT+IHMWnQVNNqsuYSqQejF5ashpu0KcLF+JkzncPgOaiIQ5RJLu1AgCXuI3wfjwcFtmt/C6PnVgg== X-Received: by 2002:a05:6402:34ce:b0:5a3:af31:9ae4 with SMTP id 4fb4d7f45d1cf-5bd44c0e198mr1791127a12.5.1723533736121; Tue, 13 Aug 2024 00:22:16 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bd196a756esm2686919a12.52.2024.08.13.00.22.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 00:22:15 -0700 (PDT) Date: Tue, 13 Aug 2024 10:22:12 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: ffmpeg-devel@ffmpeg.org In-Reply-To: <20240813021302.DA60E412665@natalya.videolan.org> Message-ID: <5bc48c14-7952-ffcb-204e-21d42d1279c@martin.st> References: <20240813021302.DA60E412665@natalya.videolan.org> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/video: don't zero allocated buffers if memory poisoning is used X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 13 Aug 2024, James Almer wrote: > ffmpeg | branch: master | James Almer | Sat Aug 10 21:31:16 2024 -0300| [41307ff3e9384c51d646bff7e3dcf0d554098a8f] | committer: James Almer > > avfilter/video: don't zero allocated buffers if memory poisoning is used > > Same as in avcodec/get_buffer.c > Should help in debugging use of uninitialized memory. > > Signed-off-by: James Almer > >> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=41307ff3e9384c51d646bff7e3dcf0d554098a8f > --- > > libavfilter/video.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) This change broke a bunch of fate tests - in particular fate-vsynth3-rpza and most fate-filter-pixfmts-*. The issue doesn't show up in normal builds of ffmpeg, unless building with --enable-memory-poisoning. And in such a build, tools like valgrind doesn't detect the issue right away, as the memory poisoning causes the buffers to be deterministically initialized to a nonzero value (but the fate test produces the wrong output). // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".